Repository navigation
chore(bitgo): deprecate sjcl export and drop unused SJCL deps - #10077
Open
pranavjain97 wants to merge 2 commits into
Open
pranavjain97 wants to merge 2 commits into
pranavjain97 wants to merge 2 commits into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
|
s84krish
previously approved these changes
Oct 27, 2026
s84krish
previously approved these changes
Nov 3, 2026
s84krish
left a comment
s84krish
left a comment
Contributor
There was a problem hiding this comment.
merge conflicts again :(
Note that the bitgo.sjcl export may be removed in a future major release. Move @bitgo/sjcl to devDependencies in sdk-coin-polygon, where only tests use it. In web-demo, build the demo keycard with encrypt from sdk-api and drop the direct @bitgo/sjcl dependency. Ticket: WCN-177
Drop the direct @bitgo/sjcl import. Await assertIsValidKey, which is async, so the example's error cases are actually caught. Ticket: WCN-177
pranavjain97
force-pushed
the
pranavjain/wcn-177-remove-dead-sjcl-touchpoints-re-export-demo-unused-deps
branch
from
November 5, 2026 17:41
d6c94d2 to
de52614
Compare
s84krish
approved these changes
Nov 5, 2026
nayandas190
approved these changes
Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small SJCL cleanup that does not touch crypto behavior.
bitgo.sjclexport: the deprecation notice now says it may be removed in a future major release and points tobitgo.encrypt/bitgo.decrypt. Nothing is removed, and SJCL stays for v1 decrypt.sdk-coin-polygon:@bitgo/sjclmoves to devDependencies, since only tests use it.web-demo: the demo keycard fixture now usesencryptfrom@bitgo/sdk-apiinstead of@bitgo/sjcl, and the direct dependency is dropped. The demo keycard now shows a v2 envelope.Testing
sdk-coin-polygonunit tests pass.web-demotypechecks.Ticket: WCN-177
🤖 Generated with Claude Code