Skip to content

Release 2.10.1 - #178

Merged
tastybento merged 16 commits into
masterfrom
develop
Nov 17, 2026
Merged

tastybento merged 16 commits into
masterfrom
develop

Conversation

@tastybento

@tastybento tastybento commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Release 2.10.1: a fix release.

Draft release notes: https://github.com/BentoBoxWorld/MagicCobblestoneGenerator/releases/tag/untagged-d38f1a497fe730b633b3

🤖 Generated with Claude Code

tastybento and others added 16 commits July 29, 2026 09:07
The pinned SHA predates BentoBoxWorld/.github#13, which moved the CurseForge
metadata and Hangar versionUpload JSON out of inline curl -F values and into
files. curl treats a ';' in an inline -F value as the start of a type=
attribute, so a release body containing a semicolon truncates the JSON and
both platforms reject the upload.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SAQ3YQkcfRoCZEwa6SPJcp
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SAQ3YQkcfRoCZEwa6SPJcp
ci: bump publish-platforms pin to the multipart-JSON fix
The generator type controls which of the vanilla lava mechanics activates
a tier, but the Generator Type button in the edit panel only said that it
"defines which generator type will be applied". The hint about the
mechanic behind each type was only visible after opening the type picker,
so admins could easily miss that a STONE tier fires on any water a player
can pour lava onto, oceans included.

The button description now lists the mechanic for each type.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SDLdE5LSXRwc6NQhYvzyiv
Every translated locale was 28 keys behind en-US: the admin reset command,
the custom block conversation prompts, the accept_generator,
activate_on_unlock, add_custom_block and required_generators buttons, the
phase / block-count / required-generator requirement lines, the select
generator title and the generator-data-reset message. Those keys fall back
to the English text (or to the raw reference) in game.

Translate and add all of them, and give the Generator Type button the same
per-type explanation that en-US just gained, reusing the generator type
names each file already uses in its type picker.

Two placeholder lists were also stale, so features could not render at all
in those languages: the generator lore was missing [height-range] and the
requirements list was missing [phase], [block-count] and
[required-generators]. Some files had the placeholder tokens themselves
translated (for example [biomas], [缺失权限], [missing-permission]), which
never matches what the code substitutes. Both lists are now the canonical
tokens everywhere.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SDLdE5LSXRwc6NQhYvzyiv
…type-button

Explain the lava mechanic behind each generator type, and sync the locales
A cooldown shorter than the exhaustion period did nothing: when it
expired the block count was still at the limit, so the generator went
straight back on cooldown until the period ended. Now an expired
cooldown starts a fresh period with the count reset to 0.

A cooldown of 0 keeps its previous meaning (wait until the period ends)
by holding the generator until the period end, which also makes the
generator-exhausted message show the correct minutes remaining.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The number formatter used owner.getLocale(), but owner is null on spawn
islands and islands without an owner. Format with the purchasing user's
locale instead: they are the one who receives the messages.

Fixes Sonar java:S2259.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Database import wiped all of a game mode's generator tiers before
  loading the file, so a typo in the file name (or an empty/broken file)
  deleted every generator. Now the file is loaded first and the old
  generators are only removed once it loaded; the admin is told in chat
  when the file is not found.
- activateGenerator threw a NullPointerException when overwrite-on-active
  needed to free a slot held by a generator that has since been deleted.
  The stale id is now dropped instead.
- Database import/export and template import accepted file names like
  "../x", reaching files outside the addon folder. They are now refused.
- Height-range error messages in the generator edit panel never showed:
  wrong key path, a missing min-height key, and [MIN]/[MAX] placeholders
  that did not match the [min]/[max] constants. The panel now also
  reopens after the error.
- Paged panels showed an empty extra page when the item count was an
  exact multiple of 21 (reachable through the wrap-around arrows in the
  generator edit panel, or by deleting items on the last page).
- GitHub library downloads ran the import on an async thread; it now
  runs on the main thread.
- Database command tab completion no longer throws if the addon folder
  cannot be listed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Minimum/Maximum Height buttons on the main generator edit panel
accepted any value, so min could be set above max (e.g. min 150, max
100), which stops the generator working at every height. Reject such
values with the same error messages as the per-block height panel.

Also fix the en-US tooltip for these buttons: they set the range for the
whole generator, not "this material".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Titles built from a name ("Generator: Starting Nether Generator") ran past
the edge of the window, because the client does not cut long titles.

- Generator, bundle and island panels now show just the name as the
  title, giving it the full width.
- Names are shortened with an ellipsis when they still do not fit,
  measured with the default Minecraft font widths (bold). The Height
  Range panel keeps its label and shortens the block name the same way.
- The Spanish and Vietnamese titles used translated placeholders
  ([generador], [paquete], [isla], [gói]), so the name never appeared.
  Rewriting the title values fixes them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sets-period

Start a new exhaustion period when the cooldown ends
The number formatter used owner.getLocale(), but owner is null on spawn
islands and islands without an owner. Format with the purchasing user's
locale instead: they are the one who receives the messages.

Fixes Sonar java:S2259.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reliability (quality gate):
- IslandEditPanel: read the island name before getGeneratorData, whose
  null check made Sonar treat the island as nullable.
- IslandEditPanel: null-safe game mode name in three button descriptions.
- canPurchaseGenerator NPE: cherry-picked from #176.

Code smells in StoneGeneratorImportManager: constants for repeated
literals, rename a local that hid a field, extract export error
reporting to cut complexity, make DefaultJSONHandler fields final.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@tastybento
tastybento merged commit f0d6f31 into master Nov 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant