Skip to content

Phase finales: a boss ends each phase - #566

Merged
tastybento merged 2 commits into
developfrom
feature/phase-finales
Nov 11, 2026
Merged

tastybento merged 2 commits into
developfrom
feature/phase-finales

fix: phase bar shows the pending boss and steps aside for the fight

7387498
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Nov 11, 2026 in 47s

Annotations

Check warning on line 29 in src/main/java/world/bentobox/aoneblock/events/PhaseFinaleEndEvent.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this method; it hides "getHandlerList" in "BentoBoxEvent".

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLohB4MTHYKDZflEuU&open=AaHLohB4MTHYKDZflEuU&pullRequest=566

Check warning on line 32 in src/main/java/world/bentobox/aoneblock/events/PhaseFinaleStartEvent.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this method; it hides "getHandlerList" in "BentoBoxEvent".

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLohB2MTHYKDZflEuT&open=AaHLohB2MTHYKDZflEuT&pullRequest=566

Check warning on line 304 in src/main/java/world/bentobox/aoneblock/listeners/FinaleListener.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this expression which always evaluates to "false"

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLohB0MTHYKDZflEuR&open=AaHLohB0MTHYKDZflEuR&pullRequest=566

Check warning on line 123 in src/test/java/world/bentobox/aoneblock/listeners/FinaleListenerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this mock creation to a local variable.

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLog7ZMTHYKDZflEuM&open=AaHLog7ZMTHYKDZflEuM&pullRequest=566

Check failure on line 1006 in src/main/java/world/bentobox/aoneblock/oneblocks/OneBlocksManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Phase " 4 times.

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLohExMTHYKDZflEuV&open=AaHLohExMTHYKDZflEuV&pullRequest=566

Check warning on line 478 in src/main/java/world/bentobox/aoneblock/listeners/FinaleListener.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "Math.clamp" instead of "Math.min" or "Math.max".

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLohB0MTHYKDZflEuS&open=AaHLohB0MTHYKDZflEuS&pullRequest=566

Check warning on line 273 in src/test/java/world/bentobox/aoneblock/listeners/BossBarListenerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "times".

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLzDExEcYKQstBkM-S&open=AaHLzDExEcYKQstBkM-S&pullRequest=566

Check warning on line 1578 in src/test/java/world/bentobox/aoneblock/oneblocks/OneBlocksManagerTest3.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body.

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLohBuMTHYKDZflEuP&open=AaHLohBuMTHYKDZflEuP&pullRequest=566

Check warning on line 265 in src/test/java/world/bentobox/aoneblock/listeners/BossBarListenerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "times".

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLzDExEcYKQstBkM-R&open=AaHLzDExEcYKQstBkM-R&pullRequest=566

Check warning on line 355 in src/test/java/world/bentobox/aoneblock/listeners/FinaleListenerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this mock creation to a local variable.

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLog7ZMTHYKDZflEuN&open=AaHLog7ZMTHYKDZflEuN&pullRequest=566

Check warning on line 130 in src/test/java/world/bentobox/aoneblock/commands/island/IslandSetCountCommandTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this mock creation to a local variable.

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLog-tMTHYKDZflEuO&open=AaHLog-tMTHYKDZflEuO&pullRequest=566

Check warning on line 239 in src/main/java/world/bentobox/aoneblock/listeners/FinaleListener.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this expression which always evaluates to "true"

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLohB0MTHYKDZflEuQ&open=AaHLohB0MTHYKDZflEuQ&pullRequest=566

Check failure on line 1144 in src/main/java/world/bentobox/aoneblock/oneblocks/OneBlocksManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_AOneBlock&issues=AaHLohExMTHYKDZflEuW&open=AaHLohExMTHYKDZflEuW&pullRequest=566