Repository navigation
Fix WebAssembly browser regressions - #312
Merged
Merged
Conversation
Alexander-Mitrofanov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Recent GUI changes exposed two stale assumptions in the real-browser tests. The prediction CSV assertion still expected the header from before seedEnd1 and seedEnd2 became defaults. The numerical regression setup also loaded maintainer-editable GUI examples before replacing their values, coupling the hosted suite to growing example content and causing the browser job to stall.
The tests now start directly from explicit, small regression inputs. GUI example files continue to be discovered and loaded by the application, while numerical checks remain deterministic.
Validation