Repository navigation
Preserve computed GUI runs as selectable sessions (#297) - #299
Merged
Merged
Conversation
Member
|
@Alexander-Mitrofanov (gui) header
(gui) "Sequence input"
(gui) "Query"/"Target"
(gui) "Helix (model B)"
(gui) "Interaction and energy"
(gui) "SHAPE"
(gui) "General"
(gui) "Seed"
(gui) "Output"
(gui) input section reorder:
(gui) result table
(gui) session view
|
Revise GUI inputs and result controls from #299 review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing parameters used to discard the previous output. Computed runs now remain as separate sessions in browser memory, so users can switch between settings and compare results.
Addresses the new review comment on #297. This follow-up targets
feat/287-json-gui-review, as requested, and depends on #297.Sessions last for the current page lifetime; reload/close clears them. ZIP exports retain results outside the page. No persistent browser storage or new dependency is introduced. Memory use grows with retained runs, and deleting sessions releases their outputs.
Validation
npm test --prefix gui: 18 tests passed.scripts/wasm/test-browser.pyin Chromium and Firefox, with real WASM at nested URLs: passed. Covers session creation/restoration, task changes, signed indices, SHAPE, CSV order, reports, independent tables, folded-session export, safe renaming, deletion, stale uploads, reset/import/failure/abort preservation and reload. Desktop screenshots inspected; 390 px viewport has no document overflow.node scripts/wasm/smoke-protocol.mjs <staged-engine>: native-reference checks and byte-identical JSON archive replay passed. Browser validation reused the parent branch’s compiled Emscripten 4.0.23 / ViennaRNA 2.7.2 assets with their original provenance; no C++ or worker protocol changes.make tests -j2, all 9 native API/CLI groups passed. Existing out-of-tree CLI fixtures were linked into the build’stests/datadirectory.bash scripts/wasm/stage.shwith the existing engine/dependency assets,bash -n scripts/wasm/stage.sh, andgit diff --check: passed.