Skip to content

Upgrade packages - #3867

Closed
RubenCerna2079 wants to merge 5 commits into
mainfrom
dev/rubencerna/upgrade-packages
Closed

RubenCerna2079 wants to merge 5 commits into
mainfrom
dev/rubencerna/upgrade-packages

Conversation

@RubenCerna2079

@RubenCerna2079 RubenCerna2079 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Why make this change?

What is this change?

It upgrades the package version of:

  • MessagePack
  • Microsoft.OpenApi
  • Microsoft.OpenApi.Readers

Added package below as it is transitively used by other packages and set a specific version that did not contain any vulnerabilities:

  • System.Security.Cryptography.Pkcs

How was this tested?

Only needs the pipeline to pass

Sample Request(s)

N/A

@github-project-automation github-project-automation Bot moved this from Todo to Done in Data API builder Oct 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Dependency compatibility and vulnerability remediation still require CI validation.

No open issues 🎉

What changed in this PR

Updates DAB dependencies to address vulnerability-related build failures tracked in #3866.

Changes:

  • Upgrades MessagePack to 2.5.307 and both OpenAPI packages to 1.6.31.
  • Pins System.Security.Cryptography.Pkcs to 9.0.21 and adds explicit references in six projects.
File Description
src/​Directory.Packages.props Updates central package versions and adds the Pkcs pin.
src/​Config/​Azure.DataApiBuilder.Config.csproj Adds the Pkcs reference to configuration.
src/​Cli/​Cli.csproj Adds the Pkcs reference to the CLI.
src/​Cli.Tests/​Cli.Tests.csproj Adds the Pkcs reference to CLI tests.
src/​Azure.DataApiBuilder.Mcp/​Azure.DataApiBuilder.Mcp.csproj Adds the Pkcs reference to MCP.
src/​Auth/​Azure.DataApiBuilder.Auth.csproj Adds the Pkcs reference to authentication.
src/​Aspire.AppHost/​Aspire.AppHost.csproj Adds the Pkcs reference to the Aspire host.

Review effort: Balanced

RubenCerna2079 pushed a commit that referenced this pull request Oct 20, 2026
## Why make this change?

- Closes #3871
- New NuGet advisories for System.Security.Cryptography.Pkcs,
MessagePack and Microsoft.OpenApi.Readers make the implicit restore in
the Unit Tests pipeline's "Check formatting" step fail with 22 audit
errors, blocking every PR to `main`.
  - Related: draft #3867 (overlapping version bumps).

## What is this change?

- `Directory.Packages.props`: pin `System.Security.Cryptography.Pkcs`
9.0.21, bump `MessagePack` 2.5.301 -> 2.5.307, and bump
`Microsoft.OpenApi` and `Microsoft.OpenApi.Readers` 1.6.14 -> 1.6.31
together.
- Pkcs is only a transitive dependency, and central package management
does not pin transitive versions without a reference. It is referenced
from `Config` and `Core`, where `Microsoft.Data.SqlClient` enters the
graph (`Core` also so the packed library declares it), and from
`Aspire.AppHost`, whose restore graph does not include its project
references.
- No audit warnings are suppressed.

## How was this tested?

- [ ] Integration Tests
- [x] Unit Tests

Locally with the CI SDK (10.0.402) and real NuGet vulnerability data:
replaying CI's restore and `dotnet format --verify-no-changes`
reproduces the 22 errors on `main` and passes on this branch (0 audit
errors, 0 of 791 files changed). Full solution Release and Debug builds,
including Aspire.AppHost, have 0 warnings; the Release pack succeeds;
the CI unit test filter passes (Service.Tests 3254/3254, Cli.Tests 629
passed, 3 ignored in source).

## Sample Request(s)

- N/A (package versions only).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Upgrade Packages With Vulnerabilities

4 participants