Repository navigation
Refresh third-party notices and honor npm registry configuration - #2902
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Registry metadata requests ignore .npmrc credentials, and swallowed authentication failures can cause the script to overwrite NOTICE.txt with a minimal file while reporting success.
1 open issue
What changed in this PR
Refreshes Azurite’s third-party notices for v3.38.0 and updates notice-generation tooling without changing runtime behavior or dependency versions.
Changes:
- Reads the registry from npm configuration, including
npm_config_registryoverrides. - Resolves aliases using lockfile package names, preserving separate TypeScript versions.
- Refreshes upstream notices and adds Apache Arrow and the aliased TypeScript build dependency.
| File | Description |
|---|---|
scripts/fix_notice_file.js |
Uses npm registry configuration and resolves canonical package names from the lockfile. |
NOTICE.txt |
Refreshes upstream notice content and adds missing dependency entries. |
Review effort: Balanced
Comment on lines
+40
to
+43
| const NPM_REGISTRY = execSync("npm config get registry", { | ||
| encoding: "utf8", | ||
| stdio: ["ignore", "pipe", "pipe"] | ||
| }).trim().replace(/\/+$/, ""); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Refresh third-party notices for the v3.38.0 release and make NOTICE generation work with contributors' npm registry configuration.
npm config get registryinstead of hardcoding registry.npmjs.org; support the standardnpm_config_registryoverride without requiring a Microsoft-specific endpoint.typescript-for-build→typescript.NOTICE.txtwith 27 upstream notices, updating stale dependency versions and including Apache Arrow and the aliased TypeScript build dependency.Validation
npm pack --dry-run --ignore-scripts --jsonconfirms the regenerated NOTICE is included with the expected byte size.Notes