Skip to content

Refresh third-party notices and honor npm registry configuration - #2902

Merged
Akanksha Jain (jainakanksha-msft) merged 1 commit into
mainfrom
akkuReleaseUpdates
Nov 10, 2026
Merged

Akanksha Jain (jainakanksha-msft) merged 1 commit into
mainfrom
akkuReleaseUpdates

Conversation

@jainakanksha-msft

Copy link
Copy Markdown
Member

Summary

Refresh third-party notices for the v3.38.0 release and make NOTICE generation work with contributors' npm registry configuration.

  • Read the registry from npm config get registry instead of hardcoding registry.npmjs.org; support the standard npm_config_registry override without requiring a Microsoft-specific endpoint.
  • Resolve npm aliases using the package name in the lockfile, including typescript-for-build → typescript.
  • Regenerate NOTICE.txt with 27 upstream notices, updating stale dependency versions and including Apache Arrow and the aliased TypeScript build dependency.

Validation

  • JavaScript syntax check passed.
  • Verified registry resolution with both the public npm registry and the Microsoft npm package feed proxy.
  • Verified alias resolution preserves both TypeScript versions.
  • NOTICE generation via the configured proxy completed with zero dependency lookup failures; all 27 notice entries match the release lockfile.
  • npm pack --dry-run --ignore-scripts --json confirms the regenerated NOTICE is included with the expected byte size.

Notes

  • Upstream notice content is preserved, including trailing whitespace.
  • No runtime behavior or dependency versions change; no changelog entry is added for this compliance/tooling update.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Registry metadata requests ignore .npmrc credentials, and swallowed authentication failures can cause the script to overwrite NOTICE.txt with a minimal file while reporting success.

1 open issue
What changed in this PR

Refreshes Azurite’s third-party notices for v3.38.0 and updates notice-generation tooling without changing runtime behavior or dependency versions.

Changes:

  • Reads the registry from npm configuration, including npm_config_registry overrides.
  • Resolves aliases using lockfile package names, preserving separate TypeScript versions.
  • Refreshes upstream notices and adds Apache Arrow and the aliased TypeScript build dependency.
File Description
scripts/​fix_notice_file.js Uses npm registry configuration and resolves canonical package names from the lockfile.
NOTICE.txt Refreshes upstream notice content and adds missing dependency entries.

Review effort: Balanced

Comment on lines +40 to +43
const NPM_REGISTRY = execSync("npm config get registry", {
encoding: "utf8",
stdio: ["ignore", "pipe", "pipe"]
}).trim().replace(/\/+$/, "");
@jainakanksha-msft
Akanksha Jain (jainakanksha-msft) merged commit f049fde into main Nov 10, 2026
46 checks passed
@jainakanksha-msft
Akanksha Jain (jainakanksha-msft) deleted the akkuReleaseUpdates branch November 10, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants