Repository navigation
build: upgrade pprof to 5.15.1 for custom Node 22 - #32
Draft
vuttikais-asana wants to merge 2 commits into
Draft
vuttikais-asana wants to merge 2 commits into
vuttikais-asana wants to merge 2 commits into
Conversation
vuttikais-asana
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build pprof 5.15.1 against the existing pointer-compressed Node 22 binary and headers, and stage it in its versioned package-store directory for the dd-trace 5.116.0 upgrade. The new archive contains only pprof 5.15.1; existing immutable archives retain 5.8.0 for current deployments and rollback. Codez must update dd-trace and the archive references together.
Handle the changed prebuilt filename in pprof 5.15.1 and smoke-test loading and encoding a wall-time profile for the rebuilt package. Disable npm lifecycle scripts during source dependency installation so the explicit node-gyp invocation uses our custom headers. Pin node-gyp to 11.5.0 and limit compilation to two jobs.
Validation: a sandbox Docker trial uses the exact SHA256-verified Node 22.21.1 archive referenced by codez. The 5.15.1 build loads with pointer compression enabled and captures/encodes nonempty wall-time and heap profiles. The simplified single-version recipe also passed its native wall-time smoke test. The trial adapts extraction to codez's repackaged archive and skips unrelated bcrypt/cld/unix-dgram builds.
Arm64, FIPS, full application profiling, and the publishing workflow still require validation. This fork-only Dockerfile change does not modify Node source; the Node test suite and codez git lint were not run for this separate repository.