Repository navigation
Vector rows: read the record from the row when the engine flattens it (ArcadeDB #10898) - #129
Merged
Merged
Conversation
…tens it (ArcadeDB #10898) ArcadeDB 26.11.1 (#10900) lists a vector row's record properties once, on the row, and no longer enumerates "record". Native _run_search falls back to the row (minus distance) when "record" is absent, so find_nearest keeps returning records; the approximate-persistence test accepts both engine shapes and now also checks @Rid and the embedding. Closes #128 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #128
ArcadeData/arcadedb#10900 (fixing #10898, in 26.11.1) makes a vector row list its record's properties once, on the row itself, and stop enumerating
record. Our row dicts therefore have norecordkey.src/arcadedb/_native/schema_objects.py_run_searchuses the nestedrecordwhen present, else the row itself withoutdistance, so nativefind_nearestkeeps returning records on both engine generationstests/test_vector.pytest_lsm_vector_search_approximate_persistenceaccepts either shape and now asserts@ridand the embedding of the record, not only that a key existsThe JVM
find_nearestpath calls the Java index API and is unaffected.examples/12_vector_search.pyalready reads the id from the row before tryingrecord. This unblocks #123, #125 and #127, whose test legs all fail on this one test.Checks run: compile and pre-commit (black, isort). The fix is proven by this PR's CI on the current snapshot.
🤖 Generated with Claude Code