Skip to content

chatgpt reviewer test cases + hooks: no child_process, single opt-out - #56

Merged
teallarson merged 3 commits into
mainfrom
cursor/openai-reviewer-cases-ca2d
Oct 26, 2026
Merged

teallarson merged 3 commits into
mainfrom
cursor/openai-reviewer-cases-ca2d

Conversation

@teallarson

@teallarson teallarson commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

OpenAI ChatGPT review cases no longer use seeded Gmail, calendar, GitHub, or Slack data. Positive cases are Arcade_ListApps plus Math toolkit calls (average, power, square root, degrees to radians), and there are three negative cases. Every prompt starts with "Use Arcade to". Reviewers self-sign-up for a free Arcade account.

Hooks

plugin/hooks/telemetry-run.mjs no longer imports child_process or spawns a sender. The only opt-out is ARCADE_PLUGIN_TELEMETRY. readOptOutEnv() reads that name plus CLAUDE_PLUGIN_DATA and COPILOT_PLUGIN_DATA, and only after the TELEMETRY_ENABLED check.

npm run generate and npm run verify passed in dev/ (typecheck; 207 tests passed, 2 skipped; Claude, Cursor, Codex, and Copilot validators).

Open in Web Open in Cursor 

Note

Medium Risk
Changes OpenAI review expectations and future telemetry opt-out semantics; hook scripts are more constrained, which affects how telemetry can be re-enabled without policy test updates.

Reviewed by Cursor Bugbot for commit 3d738c4. Bugbot is set up for automated code reviews on this repo. Configure here.

cursoragent and others added 2 commits October 23, 2026 20:00
Replace seeded Gmail, calendar, GitHub, and Slack cases with
Arcade_ListApps and Math toolkit cases. Every prompt starts with
"Use Arcade to". Reviewers sign up for a free account; no seeded data.

Co-authored-by: Teal Larson <LARSON.TEAL@GMAIL.COM>
Stop spawning a telemetry sender. readOptOutEnv reads only
ARCADE_PLUGIN_TELEMETRY, CLAUDE_PLUGIN_DATA, and COPILOT_PLUGIN_DATA,
and only after the TELEMETRY_ENABLED check.

Co-authored-by: Teal Larson <LARSON.TEAL@GMAIL.COM>
@cursor cursor Bot changed the title chatgpt: reviewer test cases for self-signup review chatgpt reviewer test cases + hooks: no child_process, single opt-out Oct 23, 2026
@teallarson
teallarson marked this pull request as ready for review October 26, 2026 21:22
Replace the palette logo with fully opaque RGBA listing images and
emit logo, logoDark, composerIcon, composerIconDark, and brandColor
from the manifest generator. Point reviewer cases at trip planning,
flights plus Math, Google Finance, YouTube, and a Math average, and
keep the three negative prompts from calling Arcade.

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@teallarson
teallarson enabled auto-merge (squash) October 26, 2026 21:23

@arcade-plugin-bot arcade-plugin-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot reviewed 3d738c4 with no findings, and check passed. Approved automatically because teallarson has write access.

@teallarson
teallarson merged commit 587152b into main Oct 26, 2026
7 checks passed
@teallarson
teallarson deleted the cursor/openai-reviewer-cases-ca2d branch October 26, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants