Repository navigation
chatgpt reviewer test cases + hooks: no child_process, single opt-out - #56
Merged
Merged
Conversation
Replace seeded Gmail, calendar, GitHub, and Slack cases with Arcade_ListApps and Math toolkit cases. Every prompt starts with "Use Arcade to". Reviewers sign up for a free account; no seeded data. Co-authored-by: Teal Larson <LARSON.TEAL@GMAIL.COM>
Stop spawning a telemetry sender. readOptOutEnv reads only ARCADE_PLUGIN_TELEMETRY, CLAUDE_PLUGIN_DATA, and COPILOT_PLUGIN_DATA, and only after the TELEMETRY_ENABLED check. Co-authored-by: Teal Larson <LARSON.TEAL@GMAIL.COM>
teallarson
marked this pull request as ready for review
October 26, 2026 21:22
Replace the palette logo with fully opaque RGBA listing images and emit logo, logoDark, composerIcon, composerIconDark, and brandColor from the manifest generator. Point reviewer cases at trip planning, flights plus Math, Google Finance, YouTube, and a Math average, and keep the three negative prompts from calling Arcade. Co-authored-by: Cursor Agent <cursoragent@cursor.com>
teallarson
enabled auto-merge (squash)
October 26, 2026 21:23
Contributor
There was a problem hiding this comment.
Cursor Bugbot reviewed 3d738c4 with no findings, and check passed. Approved automatically because teallarson has write access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI ChatGPT review cases no longer use seeded Gmail, calendar, GitHub, or Slack data. Positive cases are Arcade_ListApps plus Math toolkit calls (average, power, square root, degrees to radians), and there are three negative cases. Every prompt starts with "Use Arcade to". Reviewers self-sign-up for a free Arcade account.
Hooks
plugin/hooks/telemetry-run.mjsno longer importschild_processor spawns a sender. The only opt-out isARCADE_PLUGIN_TELEMETRY.readOptOutEnv()reads that name plusCLAUDE_PLUGIN_DATAandCOPILOT_PLUGIN_DATA, and only after theTELEMETRY_ENABLEDcheck.npm run generateandnpm run verifypassed indev/(typecheck; 207 tests passed, 2 skipped; Claude, Cursor, Codex, and Copilot validators).Note
Medium Risk
Changes OpenAI review expectations and future telemetry opt-out semantics; hook scripts are more constrained, which affects how telemetry can be re-enabled without policy test updates.
Reviewed by Cursor Bugbot for commit 3d738c4. Bugbot is set up for automated code reviews on this repo. Configure here.