Repository navigation
refactor(member): drop the no-unknown-parameters directive on ClassifyMember - #96
Merged
Merged
Conversation
…yMember Adopt @antelopejs/tooling-configs 0.7.0, whose no-unknown-parameters accepts a parser that reads its unknown parameter only through type guards, and lower the rule's ceiling to 0. Cap @antelopejs/interface-core and @antelopejs/core below their next minor, as the dependency:ranges step of 0.7.0 requires, and replace the removed antelopejs-check-interface-ranges bin in the lint script.
Upd4ting
force-pushed
the
refactor/classify-member-type-guard-parser
branch
from
November 14, 2026 03:24
27a9d9c to
7ebc1b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Antony wants every suppression
guardrails.suppressions.jsonallows in this repo brought to zero by fixing what it hides, so the lint holds without escape hatches (ANT-1090). The last one was theanti-slop/no-unknown-parametersdirective onClassifyMember, a hand-written parser that takes any caller value and returns aMember. tooling-configs 0.6.0 (#328, ANT-2363) changed the rule to accept a function that reads itsunknownparameter only through type guards and returns a declared type. This PR adopts tooling-configs 0.7.0, drops the directive, and lowers the rule's ceiling to 0. Every count in the budget file is now 0.What
@antelopejs/tooling-configsgoes from^0.5.8to>=0.7.0 <0.8.0.src/implementations/database/member.tsloses itsoxlint-disable-next-line anti-slop/no-unknown-parametersline.ClassifyMemberis unchanged.guardrails.suppressions.jsonlowersanti-slop/no-unknown-parametersfrom 1 to 0, viapnpm run suppressions:update.dependency:rangesstep (0.6.0 #336) refuses an AntelopeJS range open past the next minor.@antelopejs/interface-coregoes from>=0.1.1 <1.0.0to>=0.5.0 <0.6.0(newest is 0.5.1), and@antelopejs/corefrom^1.21.0to~1.23.1.antelopejs-syncregenerated the README compatibility table to match.readme:versionstep (0.6.0 #343) refuses a README config example whose range does not admitpackage.json's version. The example's^0.2.0becomes>=0.4.0 <0.5.0.antelopejs-check-interface-rangesbin, becauseantelopejs-checksrunsdependency:rangesitself. Thelintscript is now plainoxlint, and AGENTS.md names the step that enforces the caps.published:typesstep (0.7.0 #355) typechecks the published declarations as a consumer installs them. It passes with no change.antelopejs-syncregenerated the managed table in AGENTS.md (it addsantelopejs/no-unrun-query).SAFETY comments added
None.
Proof
ClassifyMemberwith the directive removed, linted by each preset:pnpm run checkswith 0.7.0, before the range fixes:After:
API: 1 packages, 1 entries unchanged against origin/main (committed HEAD).
API: skipped .agents/skills/verify-module, not a workspace package.
Runtime API: 1 packages, 1 entries unchanged against origin/main (committed HEAD).
No behavioural probe ran.
Suppressions in authored code files (origin/main and committed HEAD). A lint directive counts once per rule it names;
*is a directive naming none.anti-slop/no-unknown-parameters@ts-expect-error@ts-ignoreSAFETY:comments