Repository navigation
ci: run the checks on Windows beside Linux - #94
Merged
Merged
Conversation
Bump @antelopejs/tooling-configs to 0.5.8, which ships Windows support for the pack's checks, and sync its managed files.
With core.autocrlf=true, the default of Git for Windows, .agents/setup was checked out with CRLF and bash refused it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The goal is to know the whole AntelopeJS stack works on Windows. This PR runs interface-database's CI on Windows beside Linux and fixes the one Windows break it has. Part of ANT-2205 (parent ANT-1664).
What
ci.ymlpasseswindows: truetoci-node.yml@v1, so the node and test jobs also run onwindows-latest, in parallel with Linux. The repo had no hand-written Windows job to replace.@antelopejs/tooling-configsgoes from 0.5.5 to 0.5.8, the release with Windows support for the pack's checks.antelopejs-syncupdated its two managed files (README.md,.agents/skills/verify-interface/SKILL.md)..gitattributessets* text=auto eol=lf. Withcore.autocrlf=true, the Git for Windows default,.agents/setupwas checked out with CRLF and bash refused it. Renormalizing changed no tracked file.The tests need no service setup on Windows.
ajs module teststarts an in-memory MongoDB replica set itself.No Windows-only skip was added. No lint rule or guardrails ceiling changed.
Proof
Windows CI before and after
Before, the first run with
windows: trueat 916f753: https://github.com/AntelopeJS/interface-database/actions/runs/43430888432227 passing (5s)Checks: 9 passed, 0 failed, 2 skipped.After, at 502344c: https://github.com/AntelopeJS/interface-database/actions/runs/43431385807
227 passing (6s)Checks: 9 passed, 0 failed, 2 skipped.Linux runs the same 227 tests. The 2 skipped checks on Windows are
test, which runs in its own job, andsync:check, whichci-node.ymlskips on Windows.The first Windows run was already green, because
ci-node.ymlchecks out withcore.autocrlf false. That hides the CRLF break. The break shows up for a developer on a default Git for Windows install.CRLF checkout of
.agents/setupThe repro clones with
core.autocrlf=trueand runsbash -n .agents/setup.Before, on
origin/main:After, on this branch:
pnpm run checkspasses locally:Checks: 11 passed, 0 failed.