Repository navigation
build(deps)!: cap @antelopejs ranges below the next minor on tooling-configs 0.6.0 - #136
Merged
Merged
Conversation
…configs 0.6.0 Move to @antelopejs/tooling-configs >=0.6.0 <0.7.0, whose dependency:ranges check fails a range open past the next minor. Each interface peer now names one minor, the one the tests run against, and the interface-api dev dependency moves from 0.2.0 to the 0.3 line the peer already required.
…published minor core 1.22 and 1.23 depend on interface-core >=0.5.1 <0.6.0, so the peer floor moves to 0.5.1 and the core dev dependency to ~1.23.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An
@antelopejs/*package ships breaking changes in minor releases. A range open to<1.0.0lets an install resolve one this package was never built against. tooling-configs 0.6.0 adds thedependency:rangescheck, which fails such a range. This PR moves to 0.6.0 and caps every@antelopejs/*range. The 0.8.0 release waits for it.What changes
@antelopejs/tooling-configsgoes to>=0.6.0 <0.7.0. No script here calledantelopejs-check-interface-ranges;pnpm run checksnow runsdependency:ranges.antelopejs-syncregenerated the README compatibility table and the AGENTS.md rule table (newantelopejs/no-unrun-queryrow)."query"locale parameter asstring | true | undefined. interface-api 0.3 types a query parameter that way (?localealone givestrue) and refuses a plainstringproperty.Ranges
@antelopejs/api^1.7.0~1.7.0@antelopejs/core~1.22.0~1.23.0@antelopejs/interface-api>=0.2.0 <1.0.0>=0.3.0 <0.4.0@antelopejs/interface-api-util^0.3.0^0.3.0(unchanged)@antelopejs/interface-core^0.5.1^0.5.1(unchanged)@antelopejs/interface-database^0.4.0^0.4.0(unchanged)@antelopejs/interface-database-decorators^0.5.2^0.5.2(unchanged)@antelopejs/tooling-configs^0.5.8>=0.6.0 <0.7.0@antelopejs/interface-api>=0.3.0 <1.0.0>=0.3.0 <0.4.0@antelopejs/interface-api-util>=0.1.3 <1.0.0>=0.3.0 <0.4.0@antelopejs/interface-core>=0.2.4 <1.0.0>=0.5.1 <0.6.0@antelopejs/interface-database>=0.1.10 <1.0.0>=0.4.0 <0.5.0@antelopejs/interface-database-decorators>=0.5.0 <1.0.0>=0.5.0 <0.6.0Floors that rose
interface-apidev,0.2.0to0.3.0. The lockfile resolved 0.2.0 while the peer floor was already 0.3.0, and interface-api-util 0.3 itself peers on interface-api 0.3. Tests now run against 0.3.2, which is what needed the three test type fixes.interface-api-utilpeer,0.1.3to0.3.0. A capped range names one minor, so the floor moves to the newest published minor.interface-corepeer,0.2.4to0.5.1;@antelopejs/coredev,~1.22.0to~1.23.0. core 1.22 and 1.23, the newest published, depend on interface-core>=0.5.1 <0.6.0, so a lower floor would admit an interface-core the current core refuses.interface-databasepeer,0.1.10to0.4.0. fix(routes): run every database query with .run() for interface-database 0.4 #133 already runs every query with.run(), which needs 0.4.Every range now starts in the newest minor published on npm today. The already capped
^0.xdev ranges were there already and stay.Proof
dependency:rangeswith tooling-configs 0.6.0, run alone (ANTELOPEJS_CHECKS_SKIPset to every other step), onorigin/main's manifest:On this branch:
pnpm run typecheckonce interface-api resolves 0.3.2, before the test fix:After: no output.
pnpm run checkswith the test step skipped printsChecks: 11 passed, 0 failed, 1 skipped.; the three touched test files pass (17 tests) on core 1.23.0; CI runs the full suite.