Repository navigation
refactor(metadata)!: remove the RowFields alias of StoredRow - #135
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
interface-data-api#131 kept
RowFieldsas a deprecated alias ofStoredRowso that interface-dms 0.13 would still type-check. Nobody uses the product yet, so no compatibility code is kept. This PR removes the alias and leavesStoredRowas the only name for a row's fields. It ships in 0.8.0 as a breaking change.What
src/internal/field-types.tsno longer declaresRowFields.src/metadata.tsno longer re-exports it.src/tests/index/consumer_declarations.test.tsdrops theRowFieldsimport and assignment. Its route check now asserts thatDefaultRoutes.Getanswers aStoredRow.No other
@deprecatedexport is left in the repository.Attention
RowFieldsfrom@antelopejs/interface-data-api/metadatainpackages/dms/src. Its peer range>=0.6.0 <1.0.0accepts 0.8.0. So dms has to move toStoredRow(ANT-2384) before it installs data-api 0.8.0.CHANGELOG.mdstill namesRowFields, because it records what 0.7.0 shipped. This PR doesn't rewrite released history.Proof
Main's consumer test fails on this head. That test still imports
RowFields. Run against this head's build:This head's consumer test passes:
pnpm run checksoutput:Checks: 11 passed, 0 failed.The API diff below shows a single removal,
RowFields, frommetadataand its@internalsource module. Runtime exports are unchanged.