Repository navigation
ci: run the checks on Windows beside Linux - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Run interface-auth's CI on Windows in parallel with Linux, so the AntelopeJS stack is known to work on Windows (ANT-2202).
What
ci.ymlcallsci-node.yml@v1withwindows: true. The node and test jobs now also run onwindows-latest, in parallel withubuntu-latest. This repo had no hand-written Windows job to replace.@antelopejs/tooling-configsgoes from 0.5.5 to 0.5.8, the latest release, which ships Windows support for the pack's checks.antelopejs-syncrefreshed the two managed files it owns,README.md(the pack's module table) and.agents/skills/verify-interface/SKILL.md.No Windows failure showed up, so this PR has no fix and no Windows-only skip. On Windows the shared workflow itself skips
sync:checkand the in-checksteststep. The separateTest .nvmrc on Windowsjob runs the suites.Proof
Before: the first run with
windows: true, on 5d9fa35 with tooling-configs 0.5.5. Run https://github.com/AntelopeJS/interface-auth/actions/runs/43415748341 succeeded.After: f0a9154, with tooling-configs 0.5.8. Run https://github.com/AntelopeJS/interface-auth/actions/runs/43416058788 succeeded.
Local
pnpm run checkson Linux:Checks: 11 passed, 0 failed.