Repository navigation
ci: run the check jobs on Windows beside Linux - #111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Run this repo's CI on Windows in parallel with Linux, so the AntelopeJS stack is known to work on Windows (ANT-2200, parent ANT-1664).
What
.github/workflows/ci.ymlpasseswindows: truetoAntelopeJS/.githubci-node.yml@v1. The check and test jobs now run onwindows-latestbeside the Linux ones. There was no hand-written Windows job to replace.@antelopejs/tooling-configsgoes from^0.5.5to^0.5.8, the release with Windows support for the pack's checks.antelopejs-syncrewrote two pack-managed files on that bump: the stack table inREADME.md(addsmysql) and.agents/skills/verify-interface/SKILL.md(documentsservices[].args).Proof
The first run with
windows: truepassed on Windows with no change to source or tests, so the before and after runs are the same run: run 43417326189 on c5f86e4.Checks: 9 passed, 0 failed, 2 skipped.118 passing (844ms)Checks: 10 passed, 0 failed, 1 skipped.118 passing (529ms)There were no Windows failures to fix, so this PR adds no test.
Attention
This PR adds no Windows-only skip. The Windows check job skips
testandsync:checkbecause the shared workflow sets them, not this repo (ci-node.yml@v1,ANTELOPEJS_CHECKS_SKIP: ${{ runner.os == 'Windows' && (inputs.test-job && 'test,sync:check' || 'sync:check') || ... }}).testruns in its own Windows job.sync:checkcompares managed file contents and ran in the Linux check job of the same run.