Repository navigation
Conversation
… dms-database does
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ANT-2045's PR B moves the database connections of a disabled
dms-builderordms-assistantentry onto the DMS's entry in a one-time migration, so upgrading needs no manual step. core'sListModuleDeclarationsdropsimportOverrides, and it cannot see a module that is disabled or not loaded. The migration needs to read those bindings asantelope.config.tswrites them.Task: ANT-2412, stacked on #891.
⚠ sensitive: reads the external connections'
access(permissions), read-only.Summary
One owner-path, read-only operation on
@antelopejs/interface-dms-builder. No MCP tool exposes it.It is in
Operations(interface and implementation), so the fast-reject map of #896 covers it after its rebase. The connect docs page gains its row.Evidence
entry-connections.test.ts:With the
importOverridesrefusal removed, a variable silently reads as no binding:An adversarial review found bindings dropped or downgraded (an
idwritten as a variable read as a plain pin, a shorthandimportOverridesread as nothing),accessread elsewhere than dms-database reads it, and valid version-string entries refused. Their cases, against the reviewed code:A second review found that a computed key written after the entry, which overrides it at runtime, was ignored. The reader now refuses when a member of
modulesthat it cannot name comes after the entry, and still reads an entry written after such a member. The case against the previous reader:After both fixes,
entry-connectionshas 8 cases, all passing. A binding added only underenvironments.<env>.modulesis not read: the operation answers the entry as written.operation-mapandimplement-interfacepass with the new operation.backend-checks,oxlintand typecheck pass.Merge Danger
Door: two-way. A new read-only operation; nothing else changes.
Blast Radius: builder.
It lands with #891's interface-dms-builder 0.5.0 release.