Repository navigation
ci: run the CI on Windows beside Linux - #136
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Run dms-api's CI on Windows in parallel with Linux, so Windows-only breakage shows up before a release (ANT-2187).
What
ci.ymlpasseswindows: truetoci-node.yml@v1. The node and test jobs now also run onwindows-latest. There was no hand-written Windows job to replace..gitattributessets* text=auto eol=lf, so a checkout withcore.autocrlf=truekeeps LF line endings.@antelopejs/tooling-configsgoes from^0.5.1to^0.5.8, which ships Windows support for the pack's checks.antelopejs-syncaddedallowBuilds: lefthook: falsetopnpm-workspace.yaml.frontend-vue/tests/backend-boundary.test.tsexpects the paths in the form Vite reports on Windows. Vite names the importer with/separators. The scratch root is now resolved withrealpathSync.native, which expands the 8.3 short name (RUNNER~1) thatrealpathSynckeeps, so it matches the long path the resolver returns. On Linux both changes give the same strings as before. The plugin is unchanged.No Windows-only skip, no lint rule change, no guardrails ceiling change.
Proof
Before, first run with
windows: true(e167530): https://github.com/AntelopeJS/dms-api/actions/runs/43442373110.ci / Test .nvmrc on Windowsfailed:After (78700e4): https://github.com/AntelopeJS/dms-api/actions/runs/43442902085. Every job passed, including
ci / Node .nvmrc on Windowsandci / Test .nvmrc on Windows:Local, Linux:
pnpm run checksprintsChecks: 12 passed, 0 failed.