Repository navigation
[OGUI-1929] Replace auto scroll checkbox - #3674
Merged
isaachilly merged 8 commits intoOct 15, 2026
Merged
Conversation
isaachilly
added this pull request to stack #3676
October 9, 2026 15:34
isaachilly
marked this pull request as ready for review
October 13, 2026 13:23
isaachilly
force-pushed
the
improv/ILG/OGUI-1929/Replace-autoScroll-checkbox
branch
from
October 13, 2026 13:24
1106d9c to
e9f1154
Compare
graduta
previously approved these changes
Oct 14, 2026
isaachilly
dismissed
graduta’s stale review
October 15, 2026 07:34
The merge-base changed after approval.
Base automatically changed from
improv/ILG/OGUI-1928/Only-show-autoscroll-in-running-live-mode
to
dev
October 15, 2026 08:04
Replace the autoscroll checkbox with a clearer UI. Show a success label when enabled and a warning button when disabled, which when clicked re-enables it.
Delete the table's last scrolled log marker when autoscroll is off so re-enabling immediately jumps to the newest logs.
Update and add status bar tests to cover the new enabled/disabled states and re-enable behaviour.
Plain span is 1.5em. .btn-sm is 1.6em. Give both states the same div box sized to 1.5em.
Adds new setter for autoScrollLive. Shows a success/warning button in each state. Drops unneeded CSS. Rewrites test names and add one for disabling via the button.
isaachilly
force-pushed
the
improv/ILG/OGUI-1929/Replace-autoScroll-checkbox
branch
from
October 15, 2026 08:04
e9f1154 to
68afae8
Compare
graduta
approved these changes
Oct 15, 2026
isaachilly
deleted the
improv/ILG/OGUI-1929/Replace-autoScroll-checkbox
branch
October 15, 2026 09:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Ticket:
Replace auto-scroll checkbox with a more obvious way that reflected the fact the disabled is not the safe state.
Code:
Display a success-style button when enabled, clicking disables and shows warning button.
Display a warning-style button when disabled, clicking enables and shows again the success button.
When disabled and autoscrollManager runs, force it to delete the lastLogID it stored as otherwise when it becomes enabled again and no new logs have been received it won't scroll to the bottom as this is only done when the current log's ID and the last log's ID differ. When we re-enable auto-scroll we want it to jump to the bottom regardless if a new log has been received or not.
Add tests to check the correct text is shown and that the clicking to enable functionality works.
Reviewer: