Repository navigation
[OGUI-1928] Only show autoscroll in running live mode - #3673
Merged
isaachilly merged 6 commits intoOct 15, 2026
Merged
isaachilly merged 6 commits into
isaachilly merged 6 commits into
Conversation
isaachilly
changed the base branch from
dev
to
improv/ILG/OGUI-1926/Clean-up-logic-for-query-buttons
October 9, 2026 15:31
isaachilly
added this pull request to stack #3676
October 9, 2026 15:34
isaachilly
marked this pull request as ready for review
October 13, 2026 13:23
Button style, live icon, browser tab title and auto-scroll were set inside the click handler via module-level state, so any mode change not triggered by a click left the UI stale. Derive them from log.activeMode in the model/view instead.
Hides the autoscroll checkbox unless live mode is actively running.
isaachilly
force-pushed
the
improv/ILG/OGUI-1928/Only-show-autoscroll-in-running-live-mode
branch
from
October 13, 2026 13:24
8a6efcb to
28b21bc
Compare
graduta
previously approved these changes
Oct 14, 2026
Base automatically changed from
improv/ILG/OGUI-1926/Clean-up-logic-for-query-buttons
to
dev
October 15, 2026 07:33
isaachilly
dismissed
graduta’s stale review
October 15, 2026 07:34
The merge-base changed after approval.
…nly-show-autoscroll-in-running-live-mode
graduta
approved these changes
Oct 15, 2026
isaachilly
deleted the
improv/ILG/OGUI-1928/Only-show-autoscroll-in-running-live-mode
branch
October 15, 2026 08:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Ticket:
Hide the auto-scroll checkbox when not in live mode and actually streaming logs.
Code:
Moves the checkbox inside a check and adds tests to confirm it is displayed/hidden in the right modes.
Reviewer: