Skip to content

[PWGLF] Nuspex: hadron nuclei correlation: fix proton rejection - #18333

Merged
vkucera merged 2 commits into
AliceO2Group:masterfrom
ercolessi:master
Oct 16, 2026
Merged

vkucera merged 2 commits into
AliceO2Group:masterfrom
ercolessi:master

Conversation

@ercolessi

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwglf label Oct 16, 2026
@github-actions github-actions Bot changed the title [PWGLF] Nuspex: hadron nuclei correlation: fix proton rejection [PWGLF] Nuspex: hadron nuclei correlation: fix proton rejection Oct 16, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 5 warnings, 🔕 0 disabled

@ercolessi
ercolessi marked this pull request as ready for review October 16, 2026 15:25
@ercolessi
ercolessi enabled auto-merge (squash) October 16, 2026 15:25
@vkucera
vkucera disabled auto-merge October 16, 2026 16:24
@vkucera
vkucera enabled auto-merge (squash) October 16, 2026 16:24
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 43d863a at 2026-10-17 00:06:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 1 warnings.'
Found 2 errors and 1 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/a308f6d31a04de5c181bfed25ee79a1424c1e8e7/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:1973:40: error: std::move of the expression of the trivially-copyable type 'value_type' (aka 'GenCoalescenceCandidate') has no effect [performance-move-const-arg,-warnings-as-errors]
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:1978:38: error: std::move of the variable 'deuteron' of the trivially-copyable type 'GenCoalescenceCandidate' has no effect [performance-move-const-arg,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/a308f6d31a04de5c181bfed25ee79a1424c1e8e7/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Nuspex/hadronnucleicorrelation.cxx:1752:22: warning: use designated initializer list to initialize 'GenCandidate' [modernize-use-designated-initializers]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@vkucera
vkucera merged commit fd3668f into AliceO2Group:master Oct 16, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants