Skip to content

[PWGLF] nonPromptCascade: cascade dca - #18326

Merged
romainschotter merged 2 commits into
AliceO2Group:masterfrom
lietava:omegahm
Oct 16, 2026
Merged

romainschotter merged 2 commits into
AliceO2Group:masterfrom
lietava:omegahm

Conversation

@lietava

@lietava lietava commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator
  • cascade and v0 dca added
  • TF downscaling to use derived data

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 61 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5f844c1 at 2026-10-16 10:06:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 39 warnings.'
Found 1 errors and 39 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/74989e717ea412bb7e62d62db49831f73a0f68e2/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:293:45: error: no header providing "TH1" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 39 -gt 0 ]]
++ cat /sw/BUILD/74989e717ea412bb7e62d62db49831f73a0f68e2/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:174:22: warning: 'nParticles' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:175:22: warning: 'nCutsPID' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:176:39: warning: 'matterOrNot' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:177:39: warning: 'particlesNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:178:39: warning: 'cutsNames' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:179:18: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:179:24: warning: 'cutsPID' is a static definition in anonymous namespace; static is redundant here [readability-static-definition-in-anonymous-namespace]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:186:30: warning: variable 'gCandidates' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:187:30: warning: variable 'gCandidatesNT' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:191:8: warning: constructor does not initialize these fields: mCCDB, pdgDB [cppcoreguidelines-pro-type-member-init]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:231:69: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:269:9: warning: use auto when initializing with a template cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:320:21: warning: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:321:24: warning: narrowing conversion from 'float' to 'int' [bugprone-narrowing-conversions]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:511:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:546:7: warning: uninitialized record type: 'momenta' [cppcoreguidelines-pro-type-member-init]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:547:7: warning: uninitialized record type: 'cascadeMomentum' [cppcoreguidelines-pro-type-member-init]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:660:71: warning: redundant boolean literal in ternary expression result [readability-simplify-boolean-expr]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:672:19: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:894:11: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1044:13: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1070:11: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1070:49: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1114:13: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1123:13: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1134:13: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1142:13: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1161:11: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1172:11: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1187:12: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1201:11: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1211:11: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
PWGLF/Tasks/Strangeness/nonPromptCascade.cxx:1232:13: warning: implicit conversion 'value_type' (aka 'char') -> 'bool' [readability-implicit-bool-conversion]
[0 more errors; see full log]

Full log here.

@vkucera

vkucera commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Hi @lietava , can you please try to make the PR title a bit more informative so that it summarises what changed and where in LF? You can find some tips in the contribution guidelines. https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/contributingtocode.html#pull-requests

@lietava

lietava commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

HI @vkucera , of course, I can, thanks for the link. But it seems that somebody/something already modified the title ?

@romainschotter romainschotter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lietava ! Can you please add the header for TH1 in order to address the cpp code check error? You can do it at your next PR. In the meantime, I approve the PR.
Thank you very much!

@romainschotter
romainschotter merged commit b2a325a into AliceO2Group:master Oct 16, 2026
11 of 14 checks passed
@vkucera

vkucera commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

HI @vkucera , of course, I can, thanks for the link. But it seems that somebody/something already modified the title ?

@lietava Does not seem so. Only the tag prefix was added automatically.

@romainschotter Can you please pay attention to the titles of PRs before you merge them?

@lietava lietava changed the title [PWGLF] cascade dca [PWGLF] : nonPromptCascade: cascade dca Oct 16, 2026
@github-actions github-actions Bot changed the title [PWGLF] : nonPromptCascade: cascade dca [PWGLF] nonPromptCascade: cascade dca Oct 16, 2026
@lietava

lietava commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

@vkucera : ah ok, just name of the task was missing. I fixed it.
@romainschotter : thanks. I'll fix TH1.

@vkucera

vkucera commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

@vkucera : ah ok, just name of the task was missing. I fixed it. @romainschotter : thanks. I'll fix TH1.

Thanks @lietava . Also there is no verb that would indicate what you did with the dca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants