Skip to content

[ALICE3] MID FastSim - #18322

Closed
aortizve wants to merge 4 commits into
AliceO2Group:masterfrom
aortizve:master
Closed

aortizve wants to merge 4 commits into
AliceO2Group:masterfrom
aortizve:master

Conversation

@aortizve

Copy link
Copy Markdown
Collaborator

Fast simulations, MID

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 78 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title MID FastSim [ALICE3] MID FastSim Oct 16, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 258eb39 at 2026-10-16 04:45:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 7 errors and 32 warnings.'
Found 7 errors and 32 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/28985af832e4093b1fd3e3953290eb9abe2ae105/O2Physics-code-check/errors.txt
ALICE3/DataModel/OTFMID.h:24:1: error: included header Logger.h is not used directly [misc-include-cleaner,-warnings-as-errors]
ALICE3/DataModel/OTFMID.h:36:59: error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:246:22: error: local copy 'axisNSigma' of the variable 'axisNsigmaCorrect' is never modified and never used; consider removing the statement [performance-unnecessary-copy-initialization,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:571:16: error: no header providing "std::min" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:634:38: error: no header providing "o2::track::DirOutward" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:790:17: error: no header providing "std::max" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:815:61: error: no header providing "std::min" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 32 -gt 0 ]]
++ cat /sw/BUILD/28985af832e4093b1fd3e3953290eb9abe2ae105/O2Physics-code-check/warnings.txt
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:64:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:69:8: warning: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:160:27: warning: use starts_with instead of find [modernize-use-starts-ends-with]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:258:17: warning: member 'layerRadius' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:259:17: warning: member 'layerLength' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:260:17: warning: member 'cellDimensionZ' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:261:17: warning: member 'cellDimensionRPhi' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:262:17: warning: member 'fractionInactive' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:263:17: warning: member 'magField' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:277:11: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:297:7: warning: 'axisZ' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:302:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:306:37: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:307:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:311:34: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:361:7: warning: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:368:7: warning: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:388:13: warning: variable 'x' is not initialized [cppcoreguidelines-init-variables]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:388:16: warning: variable 'y' is not initialized [cppcoreguidelines-init-variables]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:388:19: warning: variable 'z' is not initialized [cppcoreguidelines-init-variables]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:393:12: warning: variable 'b' is not initialized [cppcoreguidelines-init-variables]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:785:17: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:798:17: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:810:17: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:823:17: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:834:17: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:883:35: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 78fed40 at 2026-10-16 04:51:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 7 errors and 32 warnings.'
Found 7 errors and 32 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/53e41fb5f396ee2b8706bbc01e7b723ebeae1ecc/O2Physics-code-check/errors.txt
ALICE3/DataModel/OTFMID.h:24:1: error: included header Logger.h is not used directly [misc-include-cleaner,-warnings-as-errors]
ALICE3/DataModel/OTFMID.h:37:59: error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:246:22: error: local copy 'axisNSigma' of the variable 'axisNsigmaCorrect' is never modified and never used; consider removing the statement [performance-unnecessary-copy-initialization,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:571:16: error: no header providing "std::min" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:634:38: error: no header providing "o2::track::DirOutward" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:790:17: error: no header providing "std::max" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:815:61: error: no header providing "std::min" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 32 -gt 0 ]]
++ cat /sw/BUILD/53e41fb5f396ee2b8706bbc01e7b723ebeae1ecc/O2Physics-code-check/warnings.txt
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:64:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:69:8: warning: constructor does not initialize these fields: pdg, ccdb [cppcoreguidelines-pro-type-member-init]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:160:27: warning: use starts_with instead of find [modernize-use-starts-ends-with]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:258:17: warning: member 'layerRadius' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:259:17: warning: member 'layerLength' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:260:17: warning: member 'cellDimensionZ' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:261:17: warning: member 'cellDimensionRPhi' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:262:17: warning: member 'fractionInactive' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:263:17: warning: member 'magField' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:277:11: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:297:7: warning: 'axisZ' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:302:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:306:37: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:307:13: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:311:34: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:361:7: warning: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:368:7: warning: switching on non-enum value without default case may not cover all cases [bugprone-switch-missing-default-case]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:388:13: warning: variable 'x' is not initialized [cppcoreguidelines-init-variables]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:388:16: warning: variable 'y' is not initialized [cppcoreguidelines-init-variables]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:388:19: warning: variable 'z' is not initialized [cppcoreguidelines-init-variables]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:393:12: warning: variable 'b' is not initialized [cppcoreguidelines-init-variables]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:785:17: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:798:17: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:810:17: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:823:17: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:834:17: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/TableProducer/OTF/onTheFlyMidPid.cxx:883:35: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@aortizve aortizve closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants