Skip to content

[PWGEM/PhotonMeson] Add Dalitz electron efficiency task - #18311

Draft
lgansbartl wants to merge 7 commits into
AliceO2Group:masterfrom
lgansbartl:master
Draft

lgansbartl wants to merge 7 commits into
AliceO2Group:masterfrom
lgansbartl:master

Conversation

@lgansbartl

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added pwgem photon Photon and neutral meson PAG label labels Oct 15, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 25 warnings, 🔕 0 disabled

lgansbartl added a commit to lgansbartl/O2Physics that referenced this pull request Oct 15, 2026
Please consider the following formatting changes to AliceO2Group#18311
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 4dd4040 at 2026-10-15 18:22:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 4dd4040 at 2026-10-15 18:27:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4dd4040 at 2026-10-15 20:09:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 31 errors and 0 warnings.'
Found 31 errors and 0 warnings.
++ [[ 31 -gt 0 ]]
++ cat /sw/BUILD/151de045093cf525b55e498d448abb59db729601/O2Physics-code-check/errors.txt
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:17:1: error: included header MCUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:20:1: error: included header BasicCCDBManager.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:21:1: error: included header PhysicsConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:22:1: error: included header GRPMagField.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:23:1: error: included header GRPObject.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:24:1: error: included header Propagator.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:25:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:27:1: error: included header AnalysisHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:30:1: error: included header DataTypes.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:38:1: error: included header Vector4Dfwd.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:53:64: error: no header providing "o2::aod::TracksDCA" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:54:33: error: no header providing "o2::aod::pidTPCFullEl" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:54:52: error: no header providing "o2::aod::pidTPCFullPi" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:54:71: error: no header providing "o2::aod::pidTPCFullKa" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:54:90: error: no header providing "o2::aod::pidTPCFullPr" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:55:33: error: no header providing "o2::aod::pidTOFFullEl" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:55:52: error: no header providing "o2::aod::pidTOFFullPi" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:55:71: error: no header providing "o2::aod::pidTOFFullKa" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:55:90: error: no header providing "o2::aod::pidTOFFullPr" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:56:33: error: no header providing "o2::aod::pidTOFbeta" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:56:50: error: no header providing "o2::aod::TOFSignal" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:56:66: error: no header providing "o2::aod::TOFEvTime" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:58:65: error: no header providing "o2::aod::mcTPCTuneOnData" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:67:39: error: no header providing "o2::aod::PMEvents" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:67:146: error: no header providing "o2::aod::EmMagFields" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:193:14: error: variable 'mcIndexWithMaxTracks' set but not used [clang-diagnostic-unused-but-set-variable,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:208:9: error: Value stored to 'mcIndexWithMaxTracks' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:272:14: error: variable 'mcIndexWithMaxTracks' set but not used [clang-diagnostic-unused-but-set-variable,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:273:14: error: variable 'numOkMc' set but not used [clang-diagnostic-unused-but-set-variable,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:274:14: error: variable 'numNotOkMc' set but not used [clang-diagnostic-unused-but-set-variable,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/dileptonEffiForDalitzSkimmer.cxx:288:9: error: Value stored to 'mcIndexWithMaxTracks' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 31 -gt 0 ]]
++ exit 1
--

[0 more errors; see full log]

Full log here.

@vkucera

vkucera commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Hi @lgansbartl , Since you are adding a new file, please fix all reported errors and warnings so that the CI reports only new issues in the future PRs.

@mhemmer-cern
mhemmer-cern marked this pull request as draft October 16, 2026 08:00
@mhemmer-cern

Copy link
Copy Markdown
Collaborator

Converting to draft to stop test machines from retesting till the next commit with the fixes is coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photon Photon and neutral meson PAG label pwgem

Development

Successfully merging this pull request may close these issues.

4 participants