Skip to content

[Common] Improve Common PCH #18306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsekihat merged 1 commit into from
Oct 16, 2026
+10 −0
Merged

[Common] Improve Common PCH #18306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Common/Core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,23 @@ if(NOT DEFINED ENV{USE_RECC})
<Framework/AnalysisTask.h>
<Framework/ConfigContext.h>
<Framework/DataProcessorSpec.h>
# Measured over all 1463 workflow translation units in the tree: these are
# the framework headers a large majority include and that were not
# precompiled here. Percentages are of those 1463.
<Framework/Configurable.h> # 78%
<Framework/InitContext.h> # 78%
<Framework/AnalysisDataModel.h> # 76%
<Framework/HistogramRegistry.h> # 70%
<Framework/AnalysisHelpers.h> # 69%
<Framework/HistogramSpec.h> # 67%
# NOT runDataProcessing.h. It states the contract itself: "we need to
# declare the customize method before include this file". Precompiling it
# makes it the first include in every workflow, so a source's customize() is
# never seen, its options are never registered, and the binary aborts at
# --dump-workflow with "missing option: ...". The link succeeds, so this
# surfaces as a runtime failure with no hint that a PCH caused it.

<cstdint> # 51%
<memory>
<string>
<vector>
Expand Down
Loading