Skip to content

[PWGHF] Add PCH to speedup PWGHF compilation - #18304

Closed
ktf wants to merge 1 commit into
AliceO2Group:masterfrom
ktf:pr18304
Closed

[PWGHF] Add PCH to speedup PWGHF compilation#18304
ktf wants to merge 1 commit into
AliceO2Group:masterfrom
ktf:pr18304

Conversation

@ktf

@ktf ktf commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added the pwgcf label Oct 15, 2026
@github-actions github-actions Bot changed the title Add PCH to speedup PWGHF compilation [PWGCF,PWGHF,PWGLF] Add PCH to speedup PWGHF compilation Oct 15, 2026
@ktf ktf changed the title [PWGCF,PWGHF,PWGLF] Add PCH to speedup PWGHF compilation Add PCH to speedup PWGHF compilation Oct 15, 2026
@github-actions github-actions Bot changed the title Add PCH to speedup PWGHF compilation [PWGHF] Add PCH to speedup PWGHF compilation Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

vkucera
vkucera approved these changes Oct 15, 2026
View reviewed changes

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ktf !

@vkucera
vkucera enabled auto-merge (squash) October 15, 2026 09:14
@alibuild

alibuild commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for b3f10ed at 2026-10-15 13:28:

## sw/BUILD/O2Physics-latest/log
CMake Error at PWGHF/D2H/Core/CMakeLists.txt:26 (add_library):
CMake Error at PWGHF/D2H/Core/CMakeLists.txt:26 (add_library):

Full log here.

@alibuild

alibuild commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b3f10ed at 2026-10-15 13:31:

## sw/BUILD/O2Physics-latest/log
CMake Error at PWGHF/D2H/Core/CMakeLists.txt:26 (add_library):
CMake Error at PWGHF/D2H/Core/CMakeLists.txt:26 (add_library):

Full log here.

@alibuild

alibuild commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for b3f10ed at 2026-10-15 14:02:

## sw/BUILD/O2Physics-latest/log
CMake Error at PWGHF/D2H/Core/CMakeLists.txt:26 (add_library):
CMake Error at PWGHF/D2H/Core/CMakeLists.txt:26 (add_library):

Full log here.

vkucera
vkucera reviewed Oct 15, 2026
View reviewed changes
Comment thread PWGHF/D2H/Core/CMakeLists.txt
#
# Skipped under recc, which caches compilations remotely instead -- the two do
# not combine, as a PCH is a local artefact of one compiler invocation.
add_library(D2HReducedPCH OBJECT d2hReducedPCH.cxx)

@vkucera vkucera Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is missing.

@vkucera

vkucera commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Can you please merge these changes into #18308 ?

@vkucera vkucera closed this Oct 15, 2026
auto-merge was automatically disabled October 15, 2026 12:21

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque
@skundu692 skundu692 Awaiting requested review from skundu692
@mpuccio mpuccio Awaiting requested review from mpuccio
@ercolessi ercolessi Awaiting requested review from ercolessi
@romainschotter romainschotter Awaiting requested review from romainschotter
@lhusova lhusova Awaiting requested review from lhusova
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner
@jaelpark jaelpark Awaiting requested review from jaelpark
@wenyaCern wenyaCern Awaiting requested review from wenyaCern
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez
@dsarkaralice dsarkaralice Awaiting requested review from dsarkaralice
@lauraser lauraser Awaiting requested review from lauraser

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ktf @alibuild @vkucera