Skip to content

[ALICE3] OTF: New tracker ToT LUT approach - #18297

Open
hfribert wants to merge 5 commits into
AliceO2Group:masterfrom
hfribert:alice3-o2-ToT
Open

hfribert wants to merge 5 commits into
AliceO2Group:masterfrom
hfribert:alice3-o2-ToT

Conversation

@hfribert

Copy link
Copy Markdown
Contributor
  • The dE/dx of each track is sampled from a per-track LUT made from the full simulation: a histogram per species, |η|, and p/z, interpolated in p/z, read locally or from CCDB (replaces the per-layer ToT LUTs)
  • The nσ tables are removed & nσ is built offline from the species bands
  • New histograms for η-differential bands and bookkeeping

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@hfribert
hfribert marked this pull request as ready for review October 14, 2026 16:17
njacazio
njacazio previously approved these changes Oct 14, 2026
@njacazio
njacazio enabled auto-merge (squash) October 14, 2026 16:39
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 8fa339e at 2026-10-14 20:16:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 8fa339e at 2026-10-14 20:17:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 8fa339e at 2026-10-14 20:17:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 80942b6 at 2026-10-15 10:36:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/5dbeb932e20c36171f123487998f14ad59c3381e/O2Physics-code-check/errors.txt
ALICE3/TableProducer/OTF/onTheFlyTrackerPid.cxx:337:33: error: no header providing "std::distance" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

auto-merge was automatically disabled October 15, 2026 08:43

Head branch was pushed to by a user without write access

@jesgum

jesgum commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Hi @hfribert and @njacazio! Just a small comment about removing the produces call for the nσ table: it looks like the tables are used in some cases, e.g., in the Lc workflow, which then wouldn't be able to run since the soa::Join would crash at runtime for trying to join tables of different sizes as the ToT nσ table would always be zero.

I'm not sure whether the table is actually used later on or it's just subscribed to. I case of the latter, I suggest that we could just change the process function, otherwise we should probably find another solution.

@njacazio

Copy link
Copy Markdown
Collaborator

Hi @jesgum many thanks for noticing this! Indeed @hfribert can't we keep the tables?

@hfribert

hfribert commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Hi @jesgum and @njacazio, thanks a lot for spotting that!
Indeed we can just keep them, didn't catch it since I only ran the tracker-pid task, I'll add them back so nothing should break then.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d77c23c at 2026-10-15 17:06:

No log files found

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants