Skip to content

[PWGUD] Fix code check and remove logf in upcTrackVertexingQA - #18286

Merged
amatyja merged 5 commits into
AliceO2Group:masterfrom
atavirag:upc-task-force
Oct 16, 2026
Merged

amatyja merged 5 commits into
AliceO2Group:masterfrom
atavirag:upc-task-force

Conversation

@atavirag

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

amatyja
amatyja previously approved these changes Oct 14, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a256d68 at 2026-10-14 17:51:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/a64ec522957dae90e75def1cf40b02918e42f352/O2Physics-code-check/errors.txt
PWGUD/Tasks/upcTrackVertexingQA.cxx:35:1: error: included header PxPyPzM4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@atavirag

Copy link
Copy Markdown
Contributor Author

Hi @amatyja, it seems like the macOs-arm build failed due to an error that is unrelated to this PR. Would it be possible to merge it?

@amatyja
amatyja enabled auto-merge (squash) October 15, 2026 13:18
auto-merge was automatically disabled October 15, 2026 13:46

Head branch was pushed to by a user without write access

Comment thread PWGUD/Tasks/upcTrackVertexingQA.cxx
@amatyja
amatyja merged commit 8540f7c into AliceO2Group:master Oct 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants