Repository navigation
Conversation
hero-seo
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera,
xinyepeng and
zhangbiao-phy
as code owners
October 12, 2026 07:52
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
Author
|
I noticed that aod::McParticles does not provide an m() accessor, so I’m working on the proper way to store the generated Xicp invariant mass and will update this PR. |
Collaborator
|
Hi @hero-seo , thanks for your first contribution. If your PR needs more changes that you are still working on, you can convert it to a draft. If you realise that something in your changes is wrong and needs to be fixes, please do not close the PR. Instead, commit your new changes in the same branch and push them. Your PR will get updated automatically. |
hero-seo
marked this pull request as draft
October 12, 2026 11:49
Author
|
Hi, @vkucera. I've converted the PR to a draft and I will push the new commits once the changes are ready. Thanks for the advice!! |
hero-seo
marked this pull request as ready for review
October 12, 2026 13:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add rapidity-pT histogram for generated MC and invariant mass-pT histogram for truth-matched reconstructed MC.
Add invariant mass column in HFXICXI2PIFULLP table for comparing with reco-level Xicp invariant mass.
These additions are intended for MC validation and reco/gen-level comparisons.
@JaeYoonCHO If you have any comments or suggestions, please let me know.