Repository navigation
[PWGHF] Cache D* soft pions propagation - #18214
Merged
Merged
Conversation
Marcellocosti
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera,
xinyepeng and
zhangbiao-phy
as code owners
October 8, 2026 10:25
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#18214
vkucera
reviewed
Oct 12, 2026
Comment on lines
+1509
to
+1510
| LabeledArray<double> cutsDstar{}; | ||
| std::vector<double> binsPtDstar{}; |
Collaborator
|
@fchinu Since you did the original implementation, could you please have a look at this one? |
fchinu
approved these changes
Oct 16, 2026
fchinu
left a comment
fchinu
left a comment
Contributor
There was a problem hiding this comment.
Good for me, thanks a lot @Marcellocosti
Contributor
Author
|
Hello, can this be merged? Thanks! |
zhangbiao-phy
enabled auto-merge (squash)
October 16, 2026 09:02
zhangbiao-phy
disabled auto-merge
October 16, 2026 09:03
zhangbiao-phy
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #17906 to the soft pions tracks in D* candidate creation. I estimated a 20% reduction of the total CPU time locally on ~4000 collisions in 0-20% centrality. I needed to define an overloaded function to deal with the
std::optionaltype of the soft pions tables. I also defined a dedicated and lighter struct for soft pions, as neither the track object nor the track covariance matrix are needed in the processing.Please let me know if you spot any issue with the implementation or if you have further suggestions!