Repository navigation
[O2B-1626] On creation of log, allow linking to it of data passes - #2246
Merged
graduta merged 20 commits intoOct 16, 2026
Merged
Conversation
…ciated to eor reason
…re/O2B-1621/associate-eor-reasons-to-user-by-id
…re/O2B-1621/associate-eor-reasons-to-user-by-id
…re/O2B-1621/associate-eor-reasons-to-user-by-id
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2246 +/- ##
==========================================
+ Coverage 46.24% 46.36% +0.12%
==========================================
Files 1042 1046 +4
Lines 17190 17258 +68
Branches 3127 3140 +13
==========================================
+ Hits 7949 8002 +53
- Misses 9241 9256 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Public log retrieval still omits saved data-pass links, preventing reply inheritance and undermining the new browser assertions.
2 open findings
What changed in this PR
Adds data-pass links to log creation and replies, spanning the form, creation services, and database storage.
Changes:
- Accept and validate data-pass names when creating logs.
- Store associations and expose compact data-pass references.
- Add form inputs, reply inheritance, fixtures, and tests.
| File | Description |
|---|---|
| test/public/logs/create.test.js | Tests linked passes and autofill. |
| test/lib/usecases/log/CreateLogUseCase.test.js | Tests duplicates and unknown names. |
| lib/usecases/log/CreateLogUseCase.js | Deduplicates and forwards names. |
| lib/server/services/run/RunService.js | Adjusts creation arguments. |
| lib/server/services/run/logEntriesCreation/logSpecificRunTag.js | Preserves transaction argument position. |
| lib/server/services/run/logEntriesCreation/logRunQualityChange.js | Preserves transaction argument position. |
| lib/server/services/run/logEntriesCreation/logCalibrationStatusChange.js | Preserves transaction argument position. |
| lib/server/services/log/LogService.js | Loads and forwards linked passes. |
| lib/server/services/log/createLog.js | Validates and stores associations. |
| lib/server/services/dataPasses/getAllDataPassesByNameOrFail.js | Resolves names or rejects missing passes. |
| lib/public/views/Logs/Create/LogReplyModel.js | Inherits parent data-pass names. |
| lib/public/views/Logs/Create/LogCreationModel.js | Tracks and submits names. |
| lib/public/views/Logs/Create/logCreationComponent.js | Adds the data-pass input. |
| lib/domain/entities/Log.js | Documents linked passes. |
| lib/domain/dtos/CreateLogDto.js | Accepts data-pass name arrays. |
| lib/database/tables/logdatapasses.js | Defines the join model. |
| lib/database/tables/index.js | Registers the join model. |
| lib/database/seeders/20240112102500-log-data-passes.js | Seeds sample associations. |
| lib/database/repositories/LogDataPassesRepository.js | Inserts associations. |
| lib/database/repositories/index.js | Exports the new repository. |
| lib/database/models/typedefs/SequelizeLog.js | Documents the association. |
| lib/database/models/log.js | Defines the many-to-many relationship. |
| lib/database/migrations/v1/20261010100000-create-log-data-passes.js | Creates the join table. |
| lib/database/adapters/LogAdapter.js | Serializes linked passes. |
| lib/database/adapters/index.js | Connects the data-pass adapter. |
| lib/database/adapters/DataPassAdapter.js | Adds compact identification output. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…f github.com:AliceO2Group/Bookkeeping into feature/O2B-1626/log-creation-to-link-to-data-passes
graduta
deleted the
feature/O2B-1626/log-creation-to-link-to-data-passes
branch
October 16, 2026 09:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: