Skip to content

[O2B-1621] Associate eor reasons to user by user id and not name - #2235

Merged
graduta merged 11 commits into
mainfrom
feature/O2B-1621/associate-eor-reasons-to-user-by-id
Oct 15, 2026
Merged

graduta merged 11 commits into
mainfrom
feature/O2B-1621/associate-eor-reasons-to-user-by-id

Conversation

@graduta

@graduta graduta commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • none

Notable changes for developers:

  • the run use case(used by the HTTP API) is now throwing error if the change of an EOR reason does not contain valid id of an existing user
  • the usecase has been adapted to throw rather than return object with error
  • the run service has also been updated but this as it is used by Kafka and gRPC services for automatic EOR purposes, do not require to have a user id
  • ticket is needed to achieve easier pseudonymization for Bookkeeping

Changes made to the database:

  • table eor_reason now is associated to user tables by user id

@graduta
graduta requested a review from isaachilly as a code owner October 1, 2026 14:53
@graduta graduta changed the title [O2B-162associate eor reasons to user by [O2B-1621] Associate eor reasons to user by user id and not name Oct 1, 2026
@graduta graduta self-assigned this Oct 1, 2026
@graduta
graduta added this pull request to stack #2236 October 1, 2026 14:55
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.24%. Comparing base (8ee4a49) to head (834be32).

Files with missing lines Patch % Lines
...261001100000-eor-reasons-last-edited-by-user-id.js 55.55% 4 Missing ⚠️
lib/public/views/Runs/format/editRunEorReasons.js 0.00% 2 Missing ⚠️
lib/public/views/Runs/format/formatRunEorReason.js 0.00% 2 Missing ⚠️
lib/public/views/Runs/Details/RunPatch.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2235      +/-   ##
==========================================
+ Coverage   46.23%   46.24%   +0.01%     
==========================================
  Files        1041     1042       +1     
  Lines       17179    17190      +11     
  Branches     3129     3127       -2     
==========================================
+ Hits         7942     7949       +7     
- Misses       9237     9241       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feature/O2B-1620/associate-user-tag-by-id-not-name to main October 14, 2026 19:32
@graduta
graduta force-pushed the feature/O2B-1621/associate-eor-reasons-to-user-by-id branch from d3d9ccb to 0c7d421 Compare October 14, 2026 19:32
…re/O2B-1621/associate-eor-reasons-to-user-by-id
@graduta
graduta force-pushed the feature/O2B-1621/associate-eor-reasons-to-user-by-id branch from 0c7d421 to 5fc33cf Compare October 15, 2026 07:52
…re/O2B-1621/associate-eor-reasons-to-user-by-id
…re/O2B-1621/associate-eor-reasons-to-user-by-id
@graduta
graduta merged commit b8c5ebf into main Oct 15, 2026
25 checks passed
@graduta
graduta deleted the feature/O2B-1621/associate-eor-reasons-to-user-by-id branch October 15, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants