Repository navigation
GPU: reach global memory through the generic address space on Metal - #15936
Merged
Merged
Conversation
GPUglobalref() expanded to device, which is what the OpenCL 1 port needed. It no longer matches the code: since the constant address space was dropped, the objects the kernels work on are reached through a generic `this`, so a member pointer or the address of a member is a generic pointer, and MSL will not pass one where a device pointer is wanted. MSL 4.1's generic address space spans device, threadgroup and thread, so leaving the annotation off is correct for every one of these. This mirrors the OpenCL C++ branch, where GPUglobalref() is likewise empty and GPUgeneric() carries the annotation. GPUsharedref() and GPUconstantref() stay explicit: threadgroup is still worth pinning where it is known, and constant is not reachable through a generic pointer at all.
Member
Author
|
Metal only, not tested. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPUglobalref() expanded to device, which is what the OpenCL 1 port needed. It no
longer matches the code: since the constant address space was dropped, the
objects the kernels work on are reached through a generic
this, so a memberpointer or the address of a member is a generic pointer, and MSL will not pass
one where a device pointer is wanted.
MSL 4.1's generic address space spans device, threadgroup and thread, so leaving
the annotation off is correct for every one of these. This mirrors the OpenCL C++
branch, where GPUglobalref() is likewise empty and GPUgeneric() carries the
annotation. GPUsharedref() and GPUconstantref() stay explicit: threadgroup is
still worth pinning where it is known, and constant is not reachable through a
generic pointer at all.