Repository navigation
[STALE: REBASE FROM NEW FORK] test: run client-connect.test.ts in its own process (shard 4/4 batch 8 stall) - #42
Conversation
The transaction fixture bounds a child with a blocking spawnSync timeout; in a shared Bun process after earlier files, shard 4/4 batch 8 stalled to the 120 s batch limit while every file passes alone. Add it to SERIAL_FULL_SUITE_FILES so it runs as a one-file batch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This PR is based on the superseded 2.65 gateway line. Rebuild the change from |
|
Trial evidence: before the merge the build ran 30.5 h on the laptop gateway and 24 h on the personal Mac Mini gateway, both with For new work:
Before opening a PR, use pinned Bun 1.4.4 with an isolated
Hosted-only behavior needs For this PR: upstream test layout and sharding changed. Re-check whether the client-connect stall reproduces on 🤖 Generated with Claude Code |
What
Adds
clients/client-connect.test.tstoSERIAL_FULL_SUITE_FILESinscripts/test.ts, so the batch runner gives it a fresh Bun process.Why
Test shard 4/4 timed out at the 120 s batch limit in batch 8 on recent release-line PRs. The last passing case is client-connect.test.ts:554; the next one (:577, "transaction fixture stops a child retained after valid output") keeps its child alive on purpose and relies on a blocking
spawnSynctimeout to kill it. WhilespawnSyncblocks, Bun's per-test timeout cannot fire. Every file in the batch passes alone, so the stall needs earlier files' process state; a fresh process removes that. Same quarantine reason as the existing serial entries (see tests/helpers/cold-spawn-warmup.ts:216-224).Containment, not a rewrite: making that fixture async would touch about 30 callers in a size-ratcheted file.
Proof wanted
Shard 4/4 green on two runs in a row.
Eval added/updated: N/A test-runner manifest only, no product behaviour change
🤖 Generated with Claude Code