Repository navigation
fix: recover completed plan work through explicit acceptance - #1911
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plan that finished before its engine restarted could reopen as interrupted, with saved files but no working acceptance door. Recovery now restores the existing explicit accept/refute decision, preserving its copy, crew, completion time and full worker/checker cost. It does not rerun finished work or automatically merge it, including with unattended approvals enabled.
Acceptance uses the existing landing path and records the actual commit. Conversation ownership, saved-branch checks and Stop admission remain enforced. Missing copies and failed checkpoint/page-receipt writes report actionable, truthful outcomes. If the last checkpoint predates the final charge, its price is restored from the existing ledger without charging again.
Validation with fictional data:
deepseek/deepseek-v4.1-flash, including auxiliary roles. Full task ledger and recovered/accepted receipt stayed at $0.007849236. Restart and acceptance added no model calls or charges.make pr-readypassed. Its classifier reproduced the unrelatedTestLowCreditReadSwapsOnlyAnUntouchedImplicitConversationfailure on unchanged dev; that existing failure is not claimed fixed here.Reproduce after
make build:The live command requires a configured OpenRouter key; every role must remain on the recorded model.
Closes #1657.