Repository navigation
St andrews fix - #374
Open
MaxPelly wants to merge 2 commits into
Open
St andrews fix#374MaxPelly wants to merge 2 commits into
MaxPelly wants to merge 2 commits into
Conversation
A few changes to support the converted FDS .XRDML files produced by the university of St Andrews school of chemistry PXRD department. Adds .XRDML as an allowed extension and makes the sample variable optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support the .XRDML files produced by St Andrews ADS to FDS conversion. Adds .XRDML as a supported extension and make the sample variable optional.
We've always just used powdll to convert the XRDML files but was doing some work with @dafda1 and we noticed the files are actually essentially identical.
Example XRDMLs.zip
(apologies for the two pull requests, was cleaning up my branches and unintentionally closed the old one)