Repository navigation
Conversation
Update add_powder_histogram function to read the selected databank if multiple = False. Currently just always reads the first.
Contributor
Author
|
No, the actual issues was the reader was being reinitialised after the generic importer sets rd.selections. Moving the reinitialise step to before this fixes everything |
Contributor
Author
|
A similar issue in the GUI import causing multi file imports to lose the selections after the first file |
…here were selections code fell through to no powder data error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update add_powder_histogram function to read the selected databank if multiple = False. Currently just always reads the first.
Fixes #372.
There does seem to be some work in implementing another solution using rd.selections in the generic importer however this is overwritten by the Reader, so this seems like the cleanest solution at the moment.