Skip to content

test: add ftp, sftp and file operation tests (#2778) - #2928

Merged
RohitKushvaha01 merged 5 commits into
Acode-Foundation:mainfrom
Elitex07:issue-2778
Oct 22, 2026
Merged

RohitKushvaha01 merged 5 commits into
Acode-Foundation:mainfrom
Elitex07:issue-2778

Conversation

@Elitex07

Copy link
Copy Markdown
Contributor

Closes #2778

Added runtime tests for:

  • FTP operations
  • SFTP operations
  • File operations (copyTo, moveTo, renameTo)

Note: I have not been able to physically test these on a device yet, as I don't have my tablet with me until the 28th. Opening as a draft in the meantime!

@Elitex07
Elitex07 marked this pull request as ready for review October 22, 2026 07:11
@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; both previous findings are fixed and no new actionable issues were found.

Summary

Adds runtime tests for local file operations and configured FTP/SFTP servers.

  • The filesystem test suite checks copy, move, and rename.
  • The test runner checks file and folder operations on FTP servers.
  • The test runner checks file and folder operations on SFTP servers.

Review used the full PR diff because the current and previously reviewed commits have different merge bases with the target commit. Device and live-server tests were not run.

Reviews (2) · Last reviewed commit: "test: fix ftp/sftp/fs runtime test asser..." · Reviewed by Greptile

Comment thread src/test/fs.tests.js Outdated
Comment thread src/test/ftp.tests.js
@Elitex07

Copy link
Copy Markdown
Contributor Author

fs + SFTP all passing. FTP is 3/4, the one failing is Created directory should exist and that one is an actual bug I think: FTP exists() does listFiles(path) and for an empty folder it returns 0 entries, so it says folder doesn't exist. Kept that assertion as it is so it catches it. Will raise a separate issue for this.

Tested with FTP on local server via adb reverse and SFTP on my linux laptop.

@Elitex07

Copy link
Copy Markdown
Contributor Author

@greptile review again

@RohitKushvaha01
RohitKushvaha01 added this pull request to the merge queue Oct 22, 2026
Merged via the queue into Acode-Foundation:main with commit 665ce1c Oct 22, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

More tests

3 participants