Repository navigation
Add containerProps and natively deprecate wrapperProps - #53
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the form container-property API without changing property handling or target elements.
Add
containerProps()to TextInput, EmailInput, Password, TextArea, Select, and Fieldset. KeepwrapperProps()as a direct forwarding alias returning the result ofcontainerProps(), marked#[\Deprecated(message: 'Use containerProps() instead.', since: '5.0')]. Native method deprecation is supported starting in PHP 8.4 and emitsE_USER_DEPRECATED.Move target-element documentation to the new API, update examples and existing tests, and document migration with alias retention throughout 5.x and removal no earlier than 6.0. Add regression tests for all six components and every Select mode verifying fluent return identity, identical rendered output, deprecation metadata, and the native runtime notice.
Validation:
composer productionpassed on PHP 8.5.2 (source style, PHPStan, and 195 tests / 1,810 assertions).git --no-pager diff --checkpassed. PHP 8.4 was not run locally; the PR's existing CI matrix covers it.List of issues fixed
N/A — user-requested follow-up to #44; no additional issue.