From 4b16864b923f9ad449d440aa6e94c0d84a7270de Mon Sep 17 00:00:00 2001 From: Christoph Knittel Date: Sun, 18 Oct 2026 15:38:18 +0000 Subject: [PATCH] Require the dev container build in ci-ok The ci-ok job now also needs test-devcontainer, which runs make in the dev container on every pull request. Since the master ruleset requires only ci-ok, a broken dev container no longer merges unnoticed. Review: Why not dev-playground too? It runs only on pushes to master and deploys to GitHub Pages. On pull requests it is skipped, and ci-ok fails on any result other than success. Review: Does this slow CI down? test-devcontainer took 8 to 10 minutes in the last 40 CI runs, about as long as the Windows build-compiler job. Area: ci Output: unchanged Tests: none, because the change is CI configuration Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_0193XhTJFgkaaGZTNw9Uqd5v Signed-off-by: Christoph Knittel --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 14f2e18e11..5ae0d6d6d9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -673,6 +673,7 @@ jobs: - build-compiler - pkg-pr-new - api-docs + - test-devcontainer - test-installation-npm - test-installation-pnpm runs-on: ubuntu-26.04