From 4583cfeb86feb2f17819f964be7f425be83815aa Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Mon, 19 Oct 2026 13:17:24 +0200 Subject: [PATCH] Make test AddFullyQualifiedIdentifierDocblockRector idempotent Skip when the var tag is already present, so repeated passes do not re-add it. --- .../Source/AddFullyQualifiedIdentifierDocblockRector.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/Issues/ImportFullyQualifiedIdentifierDocblock/Source/AddFullyQualifiedIdentifierDocblockRector.php b/tests/Issues/ImportFullyQualifiedIdentifierDocblock/Source/AddFullyQualifiedIdentifierDocblockRector.php index 5657dd4d7c8..0f040cb9e73 100644 --- a/tests/Issues/ImportFullyQualifiedIdentifierDocblock/Source/AddFullyQualifiedIdentifierDocblockRector.php +++ b/tests/Issues/ImportFullyQualifiedIdentifierDocblock/Source/AddFullyQualifiedIdentifierDocblockRector.php @@ -36,6 +36,12 @@ public function getNodeTypes(): array public function refactor(Node $node) { $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node); + + // make rule idempotent, do not add if already present + if ($phpDocInfo->getVarTagValueNode() instanceof VarTagValueNode) { + return null; + } + $varTagValueNode = new VarTagValueNode(new FullyQualifiedIdentifierTypeNode('DateTime'), '', ''); $phpDocInfo->addTagValueNode($varTagValueNode);