diff --git a/langfuse/_utils/prompt_cache.py b/langfuse/_utils/prompt_cache.py index e286dca49..7427f32cd 100644 --- a/langfuse/_utils/prompt_cache.py +++ b/langfuse/_utils/prompt_cache.py @@ -182,9 +182,10 @@ def delete(self, key: str) -> None: def invalidate(self, prompt_name: str) -> None: """Invalidate all cached prompts with the given prompt name.""" + prefixes = (f"{prompt_name}-version:", f"{prompt_name}-label:") with self._lock: for key in list(self._cache): - if key.startswith(prompt_name): + if key.startswith(prefixes): del self._cache[key] def add_refresh_prompt_task(self, key: str, fetch_func: Callable[[], None]) -> None: diff --git a/tests/unit/test_prompt_cache.py b/tests/unit/test_prompt_cache.py new file mode 100644 index 000000000..c747a2f80 --- /dev/null +++ b/tests/unit/test_prompt_cache.py @@ -0,0 +1,38 @@ +from threading import RLock + +from langfuse._utils.prompt_cache import PromptCache + + +def _cache_with(keys): + cache = object.__new__(PromptCache) + cache._lock = RLock() + cache._cache = {key: object() for key in keys} + return cache + + +def test_invalidate_does_not_remove_prompts_with_name_prefix(): + cache = _cache_with( + ["foo-label:production", "foobar-label:production", "unrelated-version:2"] + ) + + cache.invalidate("foo") + + assert "foo-label:production" not in cache._cache + assert "foobar-label:production" in cache._cache + assert "unrelated-version:2" in cache._cache + + +def test_invalidate_does_not_remove_hyphenated_name_prefix(): + k = PromptCache.generate_cache_key + keys = [ + k("my-prompt", version=None, label=None), + k("my-prompt", version=3, label=None), + k("my-prompt-extra", version=None, label=None), + ] + cache = _cache_with(keys) + + cache.invalidate("my-prompt") + + assert k("my-prompt", version=None, label=None) not in cache._cache + assert k("my-prompt", version=3, label=None) not in cache._cache + assert k("my-prompt-extra", version=None, label=None) in cache._cache