diff --git a/packages/mcp-core/src/api-client/client-event.test.ts b/packages/mcp-core/src/api-client/client-event.test.ts index 5e30187c4..50f233410 100644 --- a/packages/mcp-core/src/api-client/client-event.test.ts +++ b/packages/mcp-core/src/api-client/client-event.test.ts @@ -56,7 +56,7 @@ describe("getEventForIssue context validation", () => { ); expect(log).toHaveBeenCalledTimes(1); - const output = String(log.mock.calls[0][0]); + const output = String(log.mock.calls[0]![0]); const record = JSON.parse(output); expect(record.message).toBe("Event failed schema validation: error"); expect(record.properties.contextType).toBe(contextType); diff --git a/packages/mcp-core/src/api-client/client.test.ts b/packages/mcp-core/src/api-client/client.test.ts index 3ffc8f115..b72e8c309 100644 --- a/packages/mcp-core/src/api-client/client.test.ts +++ b/packages/mcp-core/src/api-client/client.test.ts @@ -1973,7 +1973,7 @@ describe("request headers", () => { }).getAuthenticatedUser(); const [, requestInit] = (globalThis.fetch as ReturnType).mock - .calls[0]; + .calls[0]!; expect(new Headers(requestInit.headers).get("User-Agent")).toBe( "sentry-mcp/0.48.0-test (https://mcp.sentry.dev)", ); @@ -2006,7 +2006,7 @@ describe("request headers", () => { await apiService.getAuthenticatedUser(); const [, requestInit] = (globalThis.fetch as ReturnType).mock - .calls[0]; + .calls[0]!; expect(new Headers(requestInit.headers).get("X-Sentry-MCP-Client-Id")).toBe( "abc123", ); @@ -2044,7 +2044,7 @@ describe("request headers", () => { await apiService.getAuthenticatedUser(); const [, requestInit] = (globalThis.fetch as ReturnType).mock - .calls[0]; + .calls[0]!; expect( new Headers(requestInit.headers).get("X-Sentry-MCP-Client-Id"), ).toBeNull(); @@ -2940,7 +2940,7 @@ describe("API query builders", () => { }, ]); expect(urls).toHaveLength(1); - const params = new URL(urls[0]).searchParams; + const params = new URL(urls[0]!).searchParams; expect(params.get("itemType")).toBe("spans"); expect(params.get("project")).toBe("123"); expect(params.get("statsPeriod")).toBe("7d"); @@ -2978,7 +2978,7 @@ describe("API query builders", () => { }); expect(urls).toHaveLength(1); - const params = new URL(urls[0]).searchParams; + const params = new URL(urls[0]!).searchParams; expect(params.get("itemType")).toBe("spans"); expect(params.get("expand")).toBe("context"); }); @@ -3419,7 +3419,7 @@ describe("API query builders", () => { expect.any(Object), ); expect(repos).toHaveLength(1); - expect(repos[0].name).toBe("getsentry/sentry"); + expect(repos[0]?.name).toBe("getsentry/sentry"); }); it("should paginate repos", async () => { @@ -3469,8 +3469,8 @@ describe("API query builders", () => { "getsentry/sentry-javascript", ]); expect(fetchMock).toHaveBeenCalledTimes(2); - expect(fetchMock.mock.calls[0][0]).toContain("per_page=100"); - expect(fetchMock.mock.calls[1][0]).toContain("cursor=cursor-2"); + expect(fetchMock.mock.calls[0]?.[0]).toContain("per_page=100"); + expect(fetchMock.mock.calls[1]?.[0]).toContain("cursor=cursor-2"); }); it("should include query parameter when provided", async () => { @@ -3547,8 +3547,8 @@ describe("API query builders", () => { }); expect(repos).toHaveLength(1); - expect(repos[0].externalSlug).toBeNull(); - expect(repos[0].externalId).toBeNull(); + expect(repos[0]!.externalSlug).toBeNull(); + expect(repos[0]!.externalId).toBeNull(); }); }); @@ -3614,7 +3614,7 @@ describe("API query builders", () => { }), ); expect(result.created).toBe(1); - expect(result.mappings[0].status).toBe("created"); + expect(result.mappings[0]?.status).toBe("created"); }); it("should handle updated mappings response", async () => { @@ -3647,7 +3647,7 @@ describe("API query builders", () => { }); expect(result.updated).toBe(1); - expect(result.mappings[0].status).toBe("updated"); + expect(result.mappings[0]?.status).toBe("updated"); }); }); diff --git a/packages/mcp-core/src/api-client/client.ts b/packages/mcp-core/src/api-client/client.ts index 88e55080a..0f527c8b0 100644 --- a/packages/mcp-core/src/api-client/client.ts +++ b/packages/mcp-core/src/api-client/client.ts @@ -1059,8 +1059,9 @@ export class SentryApiService { if (isAggregate) { urlParams.set("mode", "aggregate"); // For aggregate queries in Discover, set yAxis to the first aggregate function - if (aggregateFunctions && aggregateFunctions.length > 0) { - urlParams.set("yAxis", aggregateFunctions[0]); + const firstAggregate = aggregateFunctions?.[0]; + if (firstAggregate !== undefined) { + urlParams.set("yAxis", firstAggregate); } } else { urlParams.set("yAxis", "count()"); @@ -3561,7 +3562,7 @@ export class SentryApiService { uri: string; query?: string; projectId?: string; - dependentData?: Record; + dependentData?: Record; }, opts?: RequestOptions, ): Promise { @@ -4003,7 +4004,7 @@ export class SentryApiService { // the two share the same DB source but the download header reflects any // server-side correction (getsentry/sentry#115977) applied at request time. const contentType = - downloadResponse.headers.get("content-type")?.split(";")[0].trim() || + downloadResponse.headers.get("content-type")?.split(";")[0]?.trim() || attachment.mimetype || "application/octet-stream"; @@ -5073,7 +5074,8 @@ export class SentryApiService { ProfileChunkResponseSchema, ); // Normalize the Sentry {chunk: ...} wrapper to the internal chunks array. - if (response.chunks.length === 0) { + const [chunk] = response.chunks; + if (chunk === undefined) { throw new ApiNotFoundError( `No profile chunk found for profiler_id ${params.profilerId}`, undefined, @@ -5082,10 +5084,10 @@ export class SentryApiService { } return { - ...response.chunks[0], + ...chunk, // Sentry's frontend does the same query-param backfill for continuous // profile chunks because profiling-service may omit profiler_id. - profiler_id: response.chunks[0].profiler_id ?? params.profilerId, + profiler_id: chunk.profiler_id ?? params.profilerId, }; } diff --git a/packages/mcp-core/src/api-client/schema.test.ts b/packages/mcp-core/src/api-client/schema.test.ts index d0b459d97..b95b7d622 100644 --- a/packages/mcp-core/src/api-client/schema.test.ts +++ b/packages/mcp-core/src/api-client/schema.test.ts @@ -711,7 +711,7 @@ describe("AutofixRunStateSchema", () => { expect(state.autofix?.status).toBe("processing"); expect(state.autofix?.blocks).toHaveLength(1); - expect(state.autofix?.blocks[0].todos).toEqual([ + expect(state.autofix?.blocks[0]?.todos).toEqual([ { content: "Investigate failing request", status: "completed" }, { content: "Draft fix plan", status: "in_progress" }, ]); diff --git a/packages/mcp-core/src/internal/agents/callEmbeddedAgent.ts b/packages/mcp-core/src/internal/agents/callEmbeddedAgent.ts index ac826bbb9..236230af7 100644 --- a/packages/mcp-core/src/internal/agents/callEmbeddedAgent.ts +++ b/packages/mcp-core/src/internal/agents/callEmbeddedAgent.ts @@ -370,7 +370,7 @@ function extractJsonCandidates(text: string): string[] { const codeBlockRegex = /```(?:json)?\s*\n?([\s\S]*?)\n?```/g; const allMatches = [...text.matchAll(codeBlockRegex)]; for (const match of allMatches) { - candidates.add(match[1].trim()); + candidates.add(match[1]!.trim()); } // Strategy 2: Find balanced JSON objects anywhere in the text. diff --git a/packages/mcp-core/src/internal/agents/tools/dataset-fields.test.ts b/packages/mcp-core/src/internal/agents/tools/dataset-fields.test.ts index b60ad3cac..dd6aaf13a 100644 --- a/packages/mcp-core/src/internal/agents/tools/dataset-fields.test.ts +++ b/packages/mcp-core/src/internal/agents/tools/dataset-fields.test.ts @@ -72,10 +72,10 @@ describe("dataset-fields agent tool", () => { expect(result.dataset).toBe("search_issues"); expect(result.fields).toHaveLength(2); // sentry:user should be filtered out - expect(result.fields[0].key).toBe("level"); - expect(result.fields[0].name).toBe("Level"); - expect(result.fields[0].totalValues).toBe(5); - expect(result.fields[1].key).toBe("is"); + expect(result.fields[0]?.key).toBe("level"); + expect(result.fields[0]?.name).toBe("Level"); + expect(result.fields[0]?.totalValues).toBe(5); + expect(result.fields[1]?.key).toBe("is"); expect(result.commonPatterns).toContainEqual({ pattern: "is:unresolved", description: "Open issues", @@ -116,15 +116,15 @@ describe("dataset-fields agent tool", () => { expect(result.dataset).toBe("events"); expect(result.fields).toHaveLength(2); - expect(result.fields[0].key).toBe("http.method"); - expect(result.fields[0].examples).toEqual([ + expect(result.fields[0]?.key).toBe("http.method"); + expect(result.fields[0]?.examples).toEqual([ "GET", "POST", "PUT", "DELETE", ]); - expect(result.fields[1].key).toBe("environment"); - expect(result.fields[1].examples).toEqual([ + expect(result.fields[1]?.key).toBe("environment"); + expect(result.fields[1]?.examples).toEqual([ "production", "staging", "development", @@ -270,12 +270,12 @@ describe("dataset-fields agent tool", () => { "search_issues", ); - expect(issuesResult.fields[0].examples).toEqual([ + expect(issuesResult.fields[0]?.examples).toEqual([ "email@example.com", "team-slug", "me", ]); - expect(issuesResult.fields[1].examples).toEqual([ + expect(issuesResult.fields[1]?.examples).toEqual([ "unresolved", "resolved", "ignored", @@ -304,13 +304,13 @@ describe("dataset-fields agent tool", () => { "events", ); - expect(eventsResult.fields[0].examples).toEqual([ + expect(eventsResult.fields[0]?.examples).toEqual([ "GET", "POST", "PUT", "DELETE", ]); - expect(eventsResult.fields[1].examples).toEqual([ + expect(eventsResult.fields[1]?.examples).toEqual([ "postgresql", "mysql", "redis", diff --git a/packages/mcp-core/src/internal/formatting.ts b/packages/mcp-core/src/internal/formatting.ts index d6d77723b..14a7e9ead 100644 --- a/packages/mcp-core/src/internal/formatting.ts +++ b/packages/mcp-core/src/internal/formatting.ts @@ -1226,16 +1226,14 @@ function renderPerformanceSpanTree(spans: PerformanceSpan[]): string[] { lines.push(line); // Render children - for (let i = 0; i < span.children.length; i++) { - const child = span.children[i]; + for (const [i, child] of span.children.entries()) { const isLastChild = i === span.children.length - 1; const childPrefix = prefix + (isLast ? " " : "│ "); renderSpan(child, childPrefix, isLastChild); } } - for (let i = 0; i < spans.length; i++) { - const span = spans[i]; + for (const [i, span] of spans.entries()) { const isLastRoot = i === spans.length - 1; renderSpan(span, "", isLastRoot); } @@ -1418,7 +1416,7 @@ function formatN1QueryEvidence( // Show the query pattern - if single line, render as SQL block; if multiple, as list if (repeatingLines.length === 1) { - parts.push(codeBlock(repeatingLines[0], "sql")); + parts.push(codeBlock(repeatingLines[0]!, "sql")); parts.push(""); } else { parts.push("**Repeated operations:**"); @@ -2692,7 +2690,7 @@ function buildAIConversationResponseNotes({ }); if (aiConversations.length === 1) { - const [conversation] = aiConversations; + const conversation = aiConversations[0]!; const spanSuffix = conversation.spanId ? ` Matching span: \`${conversation.spanId}\`.` : ""; diff --git a/packages/mcp-core/src/internal/tool-helpers/credential-routing.ts b/packages/mcp-core/src/internal/tool-helpers/credential-routing.ts index e054bc2d2..1e1c4b927 100644 --- a/packages/mcp-core/src/internal/tool-helpers/credential-routing.ts +++ b/packages/mcp-core/src/internal/tool-helpers/credential-routing.ts @@ -194,7 +194,7 @@ export async function mapCredentialContexts( const results: Array<{ entry: CredentialContext; value: T }> = []; let firstError: unknown; for (const [index, result] of settled.entries()) { - const entry = entries[index]; + const entry = entries[index]!; if (result.status === "fulfilled") { results.push({ entry, value: result.value }); continue; diff --git a/packages/mcp-core/src/internal/tool-helpers/default-organization.test.ts b/packages/mcp-core/src/internal/tool-helpers/default-organization.test.ts index 7d8d11ecc..a8a995bbc 100644 --- a/packages/mcp-core/src/internal/tool-helpers/default-organization.test.ts +++ b/packages/mcp-core/src/internal/tool-helpers/default-organization.test.ts @@ -88,8 +88,8 @@ describe("applyDefaultOrganization", () => { requiredOrgTool, getServerContext(), ); - expect(unscoped.organizationSlug.safeParse(undefined).success).toBe(true); - expect(unscoped.organizationSlug.safeParse("").success).toBe(false); + expect(unscoped.organizationSlug?.safeParse(undefined).success).toBe(true); + expect(unscoped.organizationSlug?.safeParse("").success).toBe(false); const scoped = getFilteredInputSchema( requiredOrgTool, @@ -282,7 +282,7 @@ describe("applyDefaultOrganization", () => { const context = getServerContext({ sentryHost: "sentry.io", credentialRouter: { - resolve: async () => credentials[0], + resolve: async () => credentials[0]!, list: async () => credentials, }, }); @@ -317,7 +317,7 @@ describe("applyDefaultOrganization", () => { { id: "personal", accessToken: "personal-token" }, ]; const credentialRouter: CredentialRouter = { - resolve: async () => credentials[0], + resolve: async () => credentials[0]!, list: async () => credentials, }; const context = getServerContext({ diff --git a/packages/mcp-core/src/internal/tool-helpers/seer.ts b/packages/mcp-core/src/internal/tool-helpers/seer.ts index f7cc0d7e9..ad7fb7b53 100644 --- a/packages/mcp-core/src/internal/tool-helpers/seer.ts +++ b/packages/mcp-core/src/internal/tool-helpers/seer.ts @@ -339,8 +339,8 @@ export function getAutofixArtifactSummaries(autofix: AutofixRun): { * a run is processing. */ export function getActiveAutofixTodo(autofix: AutofixRun): string | null { - for (let i = autofix.blocks.length - 1; i >= 0; i--) { - const todos = autofix.blocks[i].todos; + for (const block of autofix.blocks.toReversed()) { + const todos = block.todos; if (!todos?.length) { continue; } diff --git a/packages/mcp-core/src/internal/url-helpers.ts b/packages/mcp-core/src/internal/url-helpers.ts index c95f4249e..6b5a64725 100644 --- a/packages/mcp-core/src/internal/url-helpers.ts +++ b/packages/mcp-core/src/internal/url-helpers.ts @@ -174,12 +174,14 @@ function extractOrganizationSlug(parsedUrl: URL, pathParts: string[]): string { "insights", "preprod", ]; + const [firstPathPart, secondPathPart] = pathParts; if ( - pathParts.length > 1 && - !knownSegments.includes(pathParts[0]) && - knownSegments.includes(pathParts[1]) + firstPathPart !== undefined && + secondPathPart !== undefined && + !knownSegments.includes(firstPathPart) && + knownSegments.includes(secondPathPart) ) { - return pathParts[0]; + return firstPathPart; } // Check for subdomain (e.g., my-org.sentry.io) @@ -188,8 +190,13 @@ function extractOrganizationSlug(parsedUrl: URL, pathParts: string[]): string { const regionPrefixes = ["us", "eu", "de", "www"]; // Non-region subdomain (e.g., my-org.sentry.io or sentry.mycompany.com) - if (hostParts.length >= 2 && !regionPrefixes.includes(hostParts[0])) { - return hostParts[0]; + const [subdomain] = hostParts; + if ( + subdomain !== undefined && + hostParts.length >= 2 && + !regionPrefixes.includes(subdomain) + ) { + return subdomain; } // If we reach here with region-prefixed URL, we couldn't determine the org diff --git a/packages/mcp-core/src/server.metadata.test.ts b/packages/mcp-core/src/server.metadata.test.ts index 0f618917f..188a8759c 100644 --- a/packages/mcp-core/src/server.metadata.test.ts +++ b/packages/mcp-core/src/server.metadata.test.ts @@ -236,7 +236,7 @@ describe("outputSchema skip lists", () => { ...Object.keys(OUTPUT_SCHEMA_EXEMPT).map((name) => ["EXEMPT", name]), ...Object.keys(OUTPUT_SCHEMA_PENDING).map((name) => ["PENDING", name]), ].flatMap(([list, name]) => { - const tools = listings(name); + const tools = listings(name!); if (tools.length === 0) { return [`${name}: in OUTPUT_SCHEMA_${list} but not listed`]; } diff --git a/packages/mcp-core/src/server.test.ts b/packages/mcp-core/src/server.test.ts index ce97146c1..e53a5dbf7 100644 --- a/packages/mcp-core/src/server.test.ts +++ b/packages/mcp-core/src/server.test.ts @@ -456,7 +456,7 @@ describe("buildServer", () => { await callRegisteredTool(server, "boom_tool", {}); expect(onError).toHaveBeenCalledTimes(1); - expect(onError.mock.calls[0][0]).toBeInstanceOf(UserInputError); + expect(onError.mock.calls[0]?.[0]).toBeInstanceOf(UserInputError); }); it("invokes onError when a tool fails via execute_sentry_tool", async () => { @@ -478,7 +478,7 @@ describe("buildServer", () => { }); expect(onError).toHaveBeenCalledTimes(1); - expect(onError.mock.calls[0][0]).toBeInstanceOf(UserInputError); + expect(onError.mock.calls[0]?.[0]).toBeInstanceOf(UserInputError); }); }); @@ -507,7 +507,7 @@ describe("buildServer", () => { expect(registeredTools.v2_tool).toBeDefined(); await expect( - registeredTools.v2_tool.handler({ value: "ok" }), + registeredTools.v2_tool?.handler({ value: "ok" }), ).resolves.toMatchObject({ content: [{ type: "text", text: "v2:ok" }], }); @@ -761,7 +761,7 @@ describe("buildServer", () => { } )._registeredTools; - await registeredTools.example_tool.handler({}, {}); + await registeredTools.example_tool!.handler({}, {}); expect(setUser).toHaveBeenCalledWith({ id: "user-123", @@ -784,7 +784,7 @@ describe("buildServer", () => { it("advertises the schema to experimental sessions", async () => { const [tool] = await listRegisteredTools(createServer(true)); - expect(tool.outputSchema).toMatchObject({ + expect(tool?.outputSchema).toMatchObject({ type: "object", properties: { status: { type: "string" } }, }); @@ -792,7 +792,7 @@ describe("buildServer", () => { it("keeps it from stable sessions, which still get markdown", async () => { const [tool] = await listRegisteredTools(createServer(false)); - expect(tool.outputSchema).toBeUndefined(); + expect(tool!.outputSchema).toBeUndefined(); }); }); @@ -1125,12 +1125,12 @@ describe("buildServer", () => { }), ); expect( - dynamicDescription.mock.calls[0][0].availableToolNames?.has( + dynamicDescription.mock.calls[0]?.[0].availableToolNames?.has( "dynamic_tool", ), ).toBe(true); expect( - dynamicDescription.mock.calls[0][0].directToolNames?.has( + dynamicDescription.mock.calls[0]?.[0].directToolNames?.has( "dynamic_tool", ), ).toBe(true); @@ -1556,8 +1556,8 @@ describe("buildServer", () => { ); expect(getTextContent(result)).not.toContain("# Tool Search Results"); expect(getTextContent(result)).not.toContain("```json"); - expect(firstResult.name).toBe("get_replay_details"); - expect(Object.keys(firstResult).sort()).toEqual([ + expect(firstResult?.name).toBe("get_replay_details"); + expect(Object.keys(firstResult!).sort()).toEqual([ "annotations", "description", "inputSchema", @@ -1566,7 +1566,7 @@ describe("buildServer", () => { expect(firstResult).not.toHaveProperty("requiredSkills"); expect(firstResult).not.toHaveProperty("requiredScopes"); expect(firstResult).not.toHaveProperty("skills"); - expect(firstResult.inputSchema.properties).not.toHaveProperty( + expect(firstResult!.inputSchema.properties).not.toHaveProperty( "organizationSlug", ); }); @@ -3080,9 +3080,9 @@ describe("buildServer", () => { expect.any(Function), ); const span = startedSpans[0]; - expect(span.setStatus).toHaveBeenCalledWith({ code: 2 }); + expect(span?.setStatus).toHaveBeenCalledWith({ code: 2 }); // Expected validation failures mark the span failed without recording an exception. - expect(span.recordException).not.toHaveBeenCalled(); + expect(span!.recordException).not.toHaveBeenCalled(); }); it("execute_sentry_tool injects constrained arguments for catalog-only tools", async () => { @@ -3165,9 +3165,9 @@ describe("buildServer", () => { }>(result); const replayTool = payload.results[0]; - expect(replayTool.name).toBe("get_replay_details"); + expect(replayTool?.name).toBe("get_replay_details"); expect( - Object.keys(replayTool.inputSchema.properties ?? {}).sort(), + Object.keys(replayTool?.inputSchema.properties ?? {}).sort(), ).toEqual([ "categories", "endOffsetSeconds", diff --git a/packages/mcp-core/src/telem/logging.test.ts b/packages/mcp-core/src/telem/logging.test.ts index 1a5362e24..ca2a3b234 100644 --- a/packages/mcp-core/src/telem/logging.test.ts +++ b/packages/mcp-core/src/telem/logging.test.ts @@ -23,7 +23,7 @@ describe("logging", () => { expect(info).not.toHaveBeenCalled(); expect(error).toHaveBeenCalledTimes(1); - const [payload] = error.mock.calls[0]; + const [payload] = error.mock.calls[0]!; expect(typeof payload).toBe("string"); expect(JSON.parse(payload as string)).toMatchObject({ level: "INFO", @@ -54,7 +54,7 @@ describe("logging", () => { }); expect(error).toHaveBeenCalledTimes(1); - const [payload] = error.mock.calls[0]; + const [payload] = error.mock.calls[0]!; expect(JSON.parse(payload as string)).toMatchObject({ level: "ERROR", message: "issue failed", diff --git a/packages/mcp-core/src/telem/sentry.test.ts b/packages/mcp-core/src/telem/sentry.test.ts index 8d5e636c1..746316332 100644 --- a/packages/mcp-core/src/telem/sentry.test.ts +++ b/packages/mcp-core/src/telem/sentry.test.ts @@ -100,10 +100,10 @@ describe("sentry", () => { }; const result = sentryBeforeSend(event, {}) as SentryEvent; - expect(result.breadcrumbs?.[0].message).toBe( + expect(result.breadcrumbs?.[0]?.message).toBe( "API call with [REDACTED_OPENAI_KEY]", ); - expect(result.breadcrumbs?.[0].data?.tokens).toEqual([ + expect(result.breadcrumbs?.[0]?.data?.tokens).toEqual([ "[REDACTED_SENTRY_TOKEN]", "[REDACTED_SENTRY_TOKEN]", ]); @@ -126,7 +126,7 @@ describe("sentry", () => { }; const result = sentryBeforeSend(event, {}) as SentryEvent; - expect(result.exception?.values?.[0].value).toBe( + expect(result.exception?.values?.[0]?.value).toBe( "Failed to authenticate with [REDACTED_OPENAI_KEY]", ); }); diff --git a/packages/mcp-core/src/tools/catalog/create-metric-monitor.test.ts b/packages/mcp-core/src/tools/catalog/create-metric-monitor.test.ts index 543af587a..6a6754885 100644 --- a/packages/mcp-core/src/tools/catalog/create-metric-monitor.test.ts +++ b/packages/mcp-core/src/tools/catalog/create-metric-monitor.test.ts @@ -58,7 +58,7 @@ function create(changes: Record = {}) { function savedMonitor(body: MetricMonitorCreate) { const source = structuredClone(metricMonitor.dataSources[0]); - Object.assign(source.queryObj.snubaQuery, body.dataSources[0]); + Object.assign(source!.queryObj.snubaQuery, body.dataSources[0]); return { ...metricMonitor, ...body, diff --git a/packages/mcp-core/src/tools/catalog/create-project.ts b/packages/mcp-core/src/tools/catalog/create-project.ts index 04576db88..ef86fe598 100644 --- a/packages/mcp-core/src/tools/catalog/create-project.ts +++ b/packages/mcp-core/src/tools/catalog/create-project.ts @@ -76,7 +76,7 @@ function findRepositoryMatch( ); } - return matches[0]; + return matches[0]!; } function getRepositoryProvider(repository: RepositoryMatch): string | null { diff --git a/packages/mcp-core/src/tools/catalog/find-alert-rules.test.ts b/packages/mcp-core/src/tools/catalog/find-alert-rules.test.ts index db65ae7c5..a81d49b68 100644 --- a/packages/mcp-core/src/tools/catalog/find-alert-rules.test.ts +++ b/packages/mcp-core/src/tools/catalog/find-alert-rules.test.ts @@ -103,7 +103,7 @@ describe("find_alert_rules", () => { expect(issueParams.get("projectSlug")).toBe("cloudflare-mcp"); expect(issueParams.get("query")).toBe('name:"*backend*"'); expect(metricRequestUrls).toHaveLength(1); - const metricParams = new URL(metricRequestUrls[0]).searchParams; + const metricParams = new URL(metricRequestUrls[0]!).searchParams; expect(metricParams.get("project")).toBe(project.id); expect(metricParams.get("query")).toBe('name:"*backend*"'); expect(metricParams.getAll("type")).toEqual(["metric_issue"]); @@ -235,8 +235,8 @@ describe("find_alert_rules", () => { ); expect(requests).toHaveLength(1); - expect(requests[0].searchParams.get("projectSlug")).toBeNull(); - expect(requests[0].searchParams.get("cursor")).toBe("workflow-page-1"); + expect(requests[0]!.searchParams.get("projectSlug")).toBeNull(); + expect(requests[0]?.searchParams.get("cursor")).toBe("workflow-page-1"); expect(getStructuredContent(result)).toMatchObject({ issueRules: [{ id: "123" }], pagination: { issue: { nextCursor: "workflow-page-2" }, metric: null }, diff --git a/packages/mcp-core/src/tools/catalog/find-dashboards.test.ts b/packages/mcp-core/src/tools/catalog/find-dashboards.test.ts index 45dfae290..fe8d67054 100644 --- a/packages/mcp-core/src/tools/catalog/find-dashboards.test.ts +++ b/packages/mcp-core/src/tools/catalog/find-dashboards.test.ts @@ -233,9 +233,9 @@ describe("find_dashboards", () => { ); expect(requestUrls).toHaveLength(2); - expect(new URL(requestUrls[0]).searchParams.get("per_page")).toBe("2"); - expect(new URL(requestUrls[1]).searchParams.get("cursor")).toBe("page-2"); - expect(new URL(requestUrls[1]).searchParams.get("per_page")).toBe("2"); + expect(new URL(requestUrls[0]!).searchParams.get("per_page")).toBe("2"); + expect(new URL(requestUrls[1]!).searchParams.get("cursor")).toBe("page-2"); + expect(new URL(requestUrls[1]!).searchParams.get("per_page")).toBe("2"); assertStructuredOnlyResult(result); const structuredContent = findDashboardsOutputSchema.parse( getStructuredContent(result), @@ -363,8 +363,8 @@ describe("find_dashboards", () => { projectConstrainedContext, ); - expect(new URL(requestUrls[2]).searchParams.get("cursor")).toBe("page-2"); - expect(new URL(requestUrls[2]).searchParams.get("per_page")).toBe("2"); + expect(new URL(requestUrls[2]!).searchParams.get("cursor")).toBe("page-2"); + expect(new URL(requestUrls[2]!).searchParams.get("per_page")).toBe("2"); assertStructuredOnlyResult(secondResult); expect(getStructuredContent(secondResult)).toMatchObject({ dashboards: [{ id: "304", title: "Cloudflare Throughput" }], diff --git a/packages/mcp-core/src/tools/catalog/find-dropped-events.ts b/packages/mcp-core/src/tools/catalog/find-dropped-events.ts index 9dee10150..e775ab6cf 100644 --- a/packages/mcp-core/src/tools/catalog/find-dropped-events.ts +++ b/packages/mcp-core/src/tools/catalog/find-dropped-events.ts @@ -39,7 +39,7 @@ function isSupportedInterval(value: string): boolean { if (!match) { return false; } - const seconds = Number(match[1]) * INTERVAL_UNIT_SECONDS[match[2]]; + const seconds = Number(match[1]) * INTERVAL_UNIT_SECONDS[match[2]!]!; return seconds > 0 && seconds % 60 === 0 && ONE_DAY_SECONDS % seconds === 0; } diff --git a/packages/mcp-core/src/tools/catalog/get-agent-conversation-details.test.ts b/packages/mcp-core/src/tools/catalog/get-agent-conversation-details.test.ts index 33f8d7785..67ef1dc2c 100644 --- a/packages/mcp-core/src/tools/catalog/get-agent-conversation-details.test.ts +++ b/packages/mcp-core/src/tools/catalog/get-agent-conversation-details.test.ts @@ -152,7 +152,7 @@ describe("get_agent_conversation_details", () => { expect(structuredContent).not.toHaveProperty("messages"); expect(structuredContent).not.toHaveProperty("spanIds"); expect(structuredContent.title).toBe("Checkout worker timeouts"); - expect(structuredContent.timeline[0].genAi).toMatchObject({ + expect(structuredContent.timeline[0]?.genAi).toMatchObject({ operationType: "ai_client", requestModel: "gpt-5-mini", responseModel: "gpt-5-mini-2026-05-01", @@ -160,14 +160,16 @@ describe("get_agent_conversation_details", () => { costTotalTokens: 42, agentName: "triage-agent", }); - expect(structuredContent.timeline[2].genAi).toMatchObject({ + expect(structuredContent.timeline[2]?.genAi).toMatchObject({ operationType: "tool", }); - expect(structuredContent.timeline[2].genAi).not.toHaveProperty("toolName"); - expect(structuredContent.timeline[2].genAi).not.toHaveProperty( + expect(structuredContent.timeline[2]!.genAi).not.toHaveProperty("toolName"); + expect(structuredContent.timeline[2]!.genAi).not.toHaveProperty( "toolCallArguments", ); - expect(structuredContent.timeline[2].genAi).not.toHaveProperty("toolInput"); + expect(structuredContent.timeline[2]!.genAi).not.toHaveProperty( + "toolInput", + ); expect(structuredContent.spanSummaries[0]).toMatchObject({ spanId: "1111111111111111", spanOp: "gen_ai.chat", diff --git a/packages/mcp-core/src/tools/catalog/get-agent-conversation-details.ts b/packages/mcp-core/src/tools/catalog/get-agent-conversation-details.ts index 9b45fd470..3a78de973 100644 --- a/packages/mcp-core/src/tools/catalog/get-agent-conversation-details.ts +++ b/packages/mcp-core/src/tools/catalog/get-agent-conversation-details.ts @@ -563,7 +563,7 @@ function buildMessageEvents(span: AIConversationSpan): ConversationMessage[] { }); } else if (events.length > 0) { events[events.length - 1] = { - ...events[events.length - 1], + ...events[events.length - 1]!, metadata, genAi, }; diff --git a/packages/mcp-core/src/tools/catalog/get-alert-rule.test.ts b/packages/mcp-core/src/tools/catalog/get-alert-rule.test.ts index 524ad61ea..09b24b5e0 100644 --- a/packages/mcp-core/src/tools/catalog/get-alert-rule.test.ts +++ b/packages/mcp-core/src/tools/catalog/get-alert-rule.test.ts @@ -528,7 +528,7 @@ describe("get_alert_rule", () => { id: `condition-${i}`, })); const actions = Array.from({ length: 6 }, (_, i) => ({ - ...issueAlertRule.actionFilters[0].actions[0], + ...issueAlertRule.actionFilters[0]!.actions[0], id: `action-${i}`, })); const groups = Array.from({ length: 6 }, (_, i) => ({ diff --git a/packages/mcp-core/src/tools/catalog/get-alert-rule.ts b/packages/mcp-core/src/tools/catalog/get-alert-rule.ts index 4577b3a6c..06b71d794 100644 --- a/packages/mcp-core/src/tools/catalog/get-alert-rule.ts +++ b/packages/mcp-core/src/tools/catalog/get-alert-rule.ts @@ -183,7 +183,7 @@ export default defineTool({ `Multiple alert rules named "${params.ruleIdOrName}" were found: ${matches.map(describeMatch).join(", ")}. Retry with the Alert ID and kind=issue, or use get_metric_monitor_details with the monitor ID. ${LIST_HINT}`, ); } - const [found] = matches; + const found = matches[0]!; match = found.kind === "issue" ? { diff --git a/packages/mcp-core/src/tools/catalog/get-dashboard-details.test.ts b/packages/mcp-core/src/tools/catalog/get-dashboard-details.test.ts index 8bac21783..6f708e35b 100644 --- a/packages/mcp-core/src/tools/catalog/get-dashboard-details.test.ts +++ b/packages/mcp-core/src/tools/catalog/get-dashboard-details.test.ts @@ -391,7 +391,7 @@ describe("get_dashboard_details", () => { context, ), ); - return dashboard.widgets[0].queries[0]; + return dashboard.widgets[0]!.queries[0]; } it("describes saved transformations by aggregate position", async () => { @@ -405,7 +405,7 @@ describe("get_dashboard_details", () => { }, }); - expect((await getFirstQuery()).transformations).toMatchInlineSnapshot(` + expect((await getFirstQuery())?.transformations).toMatchInlineSnapshot(` [ { "aggregate": "count()", @@ -441,7 +441,7 @@ describe("get_dashboard_details", () => { transformations: { "3": ["fill(linear)"] }, }); - expect((await getFirstQuery()).transformations).toEqual([ + expect((await getFirstQuery())?.transformations).toEqual([ { aggregateIndex: 3, aggregate: null, @@ -472,7 +472,7 @@ describe("get_dashboard_details", () => { ), ); - expect((await getFirstQuery()).transformations).toBeNull(); + expect((await getFirstQuery())!.transformations).toBeNull(); }); it("accepts widgets whose display type is null", async () => { diff --git a/packages/mcp-core/src/tools/catalog/get-issue-activity.test.ts b/packages/mcp-core/src/tools/catalog/get-issue-activity.test.ts index 915729be8..d27991d78 100644 --- a/packages/mcp-core/src/tools/catalog/get-issue-activity.test.ts +++ b/packages/mcp-core/src/tools/catalog/get-issue-activity.test.ts @@ -454,12 +454,12 @@ describe("get_issue_activity", () => { deletedPr, blankCommit, ] = activity; - expect(unmerge.unmerge).toEqual({ + expect(unmerge?.unmerge).toEqual({ fingerprintCount: 2, source: { shortId: "CLOUDFLARE-MCP-42" }, destination: null, }); - expect(Object.keys(resolved).sort()).toEqual([ + expect(Object.keys(resolved!).sort()).toEqual([ "author", "commentId", "dateCreated", @@ -467,18 +467,18 @@ describe("get_issue_activity", () => { "text", "type", ]); - expect(rca.text).toBe("Null org slug reaches the API client."); - expect(seerPr.pullRequestUrls).toEqual([ + expect(rca?.text).toBe("Null org slug reaches the API client."); + expect(seerPr?.pullRequestUrls).toEqual([ "https://github.com/getsentry/sentry-mcp/pull/7", ]); - expect(createIssue.externalIssue).toEqual({ + expect(createIssue?.externalIssue).toEqual({ title: "Fix null org", provider: "Jira", location: "https://example.atlassian.net/browse/ENG-1", }); - expect(resolvedByAge.age).toBe(720); - expect(deletedPr.pullRequest).toBeNull(); - expect(blankCommit.commit).toMatchObject({ id: "abc123", message: null }); + expect(resolvedByAge?.age).toBe(720); + expect(deletedPr!.pullRequest).toBeNull(); + expect(blankCommit?.commit).toMatchObject({ id: "abc123", message: null }); const serialized = JSON.stringify(structuredContent); for (const leaked of [ @@ -514,7 +514,7 @@ describe("get_issue_activity", () => { const [assigned] = getStructuredContent<{ activity: Array<{ assignee?: { name: string | null } }>; }>(result).activity; - expect(assigned.assignee).toEqual({ + expect(assigned?.assignee).toEqual({ id: "43", type: "user", name: "jane@corp.com", diff --git a/packages/mcp-core/src/tools/catalog/get-issue-breadcrumbs.test.ts b/packages/mcp-core/src/tools/catalog/get-issue-breadcrumbs.test.ts index 71adbc2de..6ae2477cf 100644 --- a/packages/mcp-core/src/tools/catalog/get-issue-breadcrumbs.test.ts +++ b/packages/mcp-core/src/tools/catalog/get-issue-breadcrumbs.test.ts @@ -223,7 +223,7 @@ describe("get_issue_breadcrumbs", () => { ); const [crumb] = getStructuredContent(result).breadcrumbs; - expect(Object.keys(crumb).sort()).toEqual([ + expect(Object.keys(crumb!).sort()).toEqual([ "category", "data", "level", @@ -237,9 +237,9 @@ describe("get_issue_breadcrumbs", () => { category: null, type: "default", }); - expect(crumb.message).toMatch(/^line one line two x+\.\.\.$/); - expect((crumb.message as string).length).toBe(123); - expect((crumb.data as string).length).toBe(203); + expect(crumb?.message).toMatch(/^line one line two x+\.\.\.$/); + expect((crumb!.message as string).length).toBe(123); + expect((crumb!.data as string).length).toBe(203); expect(JSON.stringify(crumb)).not.toContain("must-not-leak"); }); }); diff --git a/packages/mcp-core/src/tools/catalog/get-issue-details.test.ts b/packages/mcp-core/src/tools/catalog/get-issue-details.test.ts index c756e4a0c..b8b7ac4d4 100644 --- a/packages/mcp-core/src/tools/catalog/get-issue-details.test.ts +++ b/packages/mcp-core/src/tools/catalog/get-issue-details.test.ts @@ -997,7 +997,7 @@ describe("get_issue_details", () => { const performanceSection = result .slice(result.indexOf("### Repeated Database Queries")) - .split("### Tags")[0] + .split("### Tags")[0]! .trim(); expect(performanceSection).toMatchInlineSnapshot(` @@ -1087,7 +1087,7 @@ describe("get_issue_details", () => { const performanceSection = result .slice(result.indexOf("### Repeated Database Queries")) - .split("### Tags")[0] + .split("### Tags")[0]! .trim(); expect(performanceSection).toMatchInlineSnapshot(` diff --git a/packages/mcp-core/src/tools/catalog/get-snapshot-image.test.ts b/packages/mcp-core/src/tools/catalog/get-snapshot-image.test.ts index 7bcbd9464..ab45632ca 100644 --- a/packages/mcp-core/src/tools/catalog/get-snapshot-image.test.ts +++ b/packages/mcp-core/src/tools/catalog/get-snapshot-image.test.ts @@ -150,21 +150,21 @@ describe("get_snapshot_image", () => { const result = await callHandler(); const { textParts, imageParts } = splitParts(result); - expect(textParts[0].text).toContain("## login_screen.png"); - expect(textParts[0].text).toContain( + expect(textParts[0]?.text).toContain("## login_screen.png"); + expect(textParts[0]?.text).toContain( "- **URL**: https://sentry.sentry.io/preprod/snapshots/231949/?selectedSnapshot=login_screen.png", ); - expect(textParts[0].text).toContain("**Status**: changed"); - expect(textParts[0].text).toContain("**Diff**: 12.5%"); - expect(textParts[0].text).toContain("**Image Resolution**: preview"); - expect(textParts[0].text).toContain( + expect(textParts[0]?.text).toContain("**Status**: changed"); + expect(textParts[0]?.text).toContain("**Diff**: 12.5%"); + expect(textParts[0]?.text).toContain("**Image Resolution**: preview"); + expect(textParts[0]?.text).toContain( "Use the Sentry tool `get_snapshot_image` for full-resolution image bytes", ); - expect(textParts[0].text).toContain("### Context"); - expect(textParts[0].text).toContain("- **device_name**: iPhone 16"); - expect(textParts[1].text).toBe("### Head (current) — preview"); - expect(textParts[2].text).toBe("### Base (previous) — preview"); - expect(textParts[3].text).toBe("### Diff Mask — preview"); + expect(textParts[0]?.text).toContain("### Context"); + expect(textParts[0]?.text).toContain("- **device_name**: iPhone 16"); + expect(textParts[1]?.text).toBe("### Head (current) — preview"); + expect(textParts[2]?.text).toBe("### Base (previous) — preview"); + expect(textParts[3]?.text).toBe("### Diff Mask — preview"); expect(textParts.map((part) => part.text)).toMatchInlineSnapshot(` [ "## login_screen.png @@ -190,8 +190,8 @@ describe("get_snapshot_image", () => { ] `); expect(imageParts).toHaveLength(3); - expect(imageParts[0].mimeType).toBe("image/png"); - expect(imageParts[1].mimeType).toBe("image/png"); + expect(imageParts[0]?.mimeType).toBe("image/png"); + expect(imageParts[1]?.mimeType).toBe("image/png"); }); it("downsamples 16-bit PNGs in preview responses", async () => { @@ -219,14 +219,14 @@ describe("get_snapshot_image", () => { const result = await callHandler(); const { textParts, imageParts } = splitParts(result); - expect(textParts[1].text).toBe("### Head (current) — preview"); + expect(textParts[1]?.text).toBe("### Head (current) — preview"); expect(imageParts).toHaveLength(1); - expect(imageParts[0].mimeType).toBe("image/png"); - expect(imageParts[0].data).not.toBe( + expect(imageParts[0]?.mimeType).toBe("image/png"); + expect(imageParts[0]!.data).not.toBe( Buffer.from(largeSixteenBitPng).toString("base64"), ); - const decoded = decodePng(Buffer.from(imageParts[0].data, "base64")); + const decoded = decodePng(Buffer.from(imageParts[0]!.data, "base64")); expect(decoded.width).toBe(1024); expect(decoded.height).toBe(512); expect(decoded.depth).toBe(8); @@ -240,10 +240,10 @@ describe("get_snapshot_image", () => { }); const { textParts, imageParts } = splitParts(result); - expect(textParts[0].text).toContain("**Image Resolution**: full"); - expect(textParts[1].text).toBe("### Head (current) — full"); - expect(imageParts[0].data).toBe(Buffer.from(fakePng).toString("base64")); - expect(imageParts[1].data).toBe(Buffer.from(fakePng).toString("base64")); + expect(textParts[0]?.text).toContain("**Image Resolution**: full"); + expect(textParts[1]?.text).toBe("### Head (current) — full"); + expect(imageParts[0]?.data).toBe(Buffer.from(fakePng).toString("base64")); + expect(imageParts[1]?.data).toBe(Buffer.from(fakePng).toString("base64")); }); it("throws on missing explicit snapshot params", async () => { @@ -294,7 +294,7 @@ describe("get_snapshot_image", () => { const result = await callHandler(); const { textParts, imageParts } = splitParts(result); - expect(textParts[1].text).toBe( + expect(textParts[1]?.text).toBe( "### Head (current) — preview unavailable. Retry with imageResolution=full to fetch the original image.", ); expect(imageParts).toHaveLength(0); @@ -332,8 +332,8 @@ describe("get_snapshot_image", () => { }); const { textParts } = splitParts(result); - expect(textParts[0].text).toContain(`## ${slashImageIdentifier}`); - expect(textParts[0].text).toContain( + expect(textParts[0]?.text).toContain(`## ${slashImageIdentifier}`); + expect(textParts[0]?.text).toContain( `- **File**: \`${slashImageIdentifier}\``, ); }); @@ -344,7 +344,7 @@ describe("get_snapshot_image", () => { const result = await callHandler(); const { imageParts } = splitParts(result); - expect(imageParts[0].mimeType).toBe("image/png"); + expect(imageParts[0]?.mimeType).toBe("image/png"); }); it("throws when no image data is available", async () => { diff --git a/packages/mcp-core/src/tools/catalog/get-trace-details.ts b/packages/mcp-core/src/tools/catalog/get-trace-details.ts index fd9f7ec63..eb59da6e3 100644 --- a/packages/mcp-core/src/tools/catalog/get-trace-details.ts +++ b/packages/mcp-core/src/tools/catalog/get-trace-details.ts @@ -285,8 +285,8 @@ function selectInterestingSpans( break; } - fakeRoot.children.push(createSelectedSpan(root, 0)); - const selectedRoot = fakeRoot.children[fakeRoot.children.length - 1]; + const selectedRoot = createSelectedSpan(root, 0); + fakeRoot.children.push(selectedRoot); spanCount += 1; enqueueSelectedChildren( root, @@ -545,16 +545,14 @@ function renderSpanTree(spans: SelectedSpan[]): string[] { } // Render children with proper tree indentation - for (let i = 0; i < span.children.length; i++) { - const child = span.children[i]; + for (const [i, child] of span.children.entries()) { const isLastChild = i === span.children.length - 1; const childPrefix = prefix + (isLast ? " " : "│ "); renderSpan(child, childPrefix, isLastChild); } } - for (let i = 0; i < spans.length; i++) { - const span = spans[i]; + for (const [i, span] of spans.entries()) { const isLastRoot = i === spans.length - 1; renderSpan(span, "", isLastRoot); } @@ -607,7 +605,7 @@ function calculateOperationStats(trace: Trace): Record< // Only consider leaf nodes - spans that have no children if (span.children.length === 0) { // Use span.op if available, otherwise extract from span.name, fallback to "unknown" - const op = span.op || (span.name ? span.name.split(" ")[0] : "unknown"); + const op = span.op || (span.name ? span.name.split(" ")[0]! : "unknown"); const bucket = operationSpans.get(op); if (bucket) { bucket.push(span); @@ -1205,7 +1203,7 @@ function formatAIConversationSection({ const lines = ["## Agent Conversations", ""]; if (aiConversations.length === 1) { - const [conversation] = aiConversations; + const conversation = aiConversations[0]!; lines.push(`**Conversation ID**: \`${conversation.conversationId}\``); if (conversation.spanId) { lines.push(`**Matching Span**: \`${conversation.spanId}\``); diff --git a/packages/mcp-core/src/tools/catalog/search-agent-conversations.test.ts b/packages/mcp-core/src/tools/catalog/search-agent-conversations.test.ts index 425d66db6..b46606e1d 100644 --- a/packages/mcp-core/src/tools/catalog/search-agent-conversations.test.ts +++ b/packages/mcp-core/src/tools/catalog/search-agent-conversations.test.ts @@ -201,11 +201,11 @@ describe("search_agent_conversations", () => { }>(result); const conversation = structuredContent.conversations[0]; - expect(conversation.firstInputPreview).toHaveLength(240); - expect(conversation.firstInputPreview?.endsWith("...")).toBe(true); - expect(conversation.lastOutputPreview).toHaveLength(240); - expect(conversation.lastOutputPreview?.endsWith("...")).toBe(true); - expect(conversation.sampleTraceIds).toEqual([ + expect(conversation?.firstInputPreview).toHaveLength(240); + expect(conversation?.firstInputPreview?.endsWith("...")).toBe(true); + expect(conversation?.lastOutputPreview).toHaveLength(240); + expect(conversation?.lastOutputPreview?.endsWith("...")).toBe(true); + expect(conversation?.sampleTraceIds).toEqual([ "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb", "cccccccccccccccccccccccccccccccc", @@ -315,7 +315,7 @@ describe("search_agent_conversations", () => { getServerContext(), ); - const params = new URL(requestUrls[0]).searchParams; + const params = new URL(requestUrls[0]!).searchParams; expect(params.get("query")).toBe("failed"); expect(params.get("sort")).toBe(null); expect(params.getAll("project")).toEqual(["4509109107622913"]); diff --git a/packages/mcp-core/src/tools/catalog/search-issue-events.test.ts b/packages/mcp-core/src/tools/catalog/search-issue-events.test.ts index 4f6a0f4bb..46cae9107 100644 --- a/packages/mcp-core/src/tools/catalog/search-issue-events.test.ts +++ b/packages/mcp-core/src/tools/catalog/search-issue-events.test.ts @@ -515,8 +515,8 @@ describe("search_issue_events", () => { ); const [emptyUser, emptyGeo] = sc(result).events; - expect(emptyUser.user).toBeNull(); - expect(emptyGeo.user).toEqual({ + expect(emptyUser!.user).toBeNull(); + expect(emptyGeo?.user).toEqual({ id: "user-1", email: null, username: null, diff --git a/packages/mcp-core/src/tools/catalog/search-replays.structured.test.ts b/packages/mcp-core/src/tools/catalog/search-replays.structured.test.ts index 2a9fc1d1c..4c55fd7de 100644 --- a/packages/mcp-core/src/tools/catalog/search-replays.structured.test.ts +++ b/packages/mcp-core/src/tools/catalog/search-replays.structured.test.ts @@ -184,12 +184,12 @@ describe("search_replays structured output", () => { const structuredContent = await runSearch({ query: "count_errors:>0" }); const [replay] = structuredContent.replays; - expect(replay.urls).toHaveLength(3); - expect(replay.urlCount).toBe(8); - expect(replay.traceIds).toHaveLength(3); - expect(replay.traceCount).toBe(7); - expect(replay.releases).toHaveLength(3); - expect(replay.releaseCount).toBe(5); + expect(replay?.urls).toHaveLength(3); + expect(replay?.urlCount).toBe(8); + expect(replay?.traceIds).toHaveLength(3); + expect(replay?.traceCount).toBe(7); + expect(replay?.releases).toHaveLength(3); + expect(replay?.releaseCount).toBe(5); }); it("omits the placeholder user on archived replays", async () => { @@ -204,8 +204,8 @@ describe("search_replays structured output", () => { const structuredContent = await runSearch({ query: "count_errors:>0" }); const [replay] = structuredContent.replays; - expect(replay.isArchived).toBe(true); - expect(replay.user).toBeNull(); + expect(replay?.isArchived).toBe(true); + expect(replay!.user).toBeNull(); }); it("keeps the unknown-environment warning in notes", async () => { diff --git a/packages/mcp-core/src/tools/catalog/support/alerts.ts b/packages/mcp-core/src/tools/catalog/support/alerts.ts index ae467a4c1..0d6b179fa 100644 --- a/packages/mcp-core/src/tools/catalog/support/alerts.ts +++ b/packages/mcp-core/src/tools/catalog/support/alerts.ts @@ -68,7 +68,7 @@ export async function resolveIssueAlertRule( return await apiService.getIssueAlertRule({ organizationSlug: params.organizationSlug, projectSlug: params.projectSlug, - ruleId: matches[0].id, + ruleId: matches[0]!.id, }); } if (matches.length > 1) { @@ -124,7 +124,7 @@ export async function resolveMetricAlertRule( : `Metric monitor "${ruleIdOrName}" was not found. Use find_metric_monitors to find its monitor ID.`, ); } - monitorId = matches[0].id; + monitorId = matches[0]!.id; } return await getMetricMonitor(apiService, { organizationSlug, diff --git a/packages/mcp-core/src/tools/catalog/support/uptime-monitors.ts b/packages/mcp-core/src/tools/catalog/support/uptime-monitors.ts index e009e3ef9..b84dbd6d1 100644 --- a/packages/mcp-core/src/tools/catalog/support/uptime-monitors.ts +++ b/packages/mcp-core/src/tools/catalog/support/uptime-monitors.ts @@ -67,7 +67,7 @@ export const ParamUptimeHeaders = z export function toUptimeHeaderPairs( headers: string[][], ): Array<[string, string]> { - return headers.map(([name, value]) => [name, value]); + return headers.map(([name, value]) => [name!, value!]); } /** Owner actor for create/update. Empty/whitespace rejected. */ diff --git a/packages/mcp-core/src/tools/catalog/update-alert-rule.test.ts b/packages/mcp-core/src/tools/catalog/update-alert-rule.test.ts index b44d24642..d56079669 100644 --- a/packages/mcp-core/src/tools/catalog/update-alert-rule.test.ts +++ b/packages/mcp-core/src/tools/catalog/update-alert-rule.test.ts @@ -115,8 +115,8 @@ describe("update_alert_rule", () => { it("reports when Sentry saves a Slack destination without resolving its channel ID", async () => { const { writes } = useAlertRuleHandlers(); const actionFilters = structuredClone(alertRule.actionFilters); - actionFilters[0].actions[0].config.targetDisplay = "#new-channel"; - actionFilters[0].actions[0].config.targetIdentifier = ""; + actionFilters[0]!.actions[0]!.config.targetDisplay = "#new-channel"; + actionFilters[0]!.actions[0]!.config.targetIdentifier = ""; await expect(updateRule({ actionFilters })).rejects.toThrow( "The alert was saved, but Sentry did not resolve a Slack destination.", @@ -208,7 +208,7 @@ describe("update_alert_rule", () => { const actionFilters: Parameters< typeof updateAlertRule.handler >[0]["actionFilters"] = structuredClone(alertRule.actionFilters); - actionFilters[0].actions.push({ + actionFilters[0]!.actions.push({ id: "22", type: "email", integrationId: null, @@ -220,18 +220,18 @@ describe("update_alert_rule", () => { }, }); actionFilters.push({ - ...actionFilters[0], + ...actionFilters[0]!, id: "30", actions: [{ ...slackAction, id: "31" }], }); - actionFilters[0].actions[0].config = { + actionFilters[0]!.actions[0]!.config = { ...slackAction.config, targetDisplay, targetIdentifier: inputId, }; - actionFilters[0].actions[0].integrationId = integrationId; + actionFilters[0]!.actions[0]!.integrationId = integrationId; const savedFilters = structuredClone(actionFilters); - savedFilters[0].actions[0].config.targetIdentifier = "CNEW"; + savedFilters[0]!.actions[0]!.config.targetIdentifier = "CNEW"; mswServer.use( http.put(endpoint, async ({ request }) => { writes.push((await request.json()) as Record); @@ -245,7 +245,7 @@ describe("update_alert_rule", () => { const result = await updateRule({ actionFilters }); const expectedFilters = structuredClone(actionFilters); const expectedConfig: Record = - expectedFilters[0].actions[0].config; + expectedFilters[0]!.actions[0]!.config; if (expectedId === undefined) delete expectedConfig.targetIdentifier; else expectedConfig.targetIdentifier = expectedId; expect(writes).toEqual([ @@ -313,7 +313,7 @@ describe("update_alert_rule", () => { alertRule: { actionFilters: (typeof group)[] }; }>(await getAlertRule.handler({ ...params, kind: "issue" }, context)); const actionFilters = inspected.actionFilters; - actionFilters[0].actions[0].config = action.config; + actionFilters[0]!.actions[0]!.config = action.config; // Teams always resolves the supplied name, replacing even an old channel ID. const savedAction = type === "msteams" @@ -391,7 +391,7 @@ describe("update_alert_rule", () => { { ...changes.actionFilters[0], conditions: [ - { ...changes.actionFilters[0].conditions[0], comparison: 25 }, + { ...changes.actionFilters[0]!.conditions[0], comparison: 25 }, ], }, ], @@ -652,7 +652,7 @@ describe("update_alert_rule", () => { { ...context, constraints: { projectSlug: "cloudflare-mcp" } }, ); - expect(queries[0].searchParams.get("projectSlug")).toBe("cloudflare-mcp"); + expect(queries[0]?.searchParams.get("projectSlug")).toBe("cloudflare-mcp"); expect(reads).toHaveLength(1); expect(writes).toEqual([{ name: "Renamed alert", enabled: true }]); }); diff --git a/packages/mcp-core/src/tools/catalog/update-alert-rule.ts b/packages/mcp-core/src/tools/catalog/update-alert-rule.ts index bc7bfab01..9cc89f92d 100644 --- a/packages/mcp-core/src/tools/catalog/update-alert-rule.ts +++ b/packages/mcp-core/src/tools/catalog/update-alert-rule.ts @@ -191,7 +191,7 @@ export default defineTool({ `Alert rule "${ruleId}" was not found${projectSlug ? ` in project ${projectSlug}` : ""}.`, ); } - ruleId = String(matches[0].id); + ruleId = String(matches[0]!.id); } const current = await apiService.getIssueAlertRule({ organizationSlug, diff --git a/packages/mcp-core/src/tools/catalog/update-metric-monitor.test.ts b/packages/mcp-core/src/tools/catalog/update-metric-monitor.test.ts index 686423682..c4193abb6 100644 --- a/packages/mcp-core/src/tools/catalog/update-metric-monitor.test.ts +++ b/packages/mcp-core/src/tools/catalog/update-metric-monitor.test.ts @@ -189,7 +189,7 @@ describe("update_metric_monitor", () => { environment: null, }; const source = structuredClone(metricMonitor.dataSources[0]); - Object.assign(source.queryObj.snubaQuery, { + Object.assign(source!.queryObj.snubaQuery, { ...query, timeWindow: 7200, query: "release:previous", diff --git a/packages/mcp-core/src/tools/catalog/whoami.ts b/packages/mcp-core/src/tools/catalog/whoami.ts index 7de27f17d..5ec1a37b3 100644 --- a/packages/mcp-core/src/tools/catalog/whoami.ts +++ b/packages/mcp-core/src/tools/catalog/whoami.ts @@ -73,7 +73,7 @@ export default defineTool({ ) ).map(({ value }) => value) : [toUser(await apiServiceFromContext(context).getAuthenticatedUser())]; - const [user] = users; + const user = users[0]!; const constraints = context.constraints; const sessionConstraints = diff --git a/packages/mcp-core/src/tools/support/dashboards/index.ts b/packages/mcp-core/src/tools/support/dashboards/index.ts index 12f3ab729..919cb53b7 100644 --- a/packages/mcp-core/src/tools/support/dashboards/index.ts +++ b/packages/mcp-core/src/tools/support/dashboards/index.ts @@ -353,7 +353,7 @@ export async function resolveDashboardId({ } while (cursor); if (exactMatches.length === 1) { - return String(exactMatches[0].id); + return String(exactMatches[0]!.id); } if (exactMatches.length > 1) { diff --git a/packages/mcp-core/src/tools/support/event-stacktrace.ts b/packages/mcp-core/src/tools/support/event-stacktrace.ts index 5b4ce3d8c..6f7873e82 100644 --- a/packages/mcp-core/src/tools/support/event-stacktrace.ts +++ b/packages/mcp-core/src/tools/support/event-stacktrace.ts @@ -184,7 +184,7 @@ function selectSentryDefaultThread(threads: Thread[]): Thread { return ( sortedThreads.find((thread) => thread.crashed) ?? sortedThreads.find((thread) => hasFrames(thread)) ?? - sortedThreads[0] + sortedThreads[0]! ); } @@ -208,5 +208,5 @@ function selectUnique( return { kind: "ambiguous", message: ambiguousMessage }; } - return { kind: "selected", thread: matches[0] }; + return { kind: "selected", thread: matches[0]! }; } diff --git a/packages/mcp-core/src/tools/support/issue-linking/app.ts b/packages/mcp-core/src/tools/support/issue-linking/app.ts index 71fea223a..c4ab9724d 100644 --- a/packages/mcp-core/src/tools/support/issue-linking/app.ts +++ b/packages/mcp-core/src/tools/support/issue-linking/app.ts @@ -61,7 +61,7 @@ function isIssueKey(value: string, key: string): boolean { function choiceLabelKey(label: string | number): string { return String(label) .toUpperCase() - .split(/[^A-Z0-9-]+/)[0]; + .split(/[^A-Z0-9-]+/)[0]!; } function parseTarget(raw: string) { @@ -241,7 +241,7 @@ async function resolveFields( ); } if (targetKey) { - const [selectedValue, selectedLabel] = matches[0]; + const [selectedValue, selectedLabel] = matches[0]!; const valueKey = String(selectedValue).toUpperCase(); const labelKey = choiceLabelKey(selectedLabel); const identifiedChoices = choices.filter( @@ -263,7 +263,7 @@ async function resolveFields( ); } } - value = matches[0][0]; + value = matches[0]![0]; } else { value ??= search; if ( @@ -319,7 +319,7 @@ export async function linkAppIssue( ); if (installed.length !== 1) throw new UserInputError(`Expected one installed Sentry App '${appSlug}'.`); - const installation = installed[0]; + const installation = installed[0]!; const matchingComponents = components.filter( (component) => component.type === "issue-link" && diff --git a/packages/mcp-core/src/tools/support/issue-linking/index.ts b/packages/mcp-core/src/tools/support/issue-linking/index.ts index 2e8cb5ffd..aea12ddf1 100644 --- a/packages/mcp-core/src/tools/support/issue-linking/index.ts +++ b/packages/mcp-core/src/tools/support/issue-linking/index.ts @@ -86,7 +86,7 @@ function nativeIdentity( /^\/([^/]+\/[^/]+)\/(issues|pull)\/(\d+)(?:\/(files|changes|commits|checks))?$/, ); if (!match || (match[2] === "issues" && match[4])) return undefined; - return `${url.origin}/${match[1].toLowerCase()}#${match[3]}`; + return `${url.origin}/${match[1]!.toLowerCase()}#${match[3]}`; } case "gitlab": { const match = path.match(/^\/(.+?)(?:\/-)?\/issues\/(\d+)$/); @@ -262,7 +262,7 @@ export async function linkExternalIssue( `Multiple installed issue integrations match this URL. Provide integrationId to select one: ${describeIntegrations(candidates)}.`, ); } - const integration = candidates[0]; + const integration = candidates[0]!; const { issue, changed } = await apiService.linkNativeExternalIssue({ ...params, integrationId: String(integration.id), diff --git a/packages/mcp-core/src/tools/support/metric-monitor-config.ts b/packages/mcp-core/src/tools/support/metric-monitor-config.ts index c739ea10f..ada78c262 100644 --- a/packages/mcp-core/src/tools/support/metric-monitor-config.ts +++ b/packages/mcp-core/src/tools/support/metric-monitor-config.ts @@ -142,7 +142,7 @@ export function toMetricMonitorUpdate( if (status !== undefined) body.enabled = status === "active"; if (query !== undefined) { const sources = current.dataSources ?? []; - const existing = sources.length === 1 ? getMetricQuery(sources[0]) : null; + const existing = sources.length === 1 ? getMetricQuery(sources[0]!) : null; if (!existing) { throw new UserInputError( "This monitor's query is unavailable or has multiple sources; cannot safely update it.", diff --git a/packages/mcp-core/src/tools/support/profile/analyzer.test.ts b/packages/mcp-core/src/tools/support/profile/analyzer.test.ts index df379e55b..875fbbe0c 100644 --- a/packages/mcp-core/src/tools/support/profile/analyzer.test.ts +++ b/packages/mcp-core/src/tools/support/profile/analyzer.test.ts @@ -115,8 +115,8 @@ describe("analyzer", () => { expect(hotPaths).toHaveLength(2); // First path should be the one with longer duration (100ms > 60ms) - expect(hotPaths[0].duration).toBe(100_000_000); - expect(hotPaths[1].duration).toBe(60_000_000); + expect(hotPaths[0]?.duration).toBe(100_000_000); + expect(hotPaths[1]?.duration).toBe(60_000_000); }); it("calculates percentage of total correctly", () => { @@ -128,9 +128,9 @@ describe("analyzer", () => { // Total samples: 50 + 30 = 80 // First path: 50/80 = 62.5% - expect(hotPaths[0].percentOfTotal).toBeCloseTo(62.5, 1); + expect(hotPaths[0]?.percentOfTotal).toBeCloseTo(62.5, 1); // Second path: 30/80 = 37.5% - expect(hotPaths[1].percentOfTotal).toBeCloseTo(37.5, 1); + expect(hotPaths[1]?.percentOfTotal).toBeCloseTo(37.5, 1); }); it("filters to user code when focusOnUserCode is true", () => { @@ -141,9 +141,9 @@ describe("analyzer", () => { }); // User code frames should be filtered - expect(hotPaths[0].userCodeFrames).toHaveLength(2); + expect(hotPaths[0]?.userCodeFrames).toHaveLength(2); expect( - hotPaths[0].userCodeFrames.every((f) => f.frame.is_application), + hotPaths[0]?.userCodeFrames.every((f) => f.frame.is_application), ).toBe(true); }); @@ -178,9 +178,9 @@ describe("analyzer", () => { ); expect(callStack).toHaveLength(3); - expect(callStack[0].depth).toBe(0); - expect(callStack[1].depth).toBe(1); - expect(callStack[2].depth).toBe(2); + expect(callStack[0]?.depth).toBe(0); + expect(callStack[1]?.depth).toBe(1); + expect(callStack[2]?.depth).toBe(2); }); it("marks root and leaf frames correctly", () => { @@ -193,16 +193,16 @@ describe("analyzer", () => { ); // First frame is leaf (leaf-to-root order) - expect(callStack[0].isLeaf).toBe(true); - expect(callStack[0].isRoot).toBe(false); + expect(callStack[0]?.isLeaf).toBe(true); + expect(callStack[0]?.isRoot).toBe(false); // Middle frame - expect(callStack[1].isRoot).toBe(false); - expect(callStack[1].isLeaf).toBe(false); + expect(callStack[1]?.isRoot).toBe(false); + expect(callStack[1]?.isLeaf).toBe(false); // Last frame is root - expect(callStack[2].isRoot).toBe(true); - expect(callStack[2].isLeaf).toBe(false); + expect(callStack[2]?.isRoot).toBe(true); + expect(callStack[2]?.isLeaf).toBe(false); }); it("handles single-frame stacks", () => { @@ -215,8 +215,8 @@ describe("analyzer", () => { expect(callStack).toHaveLength(1); // Single frame is both root and leaf - expect(callStack[0].isRoot).toBe(true); - expect(callStack[0].isLeaf).toBe(true); + expect(callStack[0]?.isRoot).toBe(true); + expect(callStack[0]?.isLeaf).toBe(true); }); it("preserves frame index reference", () => { @@ -227,9 +227,9 @@ describe("analyzer", () => { flamegraph.shared.frame_infos, ); - expect(callStack[0].frameIndex).toBe(0); - expect(callStack[1].frameIndex).toBe(1); - expect(callStack[2].frameIndex).toBe(2); + expect(callStack[0]?.frameIndex).toBe(0); + expect(callStack[1]?.frameIndex).toBe(1); + expect(callStack[2]?.frameIndex).toBe(2); }); }); @@ -243,8 +243,8 @@ describe("analyzer", () => { expect(hotspots.length).toBeGreaterThan(0); // Should be sorted by weight (highest first) for (let i = 1; i < hotspots.length; i++) { - expect(hotspots[i - 1].frameInfo.weight).toBeGreaterThanOrEqual( - hotspots[i].frameInfo.weight, + expect(hotspots[i - 1]?.frameInfo.weight).toBeGreaterThanOrEqual( + hotspots[i]!.frameInfo.weight, ); } }); @@ -338,7 +338,7 @@ describe("analyzer", () => { const current = createMockFlamegraph(); // Make current 30% slower (comparison uses sumDuration) - current.shared.frame_infos[0].sumDuration = 208000000; // 160ms * 1.3 = 208ms + current.shared.frame_infos[0]!.sumDuration = 208000000; // 160ms * 1.3 = 208ms const comparisons = compareFrameStats(baseline, current, { focusOnUserCode: false, @@ -348,7 +348,7 @@ describe("analyzer", () => { (c) => c.changeType === "major_regression", ); expect(regressions.length).toBeGreaterThan(0); - expect(regressions[0].percentChange).toBeGreaterThan(20); + expect(regressions[0]?.percentChange).toBeGreaterThan(20); }); it("detects minor regression (10-20% slower)", () => { @@ -356,7 +356,7 @@ describe("analyzer", () => { const current = createMockFlamegraph(); // Make current 15% slower (comparison uses sumDuration) - current.shared.frame_infos[1].sumDuration = 184000000; // 160ms * 1.15 = 184ms + current.shared.frame_infos[1]!.sumDuration = 184000000; // 160ms * 1.15 = 184ms const comparisons = compareFrameStats(baseline, current, { focusOnUserCode: false, @@ -373,7 +373,7 @@ describe("analyzer", () => { const current = createMockFlamegraph(); // Make current 20% faster (comparison uses sumDuration) - current.shared.frame_infos[0].sumDuration = 128000000; // 160ms * 0.8 = 128ms + current.shared.frame_infos[0]!.sumDuration = 128000000; // 160ms * 0.8 = 128ms const comparisons = compareFrameStats(baseline, current, { focusOnUserCode: false, @@ -390,7 +390,7 @@ describe("analyzer", () => { const current = createMockFlamegraph(); // Make current 5% slower (within no_change threshold, uses sumDuration) - current.shared.frame_infos[0].sumDuration = 168000000; // 160ms * 1.05 = 168ms + current.shared.frame_infos[0]!.sumDuration = 168000000; // 160ms * 1.05 = 168ms const comparisons = compareFrameStats(baseline, current, { focusOnUserCode: false, @@ -417,8 +417,8 @@ describe("analyzer", () => { const current = createMockFlamegraph(); // Create different severity changes - current.shared.frame_infos[0].weight = 240; // major regression (+50%) - current.shared.frame_infos[1].weight = 176; // minor regression (+10%) + current.shared.frame_infos[0]!.weight = 240; // major regression (+50%) + current.shared.frame_infos[1]!.weight = 176; // minor regression (+10%) const comparisons = compareFrameStats(baseline, current, { focusOnUserCode: true, diff --git a/packages/mcp-core/src/tools/support/profile/analyzer.ts b/packages/mcp-core/src/tools/support/profile/analyzer.ts index 364ed6735..9645bc470 100644 --- a/packages/mcp-core/src/tools/support/profile/analyzer.ts +++ b/packages/mcp-core/src/tools/support/profile/analyzer.ts @@ -112,8 +112,7 @@ export function analyzeHotPathsFromFlamegraph( } >(); - for (let idx = 0; idx < profile.samples.length; idx++) { - const stackIndices = profile.samples[idx]; + for (const [idx, stackIndices] of profile.samples.entries()) { const sampleCount = profile.sample_counts[idx] || 0; const duration = profile.sample_durations_ns[idx] || 0; const weight = profile.weights[idx] || 0; @@ -357,7 +356,7 @@ export function compareFrameStats( continue; // Frame only in one dataset } - const currentFrame = currentFrames[indices.currentIdx]; + const currentFrame = currentFrames[indices.currentIdx]!; const baselineInfo = baselineInfos[indices.baselineIdx] || DEFAULT_FRAME_INFO; const currentInfo = currentInfos[indices.currentIdx] || DEFAULT_FRAME_INFO; diff --git a/packages/mcp-core/src/tools/support/profile/details-output.ts b/packages/mcp-core/src/tools/support/profile/details-output.ts index 7f44e6214..05f80704a 100644 --- a/packages/mcp-core/src/tools/support/profile/details-output.ts +++ b/packages/mcp-core/src/tools/support/profile/details-output.ts @@ -216,7 +216,7 @@ function getTransactionProfileDurationNs( return null; } - const duration = elapsed[elapsed.length - 1] - elapsed[0]; + const duration = elapsed.at(-1)! - elapsed[0]!; return duration > 0 ? Math.round(duration) : null; } diff --git a/packages/mcp-core/src/tools/support/profile/flamegraph-output.test.ts b/packages/mcp-core/src/tools/support/profile/flamegraph-output.test.ts index 801a8c0b3..47eaaa351 100644 --- a/packages/mcp-core/src/tools/support/profile/flamegraph-output.test.ts +++ b/packages/mcp-core/src/tools/support/profile/flamegraph-output.test.ts @@ -137,7 +137,7 @@ describe("buildFlamegraphAnalysis", () => { it("maps placeholder file and line values to null", () => { const flamegraph = createMockFlamegraph(); flamegraph.shared.frames[0] = { - ...flamegraph.shared.frames[0], + ...flamegraph.shared.frames[0]!, file: "", line: 0, }; @@ -162,12 +162,10 @@ describe("buildFlamegraphAnalysis", () => { }); const [topPath] = analysis.hotPaths; - expect(topPath.stack.map((index) => analysis.frames[index]?.file)).toEqual([ - "main.py", - "utils.py", - "psycopg2/pool.py", - ]); - expect(topPath.stack.at(-1)).toBe(topPath.leaf); + expect(topPath?.stack.map((index) => analysis.frames[index]?.file)).toEqual( + ["main.py", "utils.py", "psycopg2/pool.py"], + ); + expect(topPath?.stack.at(-1)).toBe(topPath!.leaf); expect(analysis.topFunctions).toHaveLength(3); }); @@ -225,7 +223,7 @@ describe("buildFlamegraphComparison", () => { it("detects major regressions", () => { const current = createMockFlamegraph(); // Comparison uses sumDuration, not weight. - current.shared.frame_infos[0].sumDuration = 240_000_000; + current.shared.frame_infos[0]!.sumDuration = 240_000_000; const comparison = buildFlamegraphComparison( createMockFlamegraph(), @@ -250,7 +248,7 @@ describe("buildFlamegraphComparison", () => { const withPlaceholders = () => { const flamegraph = createMockFlamegraph(); flamegraph.shared.frames[0] = { - ...flamegraph.shared.frames[0], + ...flamegraph.shared.frames[0]!, file: "", line: 0, }; @@ -271,7 +269,7 @@ describe("buildFlamegraphComparison", () => { it("keeps improvements in changes when many frames are unchanged", () => { const withFrames = (improvedDurationNs: number) => { const flamegraph = createMockFlamegraph(); - const template = flamegraph.shared.frame_infos[0]; + const template = flamegraph.shared.frame_infos[0]!; flamegraph.shared.frames = Array.from({ length: 13 }, (_, index) => ({ file: `module_${index}.py`, name: `fn_${index}`, @@ -305,9 +303,9 @@ describe("buildFlamegraphComparison", () => { it("detects improvements", () => { const current = createMockFlamegraph(); - current.shared.frame_infos[0].sumDuration = 128_000_000; - current.shared.frame_infos[1].sumDuration = 128_000_000; - current.shared.frame_infos[2].sumDuration = 80_000_000; + current.shared.frame_infos[0]!.sumDuration = 128_000_000; + current.shared.frame_infos[1]!.sumDuration = 128_000_000; + current.shared.frame_infos[2]!.sumDuration = 80_000_000; expect( buildFlamegraphComparison(createMockFlamegraph(), current, { diff --git a/packages/mcp-core/src/tools/support/search-events/formatters.ts b/packages/mcp-core/src/tools/support/search-events/formatters.ts index 06ae5de80..2a5021796 100644 --- a/packages/mcp-core/src/tools/support/search-events/formatters.ts +++ b/packages/mcp-core/src/tools/support/search-events/formatters.ts @@ -413,9 +413,7 @@ export function formatLogResults(params: FormatEventResultsParams): string { "sentry.item_id", ]; - for (let i = 0; i < eventData.length; i++) { - const event = eventData[i]; - + for (const [i, event] of eventData.entries()) { output += `### Log ${i + 1}\n`; if (typeof event.id === "string" && event.id) { diff --git a/packages/mcp-core/src/tools/support/search-events/search.ts b/packages/mcp-core/src/tools/support/search-events/search.ts index ea587cd90..388366f74 100644 --- a/packages/mcp-core/src/tools/support/search-events/search.ts +++ b/packages/mcp-core/src/tools/support/search-events/search.ts @@ -189,7 +189,7 @@ function formatEnvironmentFilter( return undefined; } if (environments.length === 1) { - return `environment:${formatSearchValue(environments[0])}`; + return `environment:${formatSearchValue(environments[0]!)}`; } return `environment:[${environments.map(formatSearchValue).join(",")}]`; } @@ -226,11 +226,11 @@ export function collectRequestedEnvironments( // inside quoted text (e.g. a message value) aren't mistaken for a filter. const tokens = tokenizeSearchQuery(query); for (let i = 0; i < tokens.length; i++) { - const match = /^environment:(.*)$/is.exec(tokens[i]); + const match = /^environment:(.*)$/is.exec(tokens[i]!); if (!match) { continue; } - let value = match[1]; + let value = match[1]!; // An IN-list (`environment:[a, b]`) can be split across tokens on its // internal spaces; rejoin following tokens until the list is closed. while ( @@ -287,7 +287,7 @@ function tokenizeSearchQuery(query: string): string[] { let escaped = false; for (let i = 0; i < query.length; i += 1) { - const char = query[i]; + const char = query.charAt(i); if (escaped) { currentToken += char; escaped = false; diff --git a/packages/mcp-core/src/tools/support/search-events/utils.test.ts b/packages/mcp-core/src/tools/support/search-events/utils.test.ts index e34afd335..95297d996 100644 --- a/packages/mcp-core/src/tools/support/search-events/utils.test.ts +++ b/packages/mcp-core/src/tools/support/search-events/utils.test.ts @@ -80,8 +80,8 @@ describe("validateSearch tool contract", () => { }); expect(requests).toHaveLength(1); - expect(requests[0].getAll("environment")).toEqual([]); - expect(requests[0].get("query")).toBe(query); + expect(requests[0]?.getAll("environment")).toEqual([]); + expect(requests[0]?.get("query")).toBe(query); expect(result).toEqual({ result: { valid: true, message: "Search validation passed." }, }); @@ -1162,7 +1162,7 @@ describe("fetchCustomAttributes", () => { ); expect(requests).toHaveLength(1); - expect(requests[0].get("attributeType")).toBeNull(); + expect(requests[0]!.get("attributeType")).toBeNull(); for (const params of requests) { expect(params.get("itemType")).toBe("spans"); expect(params.get("project")).toBe("123"); diff --git a/packages/mcp-core/src/tools/support/search-events/utils.ts b/packages/mcp-core/src/tools/support/search-events/utils.ts index 7c6aefa23..3de0bb56d 100644 --- a/packages/mcp-core/src/tools/support/search-events/utils.ts +++ b/packages/mcp-core/src/tools/support/search-events/utils.ts @@ -278,7 +278,7 @@ function maskQuotedRegions(query: string): string { let escaped = false; for (let i = 0; i < query.length; i += 1) { - const char = query[i]; + const char = query.charAt(i); if (escaped) { escaped = false; out += quote ? "x" : char; @@ -1225,7 +1225,7 @@ function resolveAvailableFields( const replacementAttribute = { ...field, key: replacementKey }; available.set(replacementKey, replacementAttribute); replaced.push(field); - fieldTypes[replacementKey] = fieldTypes[key]; + fieldTypes[replacementKey] = fieldTypes[key]!; delete fieldTypes[key]; } else if (!attributeDeprecated && !available.has(key)) { available.set(key, field); diff --git a/packages/mcp-core/src/tools/support/search-issue-events/utils.ts b/packages/mcp-core/src/tools/support/search-issue-events/utils.ts index 6c3e4fa5b..cea7af298 100644 --- a/packages/mcp-core/src/tools/support/search-issue-events/utils.ts +++ b/packages/mcp-core/src/tools/support/search-issue-events/utils.ts @@ -120,9 +120,9 @@ Received: ${params.issueUrl}`, organizationSlug: resolveScopedOrganizationSlug({ resourceLabel: "Issue", scopedOrganizationSlug: params.organizationSlug, - urlOrganizationSlug: orgMatch[1], + urlOrganizationSlug: orgMatch[1]!, }), - issueId: orgMatch[2], + issueId: orgMatch[2]!, }; } diff --git a/packages/mcp-core/src/tools/support/traces/semantic-display.ts b/packages/mcp-core/src/tools/support/traces/semantic-display.ts index 212ce7d47..68f92bcb3 100644 --- a/packages/mcp-core/src/tools/support/traces/semantic-display.ts +++ b/packages/mcp-core/src/tools/support/traces/semantic-display.ts @@ -624,8 +624,8 @@ function formatHttpTarget(value: string): string { const trimmed = value.trim(); if (!/^[a-z][a-z0-9+.-]*:\/\//i.test(trimmed)) { - const withoutFragment = trimmed.split("#", 1)[0]; - return withoutFragment.split("?", 1)[0]; + const withoutFragment = trimmed.split("#", 1)[0]!; + return withoutFragment.split("?", 1)[0]!; } try { @@ -633,8 +633,8 @@ function formatHttpTarget(value: string): string { const path = url.pathname === "/" ? "" : url.pathname; return `${url.host}${path}`; } catch { - const withoutFragment = trimmed.split("#", 1)[0]; - return withoutFragment.split("?", 1)[0]; + const withoutFragment = trimmed.split("#", 1)[0]!; + return withoutFragment.split("?", 1)[0]!; } } diff --git a/packages/mcp-core/src/transports/stdio.test.ts b/packages/mcp-core/src/transports/stdio.test.ts index 476a57399..913efd028 100644 --- a/packages/mcp-core/src/transports/stdio.test.ts +++ b/packages/mcp-core/src/transports/stdio.test.ts @@ -17,7 +17,7 @@ const server = { async function spanAttributes(context: Parameters[1]) { await startStdio(server, context); - const [options] = vi.mocked(startSpan).mock.calls[0]; + const [options] = vi.mocked(startSpan).mock.calls[0]!; return options.attributes; } diff --git a/packages/mcp-core/src/utils/url-utils.ts b/packages/mcp-core/src/utils/url-utils.ts index 27d1f91d8..8a5bcdf9d 100644 --- a/packages/mcp-core/src/utils/url-utils.ts +++ b/packages/mcp-core/src/utils/url-utils.ts @@ -99,7 +99,7 @@ function extractTraceMetricFromAggregate( return null; } - const args = match[1] + const args = match[1]! .split(",") .map((arg) => arg.trim()) .filter((arg) => arg.length > 0); @@ -109,9 +109,9 @@ function extractTraceMetricFromAggregate( } return normalizeTraceMetric({ - name: args[1], - type: args[2], - unit: args[3], + name: args[1]!, + type: args[2]!, + unit: args[3]!, }); } @@ -669,12 +669,12 @@ export function extractConversationIdFromSearchQuery( } const pattern = /gen_ai\.conversation\.id:(?:"([^"]+)"|([^\s)]+))/g; - const matches = [...query.matchAll(pattern)]; - if (matches.length !== 1) { + const [match, ...otherMatches] = query.matchAll(pattern); + if (match === undefined || otherMatches.length > 0) { return undefined; } - const conversationId = matches[0].at(1) ?? matches[0][2]; + const conversationId = match[1] ?? match[2]!; if (conversationId.startsWith("[")) { return undefined; } diff --git a/packages/mcp-core/tsconfig.json b/packages/mcp-core/tsconfig.json index 1fa90ef72..4061fbae4 100644 --- a/packages/mcp-core/tsconfig.json +++ b/packages/mcp-core/tsconfig.json @@ -1,7 +1,6 @@ { "extends": "../../tsconfig.base.json", "compilerOptions": { - "noUncheckedIndexedAccess": false, "lib": ["ES2023", "ES2024.String"], "allowJs": true, "sourceMap": true,