From 12a6f6bbd87589ac3bfdf6bbdcebe3ec3ad9f337 Mon Sep 17 00:00:00 2001 From: "sentry-junior[bot]" <264270552+sentry-junior[bot]@users.noreply.github.com> Date: Mon, 16 Nov 2026 09:42:14 +0000 Subject: [PATCH 1/2] fix(transport): Record and warn about items dropped for size Envelope items that are still oversized after size reduction were skipped with only a debug log, so the drop was invisible at the default log level and never reached client reports. Log the drop at warn level and record a send_error lost event, like the HTTP 413 path. Fixes #3209 --- sentry-ruby/lib/sentry/transport.rb | 3 ++- sentry-ruby/spec/sentry/transport_spec.rb | 7 +++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/sentry-ruby/lib/sentry/transport.rb b/sentry-ruby/lib/sentry/transport.rb index 71bd2f878..ddf0c5ab9 100644 --- a/sentry-ruby/lib/sentry/transport.rb +++ b/sentry-ruby/lib/sentry/transport.rb @@ -76,7 +76,8 @@ def serialize_envelope(envelope) result, oversized = item.serialize if oversized - log_debug("Envelope item [#{item.type}] is still oversized after size reduction: {#{item.size_breakdown}}") + log_warn("Envelope item [#{item.type}] is still oversized after size reduction: {#{item.size_breakdown}}") + record_lost_event(:send_error, item.data_category, num: item.item_count, num_bytes: item.lost_event_byte_size) next end diff --git a/sentry-ruby/spec/sentry/transport_spec.rb b/sentry-ruby/spec/sentry/transport_spec.rb index a7cb90a41..b97658e1a 100644 --- a/sentry-ruby/spec/sentry/transport_spec.rb +++ b/sentry-ruby/spec/sentry/transport_spec.rb @@ -571,6 +571,13 @@ expect(io.string).not_to match(/Sending envelope with items \[event\]/) end + it "records the dropped event as lost and logs a warning" do + subject.send_envelope(envelope) + + expect(subject.discarded_events[[:send_error, "error"]]).to eq(1) + expect(io.string).to match(/WARN -- sentry: Envelope item \[event\] is still oversized after size reduction/) + end + context "with other types of items" do before do 5.times { subject.record_lost_event(:ratelimit_backoff, 'error') } From ca3acf4f33c57731f9f07bc59a1ee96312fff9fa Mon Sep 17 00:00:00 2001 From: "sentry-junior[bot]" <264270552+sentry-junior[bot]@users.noreply.github.com> Date: Tue, 17 Nov 2026 10:15:48 +0000 Subject: [PATCH 2/2] fix(transport): Warn once per item type about oversized items Later drops of the same item type are logged at debug level so apps that keep producing oversized items don't flood their logs. Every drop is still recorded as a lost event. --- sentry-ruby/lib/sentry/transport.rb | 17 ++++++++++++++++- sentry-ruby/spec/sentry/transport_spec.rb | 9 +++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/sentry-ruby/lib/sentry/transport.rb b/sentry-ruby/lib/sentry/transport.rb index ddf0c5ab9..60e4f4d4e 100644 --- a/sentry-ruby/lib/sentry/transport.rb +++ b/sentry-ruby/lib/sentry/transport.rb @@ -1,6 +1,7 @@ # frozen_string_literal: true require "json" +require "concurrent/map" require "sentry/envelope" module Sentry @@ -76,7 +77,7 @@ def serialize_envelope(envelope) result, oversized = item.serialize if oversized - log_warn("Envelope item [#{item.type}] is still oversized after size reduction: {#{item.size_breakdown}}") + log_oversized_item(item) record_lost_event(:send_error, item.data_category, num: item.item_count, num_bytes: item.lost_event_byte_size) next @@ -191,6 +192,20 @@ def flush private + # Warns once per item type, then logs at debug level, so an app that keeps + # producing oversized items doesn't flood its logs. Every drop is still + # recorded as a lost event. + def log_oversized_item(item) + message = "Envelope item [#{item.type}] is still oversized after size reduction: {#{item.size_breakdown}}" + @oversized_item_types_warned ||= Concurrent::Map.new + + if @oversized_item_types_warned.put_if_absent(item.type, true).nil? + log_warn("#{message}. Further oversized [#{item.type}] items are dropped with a debug log only.") + else + log_debug(message) + end + end + def fetch_pending_client_report(force: false) return nil unless @send_client_reports return nil if !force && @last_client_report_sent > Time.now - CLIENT_REPORT_INTERVAL diff --git a/sentry-ruby/spec/sentry/transport_spec.rb b/sentry-ruby/spec/sentry/transport_spec.rb index b97658e1a..403bad5b4 100644 --- a/sentry-ruby/spec/sentry/transport_spec.rb +++ b/sentry-ruby/spec/sentry/transport_spec.rb @@ -578,6 +578,15 @@ expect(io.string).to match(/WARN -- sentry: Envelope item \[event\] is still oversized after size reduction/) end + it "warns only once per item type but records every drop" do + subject.send_envelope(envelope) + subject.send_envelope(subject.envelope_from_event(event)) + + expect(subject.discarded_events[[:send_error, "error"]]).to eq(2) + expect(io.string.scan(/WARN -- sentry: Envelope item \[event\] is still oversized/).size).to eq(1) + expect(io.string.scan(/DEBUG -- sentry: Envelope item \[event\] is still oversized/).size).to eq(1) + end + context "with other types of items" do before do 5.times { subject.record_lost_event(:ratelimit_backoff, 'error') }