From 5a1b8341d77d3fbf23ef7ecd7fc82403cd716dd3 Mon Sep 17 00:00:00 2001 From: John Ryan Date: Wed, 11 Nov 2026 11:21:25 -0800 Subject: [PATCH] Fix serveAvailableExtensions test This test wasn't passing the correct X-DevTools-Request header. This fixes it by using the new serveExtensions helper, which includes the header on each request. --- .../server/devtools_extensions_api_test.dart | 24 ++++++------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/packages/devtools_shared/test/server/devtools_extensions_api_test.dart b/packages/devtools_shared/test/server/devtools_extensions_api_test.dart index 2ae8d8bc352..899ae5cbd03 100644 --- a/packages/devtools_shared/test/server/devtools_extensions_api_test.dart +++ b/packages/devtools_shared/test/server/devtools_extensions_api_test.dart @@ -60,6 +60,7 @@ void main() { Future serveExtensions( ExtensionsManager manager, { bool includeRuntimeRoot = true, + String? packageRootUriOverride, }) async { final request = Request( 'post', @@ -68,9 +69,9 @@ void main() { host: 'localhost', path: ExtensionsApi.apiServeAvailableExtensions, queryParameters: { - ExtensionsApi.packageRootUriPropertyName: includeRuntimeRoot - ? extensionTestManager.runtimeAppRoot - : null, + ExtensionsApi.packageRootUriPropertyName: + packageRootUriOverride ?? + (includeRuntimeRoot ? extensionTestManager.runtimeAppRoot : null), }, ), headers: const {devToolsRequestHeader: '1'}, @@ -184,20 +185,9 @@ void main() { () async { await initializeTestDirectory(); const uncUri = 'file://remotehost/share/app'; - final request = Request( - 'post', - Uri( - scheme: 'https', - host: 'localhost', - path: ExtensionsApi.apiServeAvailableExtensions, - queryParameters: {ExtensionsApi.packageRootUriPropertyName: uncUri}, - ), - ); - final response = await ServerApi.handle( - request, - extensionsManager: extensionsManager, - deeplinkManager: FakeDeeplinkManager(), - dtd: dtd!.info, + final response = await serveExtensions( + extensionsManager, + packageRootUriOverride: uncUri, ); expect(response.statusCode, HttpStatus.badRequest); expect(extensionsManager.devtoolsExtensions, isEmpty);