From b461bf99fffa722b28c4e72b7e94f5b7cee5b69f Mon Sep 17 00:00:00 2001 From: MeAkib Date: Fri, 16 Oct 2026 00:09:22 +0600 Subject: [PATCH] fix(@schematics/angular): show routing module suffixes in `findModule` error When only routing modules are found, the error message printed the optional `routingModuleExt` parameter, which no schematic passes, so users saw "Modules with suffix 'undefined' are strictly reserved for routing.". Since 0b7d48c7ca the lookup checks both `-routing-module.ts` and `-routing.module.ts`, so list the suffixes that are actually used. --- packages/schematics/angular/utility/find-module.ts | 2 +- packages/schematics/angular/utility/find-module_spec.ts | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/schematics/angular/utility/find-module.ts b/packages/schematics/angular/utility/find-module.ts index c98b52a0cbe2..e6ad0c5620e6 100644 --- a/packages/schematics/angular/utility/find-module.ts +++ b/packages/schematics/angular/utility/find-module.ts @@ -117,7 +117,7 @@ export function findModule( const errorMsg = foundRoutingModule ? 'Could not find a non Routing NgModule.' + - `\nModules with suffix '${routingModuleExt}' are strictly reserved for routing.` + + `\nModules with suffix '${routingModuleExtensions.join("' or '")}' are strictly reserved for routing.` + `\nUse the '--skip-import' option to skip importing in NgModule.` : `Could not find an NgModule. Use the '--skip-import' option to skip importing in NgModule.`; diff --git a/packages/schematics/angular/utility/find-module_spec.ts b/packages/schematics/angular/utility/find-module_spec.ts index 0db295ae384f..dcc8a7df057e 100644 --- a/packages/schematics/angular/utility/find-module_spec.ts +++ b/packages/schematics/angular/utility/find-module_spec.ts @@ -56,6 +56,9 @@ describe('find-module', () => { expect(() => findModule(host, 'foo/src/app/anything-routing')).toThrowError( /Could not find a non Routing NgModule/, ); + expect(() => findModule(host, 'foo/src/app/anything-routing')).toThrowError( + /Modules with suffix '-routing-module\.ts' or '-routing\.module\.ts' are strictly reserved/, + ); }); it('should throw if two modules found', () => {