From 33787b4a29cd073856b2a34adbb07369e526d061 Mon Sep 17 00:00:00 2001 From: Tanner Linsley Date: Thu, 19 Nov 2026 17:43:50 -0700 Subject: [PATCH 1/2] feat: add an Ultracite preset to Biome --- .changeset/biome-ultracite-preset.md | 6 +++ .../cli/skills/create-app-scaffold/SKILL.md | 4 ++ packages/cli/tests-e2e/biome-preset.spec.ts | 42 ++++++++++++++++++ packages/cli/tests-e2e/helpers.ts | 6 +++ .../base/src/components/Footer.tsx.ejs | 2 +- .../base/src/components/ThemeToggle.tsx.ejs | 44 ++++++++++++++++--- .../project/base/src/routes/__root.tsx.ejs | 2 +- .../project/base/src/routes/index.tsx.ejs | 6 +-- .../toolchains/biome/assets/biome.json.ejs | 9 +++- .../react/toolchains/biome/info.json | 20 ++++++++- .../react/toolchains/biome/package.json | 10 ----- .../react/toolchains/biome/package.json.ejs | 11 +++++ .../solid/project/base/rsbuild.config.ts.ejs | 2 +- .../base/src/components/Header.tsx.ejs | 5 ++- .../project/base/src/routes/index.tsx.ejs | 17 ++++--- .../toolchains/biome/assets/biome.json.ejs | 4 +- .../solid/toolchains/biome/info.json | 20 ++++++++- .../solid/toolchains/biome/package.json | 10 ----- .../solid/toolchains/biome/package.json.ejs | 11 +++++ packages/create/tests/biome-preset.test.ts | 44 +++++++++++++++++++ packages/create/tests/bundlers.test.ts | 11 ++--- 21 files changed, 236 insertions(+), 50 deletions(-) create mode 100644 .changeset/biome-ultracite-preset.md create mode 100644 packages/cli/tests-e2e/biome-preset.spec.ts delete mode 100644 packages/create/src/frameworks/react/toolchains/biome/package.json create mode 100644 packages/create/src/frameworks/react/toolchains/biome/package.json.ejs delete mode 100644 packages/create/src/frameworks/solid/toolchains/biome/package.json create mode 100644 packages/create/src/frameworks/solid/toolchains/biome/package.json.ejs create mode 100644 packages/create/tests/biome-preset.test.ts diff --git a/.changeset/biome-ultracite-preset.md b/.changeset/biome-ultracite-preset.md new file mode 100644 index 000000000..0f6ccdf7c --- /dev/null +++ b/.changeset/biome-ultracite-preset.md @@ -0,0 +1,6 @@ +--- +"@tanstack/create": minor +"@tanstack/cli": minor +--- + +Add an optional Ultracite preset to the Biome toolchain for React and Solid apps. Keep the existing recommended Biome configuration as the default. diff --git a/packages/cli/skills/create-app-scaffold/SKILL.md b/packages/cli/skills/create-app-scaffold/SKILL.md index 0602efcc9..540b1a650 100644 --- a/packages/cli/skills/create-app-scaffold/SKILL.md +++ b/packages/cli/skills/create-app-scaffold/SKILL.md @@ -178,3 +178,7 @@ See also: query-docs-library-metadata/SKILL.md § Common Mistakes - [Build tool options](references/bundlers.md) - [Deployment provider options](references/deployment-providers.md) - [Toolchain options](references/toolchains.md) + +### Biome presets + +Biome keeps its recommended configuration by default. To select Ultracite while creating an app, use `--toolchain biome --add-on-config '{"biome":{"preset":"ultracite"}}'`. Ultracite requires Node `^22.22.2 || >=24.15.0` in the generated app and uses its core and framework presets. Component filenames accept PascalCase and kebab-case. The selected preset is saved in the project configuration. diff --git a/packages/cli/tests-e2e/biome-preset.spec.ts b/packages/cli/tests-e2e/biome-preset.spec.ts new file mode 100644 index 000000000..9540823ff --- /dev/null +++ b/packages/cli/tests-e2e/biome-preset.spec.ts @@ -0,0 +1,42 @@ +import { execFile } from 'node:child_process' +import { promisify } from 'node:util' +import { readFile } from 'node:fs/promises' +import { join } from 'node:path' +import { expect, test } from '@playwright/test' +import { attachRuntimeGuards, createAppFixture, optimizePageForFastE2E } from './helpers' + +const execFileAsync = promisify(execFile) + +for (const framework of ['react', 'solid'] as const) { + for (const bundler of ['vite', 'rsbuild'] as const) { + test(`@matrix builds, types and lints ${framework} ${bundler} with the Ultracite preset`, async ({ page }) => { + const fixture = await createAppFixture({ + appName: `${framework}-${bundler}-ultracite`, framework, bundler, + packageManager: bundler === 'vite' ? 'npm' : 'pnpm', + toolchain: 'biome', addOnConfig: { biome: { preset: 'ultracite' } }, + runQualityGatesChecks: true, + afterCreate: async (appDir) => { + const pkg = JSON.parse(await readFile(join(appDir, 'package.json'), 'utf8')) + expect(pkg.devDependencies.ultracite).toBe('8.3.1') + expect(pkg.devDependencies['@biomejs/biome']).toBe('2.6.7') + expect(pkg.devDependencies.oxlint).toBeUndefined() + const config = JSON.parse(await readFile(join(appDir, 'biome.json'), 'utf8')) + expect(config.extends).toEqual(['ultracite/biome/core', `ultracite/biome/${framework}`]) + }, + }) + const guards = attachRuntimeGuards(page, fixture.url) + try { + await execFileAsync('npm', ['run', 'lint'], { cwd: fixture.appDir }) + await optimizePageForFastE2E(page) + await page.goto(fixture.url) + await expect(page.getByRole('heading', { name: 'Start simple, ship quickly.' })).toBeVisible() + await expect(page.getByText('Type-Safe Routing', { exact: true })).toBeVisible() + guards.assertClean() + } finally { + guards.dispose() + await fixture.stop() + await fixture.cleanup() + } + }) + } +} diff --git a/packages/cli/tests-e2e/helpers.ts b/packages/cli/tests-e2e/helpers.ts index de699d23d..0708e4d2c 100644 --- a/packages/cli/tests-e2e/helpers.ts +++ b/packages/cli/tests-e2e/helpers.ts @@ -29,6 +29,7 @@ type CreateAppFixtureOptions = { deployment?: string routerOnly?: boolean template?: string + addOnConfig?: Record> addOns?: Array postCreateAddOns?: Array afterCreate?: (appDir: string) => Promise @@ -373,6 +374,7 @@ export async function createAppFixture( template, addOns, afterCreate, + addOnConfig, postCreateAddOns, skipDevServer, runQualityGatesChecks = false, @@ -419,6 +421,10 @@ export async function createAppFixture( createArgs.push('--template', template) } + if (addOnConfig) { + createArgs.push('--add-on-config', JSON.stringify(addOnConfig)) + } + if (addOns?.length) { createArgs.push('--add-ons', addOns.join(',')) } diff --git a/packages/create/src/frameworks/react/project/base/src/components/Footer.tsx.ejs b/packages/create/src/frameworks/react/project/base/src/components/Footer.tsx.ejs index f70e476b6..583871e9f 100644 --- a/packages/create/src/frameworks/react/project/base/src/components/Footer.tsx.ejs +++ b/packages/create/src/frameworks/react/project/base/src/components/Footer.tsx.ejs @@ -3,7 +3,7 @@ export default function Footer() { const year = new Date().getFullYear() return ( -