From fa2f9bad5895d869b06f773c1d6660cf13b6bc25 Mon Sep 17 00:00:00 2001 From: Benjamin Chastanier Date: Fri, 6 Nov 2026 14:59:37 +0100 Subject: [PATCH] chore(QOV-2504): remove secret export option Ticket: QOV-2504 --- .../src/lib/domains-environments-data-access.spec.ts | 6 +++--- .../src/lib/domains-environments-data-access.ts | 2 +- package.json | 2 +- yarn.lock | 10 +++++----- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/libs/domains/environments/data-access/src/lib/domains-environments-data-access.spec.ts b/libs/domains/environments/data-access/src/lib/domains-environments-data-access.spec.ts index 4c8e2038778..05b2b56bc9f 100644 --- a/libs/domains/environments/data-access/src/lib/domains-environments-data-access.spec.ts +++ b/libs/domains/environments/data-access/src/lib/domains-environments-data-access.spec.ts @@ -7,7 +7,7 @@ describe('mutations.exportTerraform', () => { jest.restoreAllMocks() }) - it.each([true, false])('should exclude secrets even if a caller supplies exportSecrets=%s', async (exportSecrets) => { + it('should request the Terraform archive as a blob without a secret export option', async () => { const archive = new File(['terraform'], 'terraform.zip', { type: 'application/zip' }) const exportConfiguration = jest .spyOn(EnvironmentExportApi.prototype, 'exportEnvironmentConfigurationIntoTerraform') @@ -18,11 +18,11 @@ describe('mutations.exportTerraform', () => { headers: {}, config: { headers: new AxiosHeaders() }, }) - const request = { environmentId: '111', exportSecrets } + const request = { environmentId: '111' } const result = await mutations.exportTerraform(request) - expect(exportConfiguration).toHaveBeenCalledWith('111', false, { responseType: 'blob' }) + expect(exportConfiguration).toHaveBeenCalledWith('111', { responseType: 'blob' }) expect(result).toBe(archive) }) }) diff --git a/libs/domains/environments/data-access/src/lib/domains-environments-data-access.ts b/libs/domains/environments/data-access/src/lib/domains-environments-data-access.ts index f606bc61dae..bf9445faca2 100644 --- a/libs/domains/environments/data-access/src/lib/domains-environments-data-access.ts +++ b/libs/domains/environments/data-access/src/lib/domains-environments-data-access.ts @@ -209,7 +209,7 @@ export const mutations = { return result.data }, async exportTerraform({ environmentId }: { environmentId: string }) { - const result = await environmentExportApi.exportEnvironmentConfigurationIntoTerraform(environmentId, false, { + const result = await environmentExportApi.exportEnvironmentConfigurationIntoTerraform(environmentId, { responseType: 'blob', }) return result.data diff --git a/package.json b/package.json index 169b4802486..e4da779f480 100644 --- a/package.json +++ b/package.json @@ -78,7 +78,7 @@ "mermaid": "11.6.0", "monaco-editor": "0.53.0", "posthog-js": "1.345.1", - "qovery-typescript-axios": "1.1.1032", + "qovery-typescript-axios": "1.1.1035", "react": "19.3.0", "react-country-flag": "3.0.2", "react-datepicker": "4.12.0", diff --git a/yarn.lock b/yarn.lock index 4c6b6fb39e1..cce3c7d3dd6 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6266,7 +6266,7 @@ __metadata: prettier: 3.2.5 prettier-plugin-tailwindcss: 0.5.14 pretty-quick: 4.0.0 - qovery-typescript-axios: 1.1.1032 + qovery-typescript-axios: 1.1.1035 qovery-ws-typescript-axios: 0.1.666 react: 19.3.0 react-country-flag: 3.0.2 @@ -24366,12 +24366,12 @@ __metadata: languageName: node linkType: hard -"qovery-typescript-axios@npm:1.1.1032": - version: 1.1.1032 - resolution: "qovery-typescript-axios@npm:1.1.1032" +"qovery-typescript-axios@npm:1.1.1035": + version: 1.1.1035 + resolution: "qovery-typescript-axios@npm:1.1.1035" dependencies: axios: 1.20.0 - checksum: b183794d7735a7f60bf5a69200e09340f61a1e866a8ef57f92a232e6d4967781c9e045b81262cbee3e3375a8b307fe9d50278a5886506f9e0f84b0421396cf5f + checksum: 8e7e1298543d015b1b474daa9899fdc4568d5e1dbeda3b54b898bde94c851da20e1b351c0784a051f6f1b46570b3a6bcc663a8f6da6ab281eddc6b904a971aba languageName: node linkType: hard