From 321bb3a386c1f4ca90b6a1a3c489fa49f9a7c396 Mon Sep 17 00:00:00 2001 From: HackingGate Date: Wed, 4 Nov 2026 23:42:56 +0900 Subject: [PATCH] consistent-frame: the review control plants a section that skips the shared render The control was a terminal help screen. REVIEW.md is a frame this repository writes once, in render(), so the planted case is one section written outside it. Claude-Session: https://claude.ai/code/session_01EycJ7mELqeFUcQjsqrrpJb --- policy/upheld.toml | 4 ++-- review-controls.json | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/policy/upheld.toml b/policy/upheld.toml index 1476889..a569753 100644 --- a/policy/upheld.toml +++ b/policy/upheld.toml @@ -262,8 +262,8 @@ misses = "Make the refusal src/guard/push.rs prints after a failed forge lookup [[review.control]] record = "consistent-frame" -catches = "Make `uphold check --help` print its options before its usage line, while every other subcommand's help prints usage first." -misses = "Add a `--json` option to `uphold check --help`, listed in the options section in the same place and order as on every other subcommand's help." +catches = "Make scripts/review.py write the `consistent-frame` section of REVIEW.md from a string of its own, with **Ask** above **Applies when**, while render() writes every other record's section with **Applies when** first." +misses = "Change render() in scripts/review.py so every record's section of REVIEW.md prints **Ask** above **Applies when**." [[review.control]] record = "conways-law" diff --git a/review-controls.json b/review-controls.json index b182b91..22d66ec 100644 --- a/review-controls.json +++ b/review-controls.json @@ -12,8 +12,8 @@ }, { "record": "consistent-frame", - "catches": "Make `uphold check --help` print its options before its usage line, while every other subcommand's help prints usage first.", - "misses": "Add a `--json` option to `uphold check --help`, listed in the options section in the same place and order as on every other subcommand's help." + "catches": "Make scripts/review.py write the `consistent-frame` section of REVIEW.md from a string of its own, with **Ask** above **Applies when**, while render() writes every other record's section with **Applies when** first.", + "misses": "Change render() in scripts/review.py so every record's section of REVIEW.md prints **Ask** above **Applies when**." }, { "record": "conways-law",