From a79f70a6feee3ac1e2ad1342c4ba1ff83653edf9 Mon Sep 17 00:00:00 2001
From: swmal <897655+swmal@users.noreply.github.com>
Date: Mon, 12 Oct 2026 16:05:34 +0200
Subject: [PATCH 1/2] Fix #2572: namespace prefixes and calc attributes in
worksheet XML
---
.../Worksheet/XmlWriter/WorksheetXmlWriter.cs | 114 +++++------
.../Core/Worksheet/WorksheetXmlWriterTests.cs | 181 ++++++++++++++++++
src/EPPlusTest/EPPlus.Test.csproj | 6 +
src/EPPlusTest/Workbooks/sc1083-flags.xlsx | Bin 0 -> 7015 bytes
src/EPPlusTest/Workbooks/sc1083-sdk.xlsx | Bin 0 -> 10015 bytes
5 files changed, 247 insertions(+), 54 deletions(-)
create mode 100644 src/EPPlusTest/Core/Worksheet/WorksheetXmlWriterTests.cs
create mode 100644 src/EPPlusTest/Workbooks/sc1083-flags.xlsx
create mode 100644 src/EPPlusTest/Workbooks/sc1083-sdk.xlsx
diff --git a/src/EPPlus/Core/Worksheet/XmlWriter/WorksheetXmlWriter.cs b/src/EPPlus/Core/Worksheet/XmlWriter/WorksheetXmlWriter.cs
index 28f85fe222..13f1e9550c 100644
--- a/src/EPPlus/Core/Worksheet/XmlWriter/WorksheetXmlWriter.cs
+++ b/src/EPPlus/Core/Worksheet/XmlWriter/WorksheetXmlWriter.cs
@@ -512,7 +512,7 @@ private void UpdateRowCellData(StreamWriter sw, string prefix)
}
else
{
- cache.Append($"<{cTag} r=\"{cse.CellAddress}\" s=\"{styleID}\"{ConvertUtil.GetCellType(v, true)}{mdAttr}>{GetFormulaValue(v, prefix)}");
+ cache.Append($"<{cTag} r=\"{cse.CellAddress}\" s=\"{styleID}\"{ConvertUtil.GetCellType(v, true)}{mdAttr}><{fTag} t=\"shared\" si=\"{sfId}\" {mdAttrForFTag}/>{GetFormulaValue(v, prefix)}");
}
}
else
@@ -1154,7 +1154,7 @@ private string UpdateConditionalFormattingAttributes(
return cache.ToString();
}
- private string GetXMLCFExt(string prefix, ExcelConditionalFormattingRule format, int i, int count)
+ private string GetXMLCFExt(string prefix, string mainPrefix, ExcelConditionalFormattingRule format, int i, int count)
{
var cache = new StringBuilder();
@@ -1349,7 +1349,7 @@ private string GetXMLCFExt(string prefix, ExcelConditionalFormattingRule format,
cache.Append($"<{prefix}cfRule type=\"iconSet\" priority=\"{format.Priority}\" id=\"{{{uid}}}\">");
cache.Append($"<{prefix}iconSet ");
- cache.Append($"iconSet=\"{iconSetString}\"");
+ cache.Append($"iconSet=\"{iconSetString}\"");
if (showValue == false)
{
@@ -1514,7 +1514,8 @@ private string GetXMLCFExt(string prefix, ExcelConditionalFormattingRule format,
if (format.Style.HasValue)
{
- WriteStyle(cache, prefix, format);
+ // Sc1083: The dxf children belong to the main schema, so they need the main prefix.
+ WriteStyle(cache, prefix, mainPrefix, format);
}
}
cache.Append($"");
@@ -1578,7 +1579,8 @@ private string UpdateExtLstConditionalFormatting(string mainPrefix)
foreach (var rule in pivotCFs)
{
- cache.Append(GetXMLCFExt(prefix, rule, 0, 1));
+ // Sc1083: Pass mainPrefix so elements from the main schema get the worksheet's namespace prefix.
+ cache.Append(GetXMLCFExt(prefix, mainPrefix, rule, 0, 1));
}
foreach (var ruleList in addressDict)
@@ -1586,7 +1588,8 @@ private string UpdateExtLstConditionalFormatting(string mainPrefix)
for (int i = 0; i < ruleList.Value.Count; i++)
{
var format = ruleList.Value[i];
- cache.Append(GetXMLCFExt(prefix, ruleList.Value[i], i, ruleList.Value.Count));
+ // Sc1083: Pass mainPrefix so elements from the main schema get the worksheet's namespace prefix.
+ cache.Append(GetXMLCFExt(prefix, mainPrefix, ruleList.Value[i], i, ruleList.Value.Count));
}
}
@@ -1637,11 +1640,11 @@ string WriteColorOption(string nodeName, ExcelDxfColor color)
return returnString;
}
- private string WriteCfIcon(ExcelConditionalFormattingIconDataBarValue icon, bool gteCheck = true)
+ private string WriteCfIcon(string prefix, ExcelConditionalFormattingIconDataBarValue icon, bool gteCheck = true)
{
StringBuilder cache = new StringBuilder();
- cache.Append($"");
}
- void WriteStyle(StringBuilder cache, string prefix, ExcelConditionalFormattingRule format)
+ void WriteStyle(StringBuilder cache, string prefix, string mainPrefix, ExcelConditionalFormattingRule format)
{
+ // #2572: dxf itself is in the x14 namespace (prefix), but its children belong to the main schema (mainPrefix).
if (format.Style.HasValue)
{
cache.Append($"<{prefix}dxf>");
if (format.Style.Font.HasValue)
{
- cache.Append($"");
+ cache.Append($"<{mainPrefix}font>");
if (format.Style.Font.Bold == true)
{
- cache.Append($"");
+ cache.Append($"<{mainPrefix}b/>");
}
if (format.Style.Font.Italic == true)
{
if (format.Style.Font.Bold == false || format.Style.Font.Bold == null)
{
- cache.Append("");
+ cache.Append($"<{mainPrefix}b val=\"0\"/>");
}
- cache.Append($"");
+ cache.Append($"<{mainPrefix}i/>");
}
if (format.Style.Font.Bold == false && format.Style.Font.Italic == false)
{
- cache.Append("");
- cache.Append("");
+ cache.Append($"<{mainPrefix}b val=\"0\"/>");
+ cache.Append($"<{mainPrefix}i val=\"0\"/>");
}
if (format.Style.Font.Strike == true)
{
- cache.Append($"